mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-11-17 19:32:45 +03:00
b6bf0183ba
Code-health ratchet on PR #106742 (BLE001/S110/HX006), no behaviour change: - narrow per-row JSON skips: hosted_room_attachments.reconcile_room_events (ValueError/TypeError/AttributeError/RecursionError), hermes_state_gateway routing-entry lookups (ValueError/TypeError/RecursionError) - approval_context: only the gateway import is optional (ImportError); finite_turn_required() is a ContextVar read that cannot fail - deliberate boundaries keep their behaviour and now log the traceback: profile park (exc_info), session-store init (module logger, same "gateway.run" name, still WARNING), a2a profile dispatch (local log; outbound reply stays redacted), readiness probe and session_search profile open (debug), Windows control-pipe thread hand-off (debug; start() re-raises), eval harness top level (logger.exception) - managed_worker.main: traceback goes to the worker's own stderr (the owner spawns it with stderr=DEVNULL) via a non-propagating handler, never the channel or profile log files; the owner still gets only managed_worker_failed - evals/shared_gateway: timeout=30 on git rev-parse/diff calls (cherry picked from commit dfc56cdd5ab875bd14b921de71be4a5bc8afc57f)
101 lines
4.7 KiB
Python
101 lines
4.7 KiB
Python
"""Live POSIX bootstrap descriptor check, not an execution/readiness handshake proof."""
|
|
import argparse
|
|
import json
|
|
import os
|
|
from pathlib import Path
|
|
import signal
|
|
import socket
|
|
import subprocess
|
|
import tempfile
|
|
import time
|
|
|
|
|
|
def identify(state):
|
|
path = state / 'gateway.sock'
|
|
pointer = state / 'gateway.sock.path'
|
|
if pointer.exists():
|
|
path = Path(pointer.read_text(encoding='utf-8').strip())
|
|
with socket.socket(socket.AF_UNIX, socket.SOCK_STREAM) as peer:
|
|
peer.settimeout(1)
|
|
peer.connect(str(path))
|
|
peer.sendall(b'{"protocol":1,"verb":"identify","id":1}\n')
|
|
data = bytearray()
|
|
while b'\n' not in data and len(data) < 524288:
|
|
chunk = peer.recv(65536)
|
|
if not chunk:
|
|
break
|
|
data.extend(chunk)
|
|
response = json.loads(data.split(b'\n', 1)[0])
|
|
if response.get('ok') is not True or response.get('id') != 1:
|
|
raise ValueError('control request rejected')
|
|
result = response['result']
|
|
# Never retain credentials or arbitrary server payloads in the receipt.
|
|
return {key: result.get(key) for key in (
|
|
'state', 'runtime_protocol', 'authority_epoch', 'api_origin', 'capabilities')}
|
|
|
|
|
|
def main():
|
|
parser = argparse.ArgumentParser(description=__doc__)
|
|
parser.add_argument('--repo', type=Path, required=True)
|
|
parser.add_argument('--python', type=Path, required=True)
|
|
parser.add_argument('--output', type=Path, required=True)
|
|
parser.add_argument('--deadline', type=float, default=30)
|
|
args = parser.parse_args()
|
|
if os.name != 'posix':
|
|
parser.error('this probe requires native POSIX; Windows needs its named-pipe probe')
|
|
if args.deadline <= 0:
|
|
parser.error('--deadline must be positive')
|
|
repo = args.repo.resolve()
|
|
args.output.parent.mkdir(parents=True, exist_ok=True)
|
|
receipt = {'head': subprocess.check_output(
|
|
['git', 'rev-parse', 'HEAD'], cwd=repo, stdin=subprocess.DEVNULL, text=True, timeout=30).strip(),
|
|
'surface': 'gateway.run control descriptor', 'passed': False, 'observations': []}
|
|
with tempfile.TemporaryDirectory(prefix='ugw-boot-') as directory:
|
|
root = Path(directory)
|
|
home, state = root / 'home', root / 'state'
|
|
home.mkdir(mode=0o700)
|
|
state.mkdir(mode=0o700)
|
|
(state / 'config.yaml').write_text(
|
|
'gateway:\n multiplex_profiles: false\nauxiliary:\n title_generation:\n enabled: false\n',
|
|
encoding='utf-8')
|
|
env = {key: os.environ[key] for key in ('PATH', 'LANG', 'TZ') if key in os.environ}
|
|
env.update(HOME=str(home), USERPROFILE=str(home), HERMES_HOME=str(state),
|
|
PYTHONPATH=str(repo), PYTHONUNBUFFERED='1')
|
|
with args.output.with_suffix('.log').open('w', encoding='utf-8') as log:
|
|
process = subprocess.Popen(
|
|
[str(args.python.absolute()), '-m', 'gateway.run'], cwd=repo, env=env,
|
|
stdin=subprocess.DEVNULL, stdout=log, stderr=subprocess.STDOUT,
|
|
start_new_session=True)
|
|
try:
|
|
deadline = time.monotonic() + args.deadline
|
|
while time.monotonic() < deadline and process.poll() is None:
|
|
try:
|
|
snapshot = identify(state)
|
|
if not receipt['observations'] or receipt['observations'][-1] != snapshot:
|
|
receipt['observations'].append(snapshot)
|
|
if (snapshot['state'] == 'ready' and snapshot['runtime_protocol'] == 1
|
|
and snapshot['api_origin'] and snapshot['authority_epoch']):
|
|
receipt['passed'] = True
|
|
break
|
|
except (OSError, ValueError) as error:
|
|
receipt['last_probe_error'] = type(error).__name__
|
|
time.sleep(0.25)
|
|
receipt['alive_at_end'] = process.poll() is None
|
|
finally:
|
|
if process.poll() is None:
|
|
os.killpg(process.pid, signal.SIGTERM) # windows-footgun: ok — POSIX-only owned process
|
|
try:
|
|
process.wait(timeout=15)
|
|
except subprocess.TimeoutExpired:
|
|
os.killpg(process.pid, signal.SIGKILL) # windows-footgun: ok — POSIX-only owned process
|
|
process.wait(timeout=5)
|
|
receipt['forced_cleanup'] = True
|
|
receipt['exit_code'] = process.returncode
|
|
args.output.write_text(json.dumps(receipt, indent=2) + '\n', encoding='utf-8')
|
|
print(json.dumps(receipt, indent=2))
|
|
return 0 if receipt['passed'] else 1
|
|
|
|
|
|
if __name__ == '__main__':
|
|
raise SystemExit(main())
|