Files
kshitijk4poor 4982ecd8a7 refactor(fallback): one resolver-kwargs helper and one credential predicate
Four resolution-time fallback walkers (runtime_provider.resolve_runtime_with_fallback,
cron, the TUI agent factory, the CLI startup fallback) each built the same
resolve_runtime_provider kwargs from an entry by hand: provider pin, model, base_url and
resolve_entry_api_key. They now call fallback_config.fallback_entry_runtime_kwargs.
Session readiness's inline "does this runtime carry a usable credential" test becomes
runtime_readiness.runtime_has_credentials.

No behaviour change: resolve_requested_provider lowercases the pin, so the two walkers
that lowercased it first and the two that did not send the same request. Both helpers
exist so `hermes fallback check` (next commit) judges an entry with the switch's own
resolution instead of a sixth copy.
2026-11-10 13:36:29 +05:30

107 lines
5.7 KiB
Python

"""Provider readiness probe for the session authority's ``setup.runtime_check``.
Answers with the legacy ``tui_gateway/methods_config.py`` handler's payload so a client reads one
contract whichever backend it reached: ``ok``/``provider``/``model``/``source``, ``error`` on
failure (naming the configured pin, never the fallback chain's tail), ``free_tier_route`` on success.
"""
import logging
logger = logging.getLogger(__name__)
def missing_credentials_suffix(provider) -> str:
"""``" <hint>"`` from *provider*'s profile (``ProviderProfile.missing_credentials_hint``) for a
"No usable credentials found" message, else ``""``. Plugin boundary: a raising hook (or a plugin
host that is down) or a non-string answer yields ``""`` and is logged once per provider, so the
AuthError it decorates (and the fallback chain walking on it) is never replaced."""
from providers import get_provider_profile
name = str(provider or "").strip().lower()
profile = get_provider_profile(name) if name else None
if profile is None:
return ""
try:
hint = profile.missing_credentials_hint()
except Exception: # health: allow BLE001 -- plugin hook boundary; logged with traceback once below
if name not in _HINT_FAILURES_LOGGED:
_HINT_FAILURES_LOGGED.add(name)
logger.warning("%s missing_credentials_hint failed; showing the error without it", name, exc_info=True)
return ""
return f" {hint.strip()}" if isinstance(hint, str) and hint.strip() else ""
_HINT_FAILURES_LOGGED: set[str] = set()
def readiness_failure(exc) -> dict:
"""``setup.runtime_check``'s answer when resolving the runtime raised *exc*.
``error_code`` rides along only for a failure provider setup cannot repair, so a client keeps
the app open with the error instead of sending the user back through provider sign-in.
"""
from hermes_cli.runtime_provider_custom import LocalRuntimeUnavailableError
code = {'error_code': exc.error_code} if isinstance(exc, LocalRuntimeUnavailableError) else {}
return {'ok': False, 'error': str(exc), **code}
def runtime_has_credentials(runtime) -> bool:
"""Whether a resolved runtime carries a credential a request can use: a usable secret, a key
callable, an SDK/keyless placeholder (``aws-sdk``, ``no-key-required``) or an external-process
``command``. The one predicate session readiness and ``hermes fallback check`` share."""
from hermes_cli.auth import has_usable_secret
api_key = runtime.get('api_key')
if callable(api_key) or runtime.get('command'):
return True
text = str(api_key or '').strip()
return text in {'aws-sdk', 'no-key-required'} or has_usable_secret(text)
def check_runtime_readiness(requested=None, *, strict_profile_scope=False, resolve=None):
"""ok/error verdict for the runtime a session would be built with.
Without ``requested`` the probe runs the SAME resolver as session creation (the configured
model + provider pin, then the configured fallback chain) — a probe that ignores the chain
shows onboarding for a backend whose sessions build fine (#111775). ``resolve`` replaces that
resolver with the caller's own ``() -> (model, runtime)``. An explicit ``requested`` provider
stays a strict single-provider check so onboarding can verify the provider just connected
without another provider's fallback masking a failed connection. Both branches report the model.
"""
from hermes_cli.config import load_config
from hermes_cli.main import _has_any_provider_configured
from hermes_cli.runtime_provider import resolve_runtime_provider, resolve_runtime_with_fallback
config = load_config()
cfg_model = config.get('model')
if isinstance(cfg_model, dict):
configured_model = str(cfg_model.get('default') or cfg_model.get('model') or '') or None
else:
configured_model = cfg_model if isinstance(cfg_model, str) and cfg_model else None
if resolve is not None:
model, runtime = resolve()
elif requested:
model = configured_model
runtime = resolve_runtime_provider(requested=requested, target_model=configured_model)
else:
runtime, entry = resolve_runtime_with_fallback(config, target_model=configured_model)
model = (entry or {}).get('model') or configured_model or runtime.get('model')
configured = bool(_has_any_provider_configured(strict_profile_scope=strict_profile_scope))
provider = runtime.get('provider') or 'provider'
source = str(runtime.get('source') or '')
# When the chain only resolves at its tail the runtime stops there; a failure must name the
# provider the user pinned, not a tail they never chose (#124939). Auto mode names the route.
pinned = requested or (str(cfg_model.get('provider') or '').strip() if isinstance(cfg_model, dict) else '')
blamed = pinned or provider
def fail(error, src):
return {'ok': False, 'provider': blamed, 'model': model, 'source': src, 'error': error}
if not configured and provider == 'bedrock' and source in {'iam-role', 'aws-sdk-default-chain'}:
return fail('No Hermes provider is configured.', source)
if not runtime_has_credentials(runtime):
return fail(f'No usable credentials found for {blamed}.{missing_credentials_suffix(blamed)}', runtime.get('source'))
from hermes_cli.anon_auth import route_is_welcome_host
# free_tier_route is keyed on the SELECTED route (the welcome host serves only nous/welcome), not
# on profile state: a paid Nous key beside a free-tier identity must not read as free.
return {'ok': True, 'provider': runtime.get('provider'), 'model': model, 'source': runtime.get('source'),
'free_tier_route': provider == 'nous' and route_is_welcome_host(runtime.get('base_url'))}