mirrors/open-webui
1
0
Fork 0
mirror of https://github.com/open-webui/open-webui.git synced 2026-11-15 18:55:07 +03:00
Code Issues Packages Projects Releases Wiki Activity
20,711 Commits 2 Branches 181 Tags
dev
Commit Graph

38 Commits

  • refac
    Timothy Jaeryang Baek · 2026-11-02 08:48:51 +09:00
    d99ec1c02c
  • refac
    Timothy Jaeryang Baek · 2026-10-09 18:37:55 +04:00
    e6476928ee
  • fix: prevent startup crash when function/tool has null user_id (#26850) 
    The Function and Tool database columns declare user_id as a nullable
String column, but their Pydantic read-models required a non-null
string. A record with user_id NULL therefore raised a
pydantic ValidationError inside get_functions()/get_tools(), which run
during install_tool_and_function_dependencies() at app startup —
crashing the whole application and blocking all chat completions.

Make user_id Optional in the read/response models so such records
validate gracefully (user is already rendered as None downstream when
the id has no matching user) instead of taking down startup.


Claude-Session: https://claude.ai/code/session_01Y4RRUNq7ZUFkRWbWPkDw3m

Co-authored-by: Claude <noreply@anthropic.com>
    Classic298 · 2026-07-24 00:00:37 -05:00
    48f78ca58d
  • perf: drop redundant session.refresh calls after commit across the model layer (#27381) 
    Both session factories run with expire_on_commit=False, so ORM objects keep their attribute values after commit. Every session.refresh issued right after a commit therefore re-SELECTed a row whose values the session already held, including full chat JSON blobs and user settings, purely to overwrite identical data. Fifty such calls existed across the model layer, covering nearly every write path in the app (chat inserts, title updates, pin/archive toggles, user role and settings updates, tool, prompt, function, model, file, tag, feedback, memory, automation and grant writes).

All fifty are removed. The only refreshes with an actual job were the two update-then-reload paths in tools and skills, where a Core UPDATE statement bypasses the identity map; those now use session.get(..., populate_existing=True), which guarantees a fresh row in one SELECT whether or not the row was already present in the session (the previous code issued get plus refresh, two SELECTs, on the default configuration).

Benchmark (real SQLite DB, per write):

| write path | before | after |
| --- | --- | --- |
| chat title update, ~600 KB chat blob | 2.08 ms | 1.24 ms |
| user role update, small row | 1.21 ms | 0.68 ms |

On Postgres each removed refresh is additionally a network round trip. The chat-blob case also skips re-parsing the entire JSON document per write.

Functionally verified against a fresh database: user insert, role and settings updates, chat insert (including the server-default meta column, which is always provided client-side), title update and pin toggle, tool insert and the Core-update reload path, tag insert and the prompt insert flow that pins version_id after history creation all return correct values and persist correctly.
    Classic298 · 2026-07-23 18:08:00 -05:00
    699d512e2f
  • perf: cut repeated per-model work out of model list assembly 
    get_all_models runs on every models refresh and, without the base-models cache (off by default), on every /api/models request. Several of its costs multiplied by the model count for no reason:

- The active action and filter id sets were derived from get_functions_by_type, which loads full function rows including plugin source and validates them, only for the ids and is_global flags. A generalized column-only query now returns (id, is_global) tuples; the existing filter-specific helper delegates to it.
- Action priorities were computed inside the per-model sort key, constructing a pydantic Valves object per action per model; with global actions in every model's list that was models x actions constructions per refresh. Priorities are now memoized per action.
- Global action and filter item dicts were rebuilt per model from the same modules. The item lists are now built once per function and shallow-copied per model, keeping per-model dicts independent exactly as before (nested values were already shared).
- Deactivated base-model overrides were dropped with models.remove, a linear scan and shift per removal; removals are now collected and filtered out in one identity-based pass, preserving list.remove's exact object semantics.
- RedisDict.set fingerprinted the payload by serializing the already-serialized mapping a second time plus a sha256; a direct dict comparison against the last written mapping has the same skip semantics without re-serializing anything.
- /api/models did tag normalization and profile-image stripping for every model before access filtering discarded the invisible ones, and always evaluated a json.dumps debug f-string; the work now runs only on visible models and the debug line is gated on the log level. The duplicate-id dedup keeps its position before filtering so the effective-model semantics are unchanged.

Benchmark:

| metric | before | after |
| --- | --- | --- |
| model-cache fingerprint, 200 models | 45 us | 1.4 us |
| action priority Valves builds, 200 models x 4 global actions | 0.37 ms (800 builds) | 0.002 ms (4 builds) |
| function-table payload for id sets | full rows incl. source | (id, is_global) tuples |

Functionally verified: the column-only id query matches the full-row query for actions and filters including inactive exclusion, and the fingerprint skip logic writes on first set, skips identical payloads, updates plus deletes stale keys on change and clears on empty, against a scripted fake Redis.
    Classic298 · 2026-07-23 19:05:32 -04:00
    6b655689cc
  • chore: format
    Timothy Jaeryang Baek · 2026-07-23 13:41:16 -04:00
    ca11bd90a7
  • refac
    Timothy Jaeryang Baek · 2026-07-23 12:48:14 -04:00
    f9107edeeb
  • refac
    Timothy Jaeryang Baek · 2026-06-29 13:03:14 -05:00
    517cd8d102
  • refac
    Timothy Jaeryang Baek · 2026-06-29 12:29:10 -05:00
    b4073f6378
  • chore: format
    Timothy Jaeryang Baek · 2026-06-01 13:56:55 -07:00
    6fce92aa12
  • refac
    Timothy Jaeryang Baek · 2026-05-21 15:29:49 +04:00
    d8b5b9fa79
  • refac
    Timothy Jaeryang Baek · 2026-05-21 14:01:57 +04:00
    260ead64da
  • refac: modernize type annotations (PEP 604 / PEP 585)
    Timothy Jaeryang Baek · 2026-05-12 17:10:15 +09:00
    6d0295588e
  • chore: format
    Timothy Jaeryang Baek · 2026-04-12 18:12:59 -05:00
    25898116ea
  • refac: async db
    Timothy Jaeryang Baek · 2026-04-12 14:22:11 -05:00
    27169124f2
  • chore: format
    Timothy Jaeryang Baek · 2026-03-24 06:07:20 -05:00
    f7e07f3ca1
  • refac
    Timothy Jaeryang Baek · 2026-03-24 04:49:48 -05:00
    ade617efa8
  • fix: add from_attributes to FunctionResponse (#22924)
    Algorithm5838 · 2026-03-21 19:38:41 -05:00
    52e227f425
  • refac
    Timothy Jaeryang Baek · 2026-03-21 18:21:25 -05:00
    93407ba316
  • refac
    Timothy Jaeryang Baek · 2026-03-17 17:58:01 -05:00
    de3317e26b
  • refac
    Timothy Jaeryang Baek · 2026-03-06 20:12:37 -06:00
    6d9996e599
  • perf(models): batch-fetch function valves to eliminate N+1 queries (#22301) 
    * perf(models): batch-fetch function valves to eliminate N+1 queries

get_action_priority() called Functions.get_function_valves_by_id()
individually for every action on every model — an N+1 query pattern
that issued one DB round-trip per (action x model) pair.

Add Functions.get_function_valves_by_ids() that fetches all valves in
a single WHERE IN query, then look up each action's valves from the
pre-fetched dict inside get_action_priority().

No functional change — same priority resolution, same sort order.

* Update models.py

* Update models.py
    Classic298 · 2026-03-06 15:56:01 -06:00
    d93cb3658d
  • chore: format
    Timothy Jaeryang Baek · 2026-02-11 16:24:11 -06:00
    f376d4f378
  • perf: batch fetch filter functions to eliminate N+1 queries (#21018)
    Classic298 · 2026-01-30 00:50:04 +04:00
    aac98120c8
  • perf: optimize database queries in functions, feedbacks, and groups (#21019)
    Classic298 · 2026-01-29 21:44:50 +04:00
    68e257849d
  • chore: format
    Timothy Jaeryang Baek · 2026-01-08 01:55:56 +04:00
    700349064d
  • refac/enh: db session sharing
    Timothy Jaeryang Baek · 2025-12-28 22:00:44 +04:00
    2041ab483e
  • chore/perf: Remove old SRC level log env vars with no impact (#20045) 
    * Update openai.py

* Update env.py

* Merge pull request open-webui#19030 from open-webui/dev (#119)

Co-authored-by: Tim Baek <tim@openwebui.com>
Co-authored-by: Claude <noreply@anthropic.com>

---------

Co-authored-by: Tim Baek <tim@openwebui.com>
Co-authored-by: Claude <noreply@anthropic.com>
    Classic298 · 2025-12-20 08:16:14 -05:00
    823b9a6dd9
  • refac/fix: chat search null byte filter
    Timothy Jaeryang Baek · 2025-11-22 20:34:49 -05:00
    4af7cc818e
  • refac: functions
    Timothy Jaeryang Baek · 2025-10-07 14:20:07 -05:00
    f5e1a42f51
  • refac/enh: model default filter/feature
    Timothy Jaeryang Baek · 2025-09-13 01:23:27 +04:00
    9a55547827
  • refac/enh: ability to export/sync function valves
    Timothy Jaeryang Baek · 2025-09-09 17:48:41 +04:00
    d0f338bb99
  • refac
    Timothy Jaeryang Baek · 2025-08-21 22:02:11 +04:00
    9fb2c9c86d
  • refac/enh: add performance indexes 
    Co-Authored-By: decent-engineer-decent-datascientist <77806775+decent-engineer-decent-datascientist@users.noreply.github.com>
    Timothy Jaeryang Baek · 2025-08-19 03:24:10 +04:00
    b3a95f40fc
  • feat: /sync functions endpoint
    Timothy Jaeryang Baek · 2025-05-24 23:39:19 +04:00
    31e2686ae6
  • chore: format 
    HIDE MODELS
    Timothy Jaeryang Baek · 2025-02-26 22:18:18 -08:00
    ddb30589e3
  • refactor: replace print statements with logging for better error tracking
    Yifang Deng · 2025-02-25 15:53:55 +01:00
    0e5d5ecb81
  • wip
    Timothy Jaeryang Baek · 2024-12-10 00:54:13 -08:00
    d3d161f723