From 02550b36c7609ef652777aa6005d6b3443b9e23f Mon Sep 17 00:00:00 2001 From: Kit Langton Date: Thu, 27 Aug 2026 19:39:18 -0400 Subject: [PATCH] refactor(util): narrow layer visitor options (#45734) --- packages/util/src/effect/layer-node.ts | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/packages/util/src/effect/layer-node.ts b/packages/util/src/effect/layer-node.ts index 57234c436ac..325777ab737 100644 --- a/packages/util/src/effect/layer-node.ts +++ b/packages/util/src/effect/layer-node.ts @@ -164,7 +164,6 @@ function isNode(input: Layer.Any | AnyNode): input is AnyNode { type Visit = (node: AnyNode, context: VisitContext) => Result type VisitContext = { - readonly cache: Map readonly visit: (node: AnyNode) => Result } @@ -174,7 +173,6 @@ function walk( options: { readonly cache?: Map readonly resolve?: (node: AnyNode) => AnyNode - readonly detectCycles?: boolean } = {}, ) { const cache = options.cache ?? new Map() @@ -186,7 +184,7 @@ function walk( const cached = cache.get(target) if (cached !== undefined || cache.has(target)) return cached! - if (options.detectCycles !== false && visiting.has(target)) { + if (visiting.has(target)) { const start = stack.indexOf(target) throw new Error( `Cycle detected in layer tree: ${[...stack.slice(start), target].map((item) => item.name).join(" -> ")}`, @@ -196,7 +194,7 @@ function walk( visiting.add(target) stack.push(target) try { - const result = visit(target, { cache, visit: recur }) + const result = visit(target, { visit: recur }) if (!cache.has(target)) cache.set(target, result) return result } finally {