From 03d185b6977dfebe457bb970e8d06fe23810eb0f Mon Sep 17 00:00:00 2001 From: Dax Raad Date: Mon, 19 Oct 2026 11:02:44 -0400 Subject: [PATCH] fix(app): register session search once The titlebar session search reused the session.search id of the in-session find command, so one of them was dropped as a duplicate and in-session Ctrl+F could stop working. Give the titlebar command its own sessions.search id. --- packages/app/src/shell/titlebar/titlebar.tsx | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/app/src/shell/titlebar/titlebar.tsx b/packages/app/src/shell/titlebar/titlebar.tsx index 601b21dfdba..c34d89014c8 100644 --- a/packages/app/src/shell/titlebar/titlebar.tsx +++ b/packages/app/src/shell/titlebar/titlebar.tsx @@ -459,7 +459,7 @@ export function Titlebar(props: { verticalTabs?: { mount?: HTMLElement } }) { value={ <> {language.t("command.session.search")} - + } class="shrink-0" @@ -470,7 +470,7 @@ export function Titlebar(props: { verticalTabs?: { mount?: HTMLElement } }) { size="large" class="!w-9 shrink-0" icon={} - onClick={() => command.trigger("session.search")} + onClick={() => command.trigger("sessions.search")} aria-label={language.t("command.session.search")} /> @@ -481,7 +481,7 @@ export function Titlebar(props: { verticalTabs?: { mount?: HTMLElement } }) { data-titlebar-tab-action data-action="vertical-tabs-search" class="group flex h-7 w-full shrink-0 items-center gap-1.5 rounded-[6px] ps-1.5 pe-2 text-[13px] leading-4 text-v2-text-text-faint hover:text-v2-text-text-base" - onClick={() => command.trigger("session.search")} + onClick={() => command.trigger("sessions.search")} > {language.t("command.session.search")} @@ -489,7 +489,7 @@ export function Titlebar(props: { verticalTabs?: { mount?: HTMLElement } }) { class="ms-auto hidden min-w-0 truncate text-v2-text-text-faint group-hover:block group-focus-visible:block" aria-hidden="true" > - {command.keybind("session.search")} + {command.keybind("sessions.search")} @@ -508,7 +508,7 @@ export function Titlebar(props: { verticalTabs?: { mount?: HTMLElement } }) { }, }, { - id: "session.search", + id: "sessions.search", title: language.t("command.session.search"), category: language.t("command.category.session"), onSelect: async () => {