From 1ae2cf3567498b5c4c963469adffe384e21944fe Mon Sep 17 00:00:00 2001 From: usrnk1 <7547651+usrnk1@users.noreply.github.com> Date: Thu, 3 Sep 2026 23:55:27 +0200 Subject: [PATCH] feat(desktop): polish menus, file tabs, and empty states (#47095) Co-authored-by: iamdavidhill <1879069+iamdavidhill@users.noreply.github.com> --- .../app/e2e/regression/review-open-file.spec.ts | 10 ++++++++++ packages/app/src/composer/editor/editor.tsx | 2 +- .../session/files/session-file-browser-tab.tsx | 8 ++++---- .../src/session/files/session-side-panel.tsx | 2 +- .../src/v2/components/session-review-v2.css | 9 +++++---- packages/ui/src/navigation/menu/menu.css | 1 + packages/ui/src/navigation/tabs/tabs.css | 17 ++++++++++++++--- 7 files changed, 36 insertions(+), 13 deletions(-) diff --git a/packages/app/e2e/regression/review-open-file.spec.ts b/packages/app/e2e/regression/review-open-file.spec.ts index 5cf6ced6947..ce42660e814 100644 --- a/packages/app/e2e/regression/review-open-file.spec.ts +++ b/packages/app/e2e/regression/review-open-file.spec.ts @@ -92,10 +92,16 @@ test("opens and searches project files inline", async ({ page }) => { const contextButton = page.getByRole("button", { name: "View context usage" }) await contextButton.click() await expect(panel.getByRole("tab", { name: "Context", selected: true })).toBeVisible() + await expect(panel.getByRole("button", { name: "Open file" }).locator("use")).toHaveAttribute( + "href", + "#opencode-v2-icon-plus", + ) await panel.getByRole("button", { name: "Open file" }).click() const openFileTab = panel.getByRole("tab", { name: "Open file" }) const openFileTabClose = openFileTab.locator("..").getByRole("button", { name: "Close tab" }) await expect(openFileTab).toHaveAttribute("data-selected", "") + await expect(openFileTab.locator("..")).toHaveCSS("padding-inline-end", "4px") + await expect(openFileTab.locator("..")).toHaveCSS("gap", "8px") await expect(openFileTab.locator("use")).toHaveAttribute("href", "#opencode-v2-icon-file-tree") await expect(openFileTab.getByText("Open file", { exact: true }).locator("..")).not.toHaveClass(/italic/) await expect(openFileTabClose).toHaveAttribute("data-variant", "ghost-muted") @@ -114,6 +120,8 @@ test("opens and searches project files inline", async ({ page }) => { await panel.getByRole("button", { name: "README.md" }).click() await expect(panel.getByRole("tab", { name: "README.md", selected: true })).toBeVisible() + await expect(panel.getByRole("tab", { name: "README.md" }).locator("..")).toHaveCSS("padding-inline-end", "4px") + await expect(panel.getByRole("tab", { name: "README.md" }).locator("..")).toHaveCSS("gap", "8px") await expect(sidebarToggle).toBeEnabled() await expect(panel.getByText("contents:README.md", { exact: true })).toBeVisible() await expect(sidebar).toHaveCount(0) @@ -129,6 +137,8 @@ test("opens and searches project files inline", async ({ page }) => { await expect(filter).toHaveAttribute("aria-activedescendant", resultID!) await filter.press("Enter") await expect(panel.getByRole("tab", { name: "nested.ts", selected: true })).toBeVisible() + await expect(panel.getByRole("tab", { name: "nested.ts" }).locator("..")).toHaveCSS("padding-inline-end", "4px") + await expect(panel.getByRole("tab", { name: "nested.ts" }).locator("..")).toHaveCSS("gap", "8px") await expect(sidebarToggle).toBeEnabled() await expect(panel.getByText("contents:src/nested.ts", { exact: true })).toBeVisible() expect(searches).toContainEqual({ query: "nested", dirs: "file", limit: 200 }) diff --git a/packages/app/src/composer/editor/editor.tsx b/packages/app/src/composer/editor/editor.tsx index 4ad13baf510..0ce34ee36a7 100644 --- a/packages/app/src/composer/editor/editor.tsx +++ b/packages/app/src/composer/editor/editor.tsx @@ -575,7 +575,7 @@ export function ComposerEditorAddMenu(props: { /> diff --git a/packages/app/src/session/files/session-file-browser-tab.tsx b/packages/app/src/session/files/session-file-browser-tab.tsx index 5d1b5e02400..e271f0832d3 100644 --- a/packages/app/src/session/files/session-file-browser-tab.tsx +++ b/packages/app/src/session/files/session-file-browser-tab.tsx @@ -170,10 +170,10 @@ export function SessionFileBrowserTab(props: { when={!props.placeholder} fallback={ -
- -
{language.t("command.file.open")}
-
{language.t("session.files.selectToOpen")}
+
+ +
{language.t("command.file.open")}
+
{language.t("session.files.selectToOpen")}
} diff --git a/packages/app/src/session/files/session-side-panel.tsx b/packages/app/src/session/files/session-side-panel.tsx index 3b63c0765a9..b0f577c2576 100644 --- a/packages/app/src/session/files/session-side-panel.tsx +++ b/packages/app/src/session/files/session-side-panel.tsx @@ -417,7 +417,7 @@ export function SessionSidePanel(props: { class="flex items-center" > } + icon={} variant="ghost-muted" size="large" onClick={() => openFileBrowser()} diff --git a/packages/session-ui/src/v2/components/session-review-v2.css b/packages/session-ui/src/v2/components/session-review-v2.css index 231daeee97e..c01dd61a516 100644 --- a/packages/session-ui/src/v2/components/session-review-v2.css +++ b/packages/session-ui/src/v2/components/session-review-v2.css @@ -494,7 +494,7 @@ flex-direction: column; align-items: center; justify-content: center; - gap: 16px; + gap: 8px; padding: 24px; padding-bottom: 160px; text-align: center; @@ -502,25 +502,26 @@ [data-slot="session-review-v2-empty-changes"] [data-slot="icon-svg"] { flex: none; + margin-bottom: 8px; color: var(--v2-icon-icon-muted); } [data-slot="session-review-v2-empty-changes-title"] { flex: none; - margin-top: 4px; font-size: 13px; font-weight: 530; - line-height: var(--line-height-compact); + line-height: 13px; letter-spacing: -0.04px; color: var(--v2-text-text-base); } [data-slot="session-review-v2-empty-changes-description"] { flex: none; + height: 20px; max-width: 282px; font-size: 13px; font-weight: 440; - line-height: 20px; + line-height: var(--line-height-base); text-align: center; letter-spacing: -0.04px; color: var(--v2-text-text-muted); diff --git a/packages/ui/src/navigation/menu/menu.css b/packages/ui/src/navigation/menu/menu.css index 253444667e8..ccae2b64c38 100644 --- a/packages/ui/src/navigation/menu/menu.css +++ b/packages/ui/src/navigation/menu/menu.css @@ -57,6 +57,7 @@ gap: 8px; height: 28px; padding: 0 12px; + padding-inline-end: 6px; background: transparent; border-radius: 4px; outline: none; diff --git a/packages/ui/src/navigation/tabs/tabs.css b/packages/ui/src/navigation/tabs/tabs.css index 3ba36add1d8..3d085695b7c 100644 --- a/packages/ui/src/navigation/tabs/tabs.css +++ b/packages/ui/src/navigation/tabs/tabs.css @@ -552,6 +552,17 @@ } } + &[data-value="open-file"], + &[data-value^="file://"] + { + gap: 8px; + padding-inline-end: 4px; + + [data-slot="tabs-trigger-close-button"] { + margin-inline-start: 0; + } + } + &:has([data-selected]) { background-color: var(--v2-background-bg-layer-02); box-shadow: none; @@ -569,19 +580,19 @@ font-variation-settings: "slnt" 0; font-variant-numeric: tabular-nums; - &[data-selected] { + &[data-selected]:not([data-value="open-file"]) { color: var(--v2-text-text-base); } .tab-fileicon-color, - .tab-fileicon-mono, - [data-slot="icon-svg"] { + .tab-fileicon-mono { margin-inline-start: -2px; } .italic { font-style: italic !important; font-variation-settings: "slnt" -10 !important; + padding-inline-end: 2px; } } }