From 1ae2cf3567498b5c4c963469adffe384e21944fe Mon Sep 17 00:00:00 2001 From: usrnk1 <7547651+usrnk1@users.noreply.github.com> Date: Thu, 3 Sep 2026 23:55:27 +0200 Subject: [PATCH] feat(desktop): polish menus, file tabs, and empty states (#47095) Co-authored-by: iamdavidhill <1879069+iamdavidhill@users.noreply.github.com> --- .../app/e2e/regression/review-open-file.spec.ts | 10 ++++++++++ packages/app/src/composer/editor/editor.tsx | 2 +- .../session/files/session-file-browser-tab.tsx | 8 ++++---- .../src/session/files/session-side-panel.tsx | 2 +- .../src/v2/components/session-review-v2.css | 9 +++++---- packages/ui/src/navigation/menu/menu.css | 1 + packages/ui/src/navigation/tabs/tabs.css | 17 ++++++++++++++--- 7 files changed, 36 insertions(+), 13 deletions(-) diff --git a/packages/app/e2e/regression/review-open-file.spec.ts b/packages/app/e2e/regression/review-open-file.spec.ts index 5cf6ced6947..ce42660e814 100644 --- a/packages/app/e2e/regression/review-open-file.spec.ts +++ b/packages/app/e2e/regression/review-open-file.spec.ts @@ -92,10 +92,16 @@ test("opens and searches project files inline", async ({ page }) => { const contextButton = page.getByRole("button", { name: "View context usage" }) await contextButton.click() await expect(panel.getByRole("tab", { name: "Context", selected: true })).toBeVisible() + await expect(panel.getByRole("button", { name: "Open file" }).locator("use")).toHaveAttribute( + "href", + "#opencode-v2-icon-plus", + ) await panel.getByRole("button", { name: "Open file" }).click() const openFileTab = panel.getByRole("tab", { name: "Open file" }) const openFileTabClose = openFileTab.locator("..").getByRole("button", { name: "Close tab" }) await expect(openFileTab).toHaveAttribute("data-selected", "") + await expect(openFileTab.locator("..")).toHaveCSS("padding-inline-end", "4px") + await expect(openFileTab.locator("..")).toHaveCSS("gap", "8px") await expect(openFileTab.locator("use")).toHaveAttribute("href", "#opencode-v2-icon-file-tree") await expect(openFileTab.getByText("Open file", { exact: true }).locator("..")).not.toHaveClass(/italic/) await expect(openFileTabClose).toHaveAttribute("data-variant", "ghost-muted") @@ -114,6 +120,8 @@ test("opens and searches project files inline", async ({ page }) => { await panel.getByRole("button", { name: "README.md" }).click() await expect(panel.getByRole("tab", { name: "README.md", selected: true })).toBeVisible() + await expect(panel.getByRole("tab", { name: "README.md" }).locator("..")).toHaveCSS("padding-inline-end", "4px") + await expect(panel.getByRole("tab", { name: "README.md" }).locator("..")).toHaveCSS("gap", "8px") await expect(sidebarToggle).toBeEnabled() await expect(panel.getByText("contents:README.md", { exact: true })).toBeVisible() await expect(sidebar).toHaveCount(0) @@ -129,6 +137,8 @@ test("opens and searches project files inline", async ({ page }) => { await expect(filter).toHaveAttribute("aria-activedescendant", resultID!) await filter.press("Enter") await expect(panel.getByRole("tab", { name: "nested.ts", selected: true })).toBeVisible() + await expect(panel.getByRole("tab", { name: "nested.ts" }).locator("..")).toHaveCSS("padding-inline-end", "4px") + await expect(panel.getByRole("tab", { name: "nested.ts" }).locator("..")).toHaveCSS("gap", "8px") await expect(sidebarToggle).toBeEnabled() await expect(panel.getByText("contents:src/nested.ts", { exact: true })).toBeVisible() expect(searches).toContainEqual({ query: "nested", dirs: "file", limit: 200 }) diff --git a/packages/app/src/composer/editor/editor.tsx b/packages/app/src/composer/editor/editor.tsx index 4ad13baf510..0ce34ee36a7 100644 --- a/packages/app/src/composer/editor/editor.tsx +++ b/packages/app/src/composer/editor/editor.tsx @@ -575,7 +575,7 @@ export function ComposerEditorAddMenu(props: { />