diff --git a/packages/app/component-tests/focus-ring.spec.ts b/packages/app/component-tests/focus-ring.spec.ts
index 3030dfad94e..bf2356ee8af 100644
--- a/packages/app/component-tests/focus-ring.spec.ts
+++ b/packages/app/component-tests/focus-ring.spec.ts
@@ -66,3 +66,14 @@ story("keeps queue rings inside controls under the list fade", async ({ mount, p
await expect(remove).toHaveCSS("outline-style", "solid")
await expect(remove).toHaveCSS("outline-offset", "-2px")
})
+
+story("leaves no ring on the review toggle after a pointer click", async ({ mount, page }) => {
+ await mount("app-session-header-actions--review-toggle")
+ const toggle = page.getByRole("button", { name: "Toggle review" })
+
+ await toggle.click()
+ // A later key press makes Chromium ring whatever still holds focus, so the click must not leave it there.
+ await page.keyboard.press("Shift")
+ expect(await toggle.evaluate((element) => element.matches(":focus-visible"))).toBe(false)
+ await expect(toggle).toHaveCSS("outline-style", "none")
+})
diff --git a/packages/app/src/session/header/session-header-actions.stories.tsx b/packages/app/src/session/header/session-header-actions.stories.tsx
new file mode 100644
index 00000000000..a436090425c
--- /dev/null
+++ b/packages/app/src/session/header/session-header-actions.stories.tsx
@@ -0,0 +1,28 @@
+import { createSignal } from "solid-js"
+import { SessionHeaderActions } from "./session-header-actions"
+
+export default {
+ title: "App/Session/Header actions",
+ id: "app-session-header-actions",
+ component: SessionHeaderActions,
+}
+
+export const ReviewToggle = {
+ render: () => {
+ const [opened, setOpened] = createSignal(false)
+
+ return (
+
+ setOpened(!opened()),
+ }}
+ />
+
+ )
+ },
+}
diff --git a/packages/app/src/session/header/session-header-actions.tsx b/packages/app/src/session/header/session-header-actions.tsx
index 6b786859d43..84dd3d97d01 100644
--- a/packages/app/src/session/header/session-header-actions.tsx
+++ b/packages/app/src/session/header/session-header-actions.tsx
@@ -59,12 +59,12 @@ export function SessionHeaderActions(props: { state: SessionHeaderActionsState }
"--v2-overlay-simple-overlay-hover": "var(--v2-background-bg-layer-01)",
"--v2-overlay-simple-overlay-pressed": "var(--v2-background-bg-layer-02)",
}}
- state={props.state.reviewOpened ? "pressed" : undefined}
+ onMouseDown={(event) => event.preventDefault()}
onClick={props.state.onReviewToggle}
aria-label={props.state.reviewLabel}
aria-expanded={props.state.reviewOpened}
aria-controls="review-panel"
- icon={}
+ icon={}
/>
diff --git a/packages/app/src/session/session-identity-header.tsx b/packages/app/src/session/session-identity-header.tsx
index b4be1cf1953..acf24ef3c1e 100644
--- a/packages/app/src/session/session-identity-header.tsx
+++ b/packages/app/src/session/session-identity-header.tsx
@@ -175,7 +175,7 @@ export function SessionLocation(props: {
{(name) => (
<>
-
+
/
@@ -252,7 +252,7 @@ export function SessionLocation(props: {
/
diff --git a/packages/app/src/shell/sidebar-toggle.tsx b/packages/app/src/shell/sidebar-toggle.tsx
index 67b531935de..4bf5153895c 100644
--- a/packages/app/src/shell/sidebar-toggle.tsx
+++ b/packages/app/src/shell/sidebar-toggle.tsx
@@ -56,12 +56,12 @@ export function SidebarToggle() {
variant="ghost-muted"
size="large"
class="shrink-0"
- state={settings.appearance.sidebarOpen() ? "pressed" : undefined}
+ onMouseDown={(event) => event.preventDefault()}
onClick={() => settings.appearance.setSidebarOpen(!settings.appearance.sidebarOpen())}
aria-label={language.t("command.sidebar.toggle")}
aria-expanded={settings.appearance.sidebarOpen()}
aria-controls="vertical-tabs-sidebar"
- icon={}
+ icon={}
/>
)
@@ -100,6 +100,7 @@ export function CollapsedSidebarToggle() {
return (
`,
},
- "sidebar-right": {
- viewBox: "0 0 20 20",
- body: ``,
- },
status: {
viewBox: "0 0 20 20",
body: ``,
diff --git a/packages/ui/src/icons/icon/additional-icons.ts b/packages/ui/src/icons/icon/additional-icons.ts
index e2a06bd6a1e..e3789db83f4 100644
--- a/packages/ui/src/icons/icon/additional-icons.ts
+++ b/packages/ui/src/icons/icon/additional-icons.ts
@@ -63,9 +63,9 @@ export const additionalIcons = {
"layout-left": ``,
"layout-left-partial": ``,
"layout-left-full": ``,
- "layout-right": ``,
- "layout-right-partial": ``,
- "layout-right-full": ``,
+ "layout-right": ``,
+ "layout-right-partial": ``,
+ "layout-right-full": ``,
"square-arrow-top-right": ``,
"open-file": ``,
"speech-bubble": ``,