From 1d3308d9045770d46563f48219ffeda5c5f920cd Mon Sep 17 00:00:00 2001 From: Kit Langton Date: Thu, 27 Aug 2026 23:26:45 -0400 Subject: [PATCH] test(core): refresh test vocabulary (#45714) --- packages/core/test/bus.test.ts | 4 +-- packages/core/test/permission.test.ts | 2 +- packages/core/test/session-runner.test.ts | 36 +++++++++++------------ 3 files changed, 21 insertions(+), 21 deletions(-) diff --git a/packages/core/test/bus.test.ts b/packages/core/test/bus.test.ts index 6c02c88aa9e..dcec627b280 100644 --- a/packages/core/test/bus.test.ts +++ b/packages/core/test/bus.test.ts @@ -228,10 +228,10 @@ describe("Bus", () => { ) const event = yield* bus.publish(SyncMessage, { id: "one", text: "hello" }) - yield* bus.publish(SyncMessage, { id: "one", text: "after unsubscribe" }) + yield* bus.publish(SyncMessage, { id: "one", text: "second event" }) expect(received[0]).toEqual(event) - expect(received[1]?.data).toEqual({ id: "one", text: "after unsubscribe" }) + expect(received[1]?.data).toEqual({ id: "one", text: "second event" }) }), ) diff --git a/packages/core/test/permission.test.ts b/packages/core/test/permission.test.ts index 4bffb2f9392..6973f1cd23c 100644 --- a/packages/core/test/permission.test.ts +++ b/packages/core/test/permission.test.ts @@ -122,7 +122,7 @@ describe("Permission", () => { }), ) - it.effect("evaluates against an explicit provider-turn agent", () => + it.effect("evaluates against an explicit agent", () => Effect.gen(function* () { yield* setup([{ action: "read", resource: "*", effect: "allow" }]) const agents = yield* Agent.Service diff --git a/packages/core/test/session-runner.test.ts b/packages/core/test/session-runner.test.ts index 371f3a4b04c..83cc4d98714 100644 --- a/packages/core/test/session-runner.test.ts +++ b/packages/core/test/session-runner.test.ts @@ -4241,15 +4241,15 @@ describe("SessionRunnerLLM", () => { expect((yield* Fiber.join(run).pipe(Effect.flip)).message).toBe("Provider blocked the response") const assistant = requireAssistant(yield* s.context) - const bus = yield* recordedStepSettlementEvents(sessionID, assistant.id) - expect(bus.map((event) => event.type)).toEqual([ + const events = yield* recordedStepSettlementEvents(sessionID, assistant.id) + expect(events.map((event) => event.type)).toEqual([ "session.step.started.1", "session.tool.called.1", "session.tool.success.2", "session.step.failed.1", ]) expect( - bus.filter((event) => event.type.startsWith("session.step.") && event.type !== "session.step.started.1"), + events.filter((event) => event.type.startsWith("session.step.") && event.type !== "session.step.started.1"), ).toHaveLength(1) }) @@ -5145,14 +5145,14 @@ describe("SessionRunnerLLM", () => { const context = yield* s.context const assistant = requireAssistant(context) - const bus = yield* recordedStepSettlementEvents(sessionID, assistant.id) - expect(bus.map((event) => event.type)).toEqual([ + const events = yield* recordedStepSettlementEvents(sessionID, assistant.id) + expect(events.map((event) => event.type)).toEqual([ "session.step.started.1", "session.tool.called.1", "session.tool.failed.2", "session.step.failed.1", ]) - expect(bus[2]?.data.error).toMatchObject({ type: "unknown", message: "unexpected tool defect" }) + expect(events[2]?.data.error).toMatchObject({ type: "unknown", message: "unexpected tool defect" }) }) scenario("preserves the provider failure when tool output persistence also fails", function* (s) { @@ -5179,15 +5179,15 @@ describe("SessionRunnerLLM", () => { "Provider did not return a tool result", ) const assistant = requireAssistant(yield* s.context) - const bus = yield* recordedStepSettlementEvents(sessionID, assistant.id) - expect(bus.map((event) => event.type)).toEqual([ + const events = yield* recordedStepSettlementEvents(sessionID, assistant.id) + expect(events.map((event) => event.type)).toEqual([ "session.step.started.1", "session.tool.called.1", "session.tool.failed.2", "session.step.failed.1", ]) expect( - bus.filter((event) => event.type.startsWith("session.step.") && event.type !== "session.step.started.1"), + events.filter((event) => event.type.startsWith("session.step.") && event.type !== "session.step.started.1"), ).toHaveLength(1) yield* replaySessionProjection(sessionID) @@ -5205,15 +5205,15 @@ describe("SessionRunnerLLM", () => { yield* s.runPrompt("Settle hosted tool before ending") const assistant = requireAssistant(yield* s.context) - const bus = yield* recordedStepSettlementEvents(sessionID, assistant.id) - expect(bus.map((event) => event.type)).toEqual([ + const events = yield* recordedStepSettlementEvents(sessionID, assistant.id) + expect(events.map((event) => event.type)).toEqual([ "session.step.started.1", "session.tool.called.1", "session.tool.failed.2", "session.step.ended.1", ]) expect( - bus.filter((event) => event.type.startsWith("session.step.") && event.type !== "session.step.started.1"), + events.filter((event) => event.type.startsWith("session.step.") && event.type !== "session.step.started.1"), ).toHaveLength(1) }) @@ -5239,8 +5239,8 @@ describe("SessionRunnerLLM", () => { expect(yield* Fiber.join(run).pipe(Effect.flip)).toBe(failure) const assistant = requireAssistant(yield* s.context) - const bus = yield* recordedStepSettlementEvents(sessionID, assistant.id) - expect(bus.map((event) => ({ type: event.type, id: event.data.id }))).toEqual([ + const events = yield* recordedStepSettlementEvents(sessionID, assistant.id) + expect(events.map((event) => ({ type: event.type, id: event.data.id }))).toEqual([ { type: "session.step.started.1", id: undefined }, { type: "session.tool.called.1", id: "call-local-raw-failure" }, { type: "session.tool.called.1", id: "call-hosted-raw-failure-pair" }, @@ -5249,7 +5249,7 @@ describe("SessionRunnerLLM", () => { { type: "session.step.failed.1", id: undefined }, ]) expect( - bus.filter((event) => event.type.startsWith("session.step.") && event.type !== "session.step.started.1"), + events.filter((event) => event.type.startsWith("session.step.") && event.type !== "session.step.started.1"), ).toHaveLength(1) }) @@ -5265,15 +5265,15 @@ describe("SessionRunnerLLM", () => { expect(yield* s.runPrompt("Fail hosted tool on raw failure").pipe(Effect.flip)).toBe(failure) expect(s.requests).toHaveLength(1) const assistant = requireAssistant(yield* s.context) - const bus = yield* recordedStepSettlementEvents(sessionID, assistant.id) - expect(bus.map((event) => event.type)).toEqual([ + const events = yield* recordedStepSettlementEvents(sessionID, assistant.id) + expect(events.map((event) => event.type)).toEqual([ "session.step.started.1", "session.tool.called.1", "session.tool.failed.2", "session.step.failed.1", ]) expect( - bus.filter((event) => event.type.startsWith("session.step.") && event.type !== "session.step.started.1"), + events.filter((event) => event.type.startsWith("session.step.") && event.type !== "session.step.started.1"), ).toHaveLength(1) yield* replaySessionProjection(sessionID) expect(yield* s.context).toMatchObject([