From 1e7ba46f8b990642328d253929e43ae7a41bdabd Mon Sep 17 00:00:00 2001 From: usrnk1 <7547651+usrnk1@users.noreply.github.com> Date: Wed, 28 Oct 2026 14:59:48 +0100 Subject: [PATCH] fix(app): polish recently closed files (#59876) --- .../app/e2e/regression/side-panels.spec.ts | 9 ++++-- packages/app/src/runtime/i18n/en.ts | 1 - .../src/runtime/plugin/closed-tabs-view.tsx | 32 +++++++++++++------ 3 files changed, 29 insertions(+), 13 deletions(-) diff --git a/packages/app/e2e/regression/side-panels.spec.ts b/packages/app/e2e/regression/side-panels.spec.ts index 8e7291258cf..b4cd9fe1900 100644 --- a/packages/app/e2e/regression/side-panels.spec.ts +++ b/packages/app/e2e/regression/side-panels.spec.ts @@ -254,10 +254,13 @@ test("the new tab view lists recently closed tabs, expands to the rest, and keep await panel.getByRole("button", { name: "Add tab", exact: true }).click() await expect(rows).toHaveCount(5) await expect(rows.first()).toContainText("closed-00.ts") - await recent.getByRole("button", { name: "Show more", exact: true }).click() + const more = recent.getByRole("button", { name: "Show more", exact: true }) + await more.focus() + await more.press("Enter") await expect(rows).toHaveCount(12) - await recent.getByRole("button", { name: "Show less", exact: true }).click() - await expect(rows).toHaveCount(5) + await expect(rows.filter({ hasText: "closed-05.ts" })).toBeFocused() + await expect(recent.getByRole("button", { name: "Show more", exact: true })).toHaveCount(0) + await expect(recent.getByRole("button", { name: "Show less", exact: true })).toHaveCount(0) // Closing the last tab closes the region; it opens on its launchers with that tab listed first. const readme = panel.getByRole("tab", { name: "README.md" }) diff --git a/packages/app/src/runtime/i18n/en.ts b/packages/app/src/runtime/i18n/en.ts index 9bfe7a81dc4..b1e36e4271e 100644 --- a/packages/app/src/runtime/i18n/en.ts +++ b/packages/app/src/runtime/i18n/en.ts @@ -578,7 +578,6 @@ export const dict = { "session.tab.add": "Add tab", "session.tab.recentHint": "Hold {{key}} for recently closed", "session.tab.showMore": "Show more", - "session.tab.showLess": "Show less", "session.tab.new": "New tab", "session.tab.unknown": "Unknown Session", "session.panel.reviewAndFiles": "Review and files", diff --git a/packages/app/src/runtime/plugin/closed-tabs-view.tsx b/packages/app/src/runtime/plugin/closed-tabs-view.tsx index 7c9a3848971..d47069954fe 100644 --- a/packages/app/src/runtime/plugin/closed-tabs-view.tsx +++ b/packages/app/src/runtime/plugin/closed-tabs-view.tsx @@ -28,12 +28,18 @@ function ClosedTabVisual(props: { entry: ClosedSideTab }): JSX.Element { const icon = () => (props.entry.icon && isIconName(props.entry.icon) ? props.entry.icon : "file-document") return ( - + } > - {(file) => } + {(file) => ( + + )} {props.entry.file ? getFilename(props.entry.file) : props.entry.title} @@ -71,7 +77,7 @@ export function ClosedTabsSection(props: { entries: readonly ClosedSideTab[]; on )} - SECTION_LIMIT}> + SECTION_LIMIT}> @@ -112,7 +126,7 @@ function ClosedTabsItems(props: { entries: readonly ClosedSideTab[]; onReopen: ( {(entry, index) => ( props.onReopen(entry.key)} shortcut={ 0}>