From 1f059e0f51b59b2712b1c46df878682ef87c4b01 Mon Sep 17 00:00:00 2001 From: Kit Langton Date: Wed, 21 Oct 2026 22:53:24 -0700 Subject: [PATCH] fix(app): default the header separator to an 11px chevron (#58006) --- .../app/e2e/regression/session-header.spec.ts | 17 ++------------- packages/app/src/session/header/separator.tsx | 17 +++------------ .../src/session/session-identity-header.css | 21 ++++++++++++------- .../src/session/session-identity-header.tsx | 6 ++---- 4 files changed, 21 insertions(+), 40 deletions(-) diff --git a/packages/app/e2e/regression/session-header.spec.ts b/packages/app/e2e/regression/session-header.spec.ts index 73c987221b5..f328fe5992f 100644 --- a/packages/app/e2e/regression/session-header.spec.ts +++ b/packages/app/e2e/regression/session-header.spec.ts @@ -224,24 +224,11 @@ test.describe("location", () => { .poll(() => header.getByRole("heading").evaluate((element) => element.scrollWidth <= element.clientWidth)) .toBe(true) if (panel) { - await expect - .poll(() => - header.evaluate((element) => { - const icon = element.querySelector('svg:has(use[href="#opencode-v2-icon-outline-worktree"])') - const before = icon?.previousElementSibling?.getBoundingClientRect() - const avatar = element - .querySelector('[data-slot="session-location-trigger"]') - ?.firstElementChild?.getBoundingClientRect() - const bounds = icon?.getBoundingClientRect() - - return bounds && before && avatar ? [before.left - avatar.right, bounds.left - before.right] : [] - }), - ) - .toEqual([10, 8]) const separator = header.locator('[data-slot="session-title-separator"]') await expect(separator).toBeVisible() await expect(separator).toHaveText("") await expect(separator).toHaveAttribute("aria-hidden", "true") + await expect(header.locator(".session-location-worktree-icon")).toBeHidden() const location = header.locator('[data-slot="session-location-trigger"]') await location.hover() await expect(location).toHaveCSS("padding-inline-start", "4px") @@ -256,7 +243,7 @@ test.describe("location", () => { await openSession(page, workspace) await expect(trigger(page).locator('[data-slot="session-location-project"]')).toHaveText("Location") await expect(trigger(page).locator('[data-slot="session-location-worktree"]')).toHaveText("quiet-falcon") - await expect(trigger(page).getByText("/", { exact: true })).toBeVisible() + await expect(trigger(page)).not.toContainText("/") await expect(trigger(page).locator('svg:has(use[href="#opencode-v2-icon-outline-worktree"])')).toBeVisible() await trigger(page).click() const card = page.locator('[data-slot="session-location-card"]') diff --git a/packages/app/src/session/header/separator.tsx b/packages/app/src/session/header/separator.tsx index 0fc0aa77439..c07b8693fb1 100644 --- a/packages/app/src/session/header/separator.tsx +++ b/packages/app/src/session/header/separator.tsx @@ -7,14 +7,14 @@ const group = "Experiments" const glyph = motionTuning.choice("sessionHeader.separator", { label: "Header separator", group, - value: "divider", + value: "chevron", labels: { divider: "Divider", slash: "Slash", chevron: "Chevron", bold: "Bold chevron", dot: "Dot" }, }) const size = motionTuning.number("sessionHeader.separator.size", { label: "Separator size", group, - value: 14, + value: 11, min: 6, max: 24, step: 1, @@ -93,18 +93,7 @@ export function SessionHeaderSeparator(props: { before?: number; after?: number - - - + .session-header-separator { --separator-before: 10px; } @@ -51,8 +47,9 @@ --separator-before: 9px; } - .session-header-location:has([data-slot="session-location-worktree"]) > .session-header-separator { - --separator-before: 9px; + /* The collapsed header reads avatar, separator, title; the names stay in the trigger's title and accessible name. */ + .session-header-location .session-location-worktree-icon { + display: none; } /* Keep the names available to assistive tech while the icons leave room for the title. */ @@ -102,6 +99,16 @@ calc(var(--separator-gap) - var(--separator-after, 6px) - 0.5px); } +/* The original "/" text, as generated content so the separator itself stays empty for assistive tech. */ +.session-header-slash::before { + content: "/"; + font-size: 11px; + font-weight: 500; + line-height: var(--line-height-base); + /* Cancels the glyph's side bearings so the margins above measure to its ink. */ + margin-inline: -0.25px -0.34px; +} + .session-header-separator[data-glyph="chevron"]:dir(rtl) > svg, .session-header-separator[data-glyph="bold"]:dir(rtl) > svg { transform: scaleX(-1); diff --git a/packages/app/src/session/session-identity-header.tsx b/packages/app/src/session/session-identity-header.tsx index c479c5131c1..95f368eead8 100644 --- a/packages/app/src/session/session-identity-header.tsx +++ b/packages/app/src/session/session-identity-header.tsx @@ -182,6 +182,7 @@ export function SessionLocation(props: { {(name) => ( <> - - + {name()}