From 239730eb39d54cbd2b06e5d750ecc853a6b66c35 Mon Sep 17 00:00:00 2001 From: vaprdev <13180538+vaprdev@users.noreply.github.com> Date: Thu, 5 Nov 2026 05:51:49 +0000 Subject: [PATCH] feat(app): apply themes as arrow keys move through the theme picker --- packages/app/component-tests/select.spec.ts | 48 +++++++++++++++++++ .../src/settings/appearance/appearance.tsx | 1 + .../ui/src/forms/select/select.stories.tsx | 14 ++++++ packages/ui/src/forms/select/select.tsx | 26 ++++++++-- 4 files changed, 86 insertions(+), 3 deletions(-) create mode 100644 packages/app/component-tests/select.spec.ts diff --git a/packages/app/component-tests/select.spec.ts b/packages/app/component-tests/select.spec.ts new file mode 100644 index 00000000000..794bbcfedb3 --- /dev/null +++ b/packages/app/component-tests/select.spec.ts @@ -0,0 +1,48 @@ +import { expect, story } from "../../stories/playwright/story" + +story("selects the option arrow keys move to while the menu stays open", async ({ mount, page }) => { + const root = await mount("ui-select--select-on-navigate") + const current = root.getByTestId("select-on-navigate-current") + const listbox = page.getByRole("listbox") + + await root.locator('[data-component="select-v2"]').click() + await expect(listbox).toBeVisible() + // Opening only highlights the current option. + await expect(current).toHaveText("Selected: Banana") + + await page.keyboard.press("ArrowDown") + await expect(current).toHaveText("Selected: Cherry") + await expect(listbox).toBeVisible() + + await page.keyboard.press("ArrowDown") + await expect(current).toHaveText("Selected: Date") + + await page.keyboard.press("ArrowUp") + await expect(current).toHaveText("Selected: Cherry") + + // Hover highlights without selecting. + await page.getByRole("option", { name: "Apple" }).hover() + await expect(page.getByRole("option", { name: "Apple" })).toHaveAttribute("data-highlighted", "") + await expect(current).toHaveText("Selected: Cherry") + + await page.keyboard.press("Escape") + await expect(listbox).toBeHidden() + await expect(current).toHaveText("Selected: Cherry") +}) + +story("keeps the selection when the keyboard opens the menu", async ({ mount, page }) => { + const root = await mount("ui-select--select-on-navigate") + const current = root.getByTestId("select-on-navigate-current") + + await root.locator('[data-component="select-v2"]').focus() + await page.keyboard.press("ArrowDown") + await expect(page.getByRole("listbox")).toBeVisible() + await expect(current).toHaveText("Selected: Banana") + + await page.keyboard.press("ArrowDown") + await expect(current).toHaveText("Selected: Cherry") + + await page.keyboard.press("Enter") + await expect(page.getByRole("listbox")).toBeHidden() + await expect(current).toHaveText("Selected: Cherry") +}) diff --git a/packages/app/src/settings/appearance/appearance.tsx b/packages/app/src/settings/appearance/appearance.tsx index 1100ae2d613..5774590df33 100644 --- a/packages/app/src/settings/appearance/appearance.tsx +++ b/packages/app/src/settings/appearance/appearance.tsx @@ -128,6 +128,7 @@ export const SettingsAppearance: Component = () => { value={(option) => option.id} label={(option) => option.name} onSelect={appearance.theme.select} + selectOnNavigate /> diff --git a/packages/ui/src/forms/select/select.stories.tsx b/packages/ui/src/forms/select/select.stories.tsx index 4da62ccf6a2..8489e287d64 100644 --- a/packages/ui/src/forms/select/select.stories.tsx +++ b/packages/ui/src/forms/select/select.stories.tsx @@ -27,6 +27,7 @@ Single-select built on Kobalte with current menu styling. The trigger is inline - \`groupBy\`: groups options; section headers use menu group label styling. - \`placement\`, \`gutter\`, \`sameWidth\`, \`flip\`, \`slide\`, \`fitViewport\`: forwarded to Kobalte popper. - \`invalid\`, \`disabled\`, \`numeric\`: match text input conventions. +- \`selectOnNavigate\`: arrow keys and typeahead select the option they move to while the menu stays open; hover only highlights. ` export default { @@ -98,6 +99,19 @@ export const Grouped = { }, } +export const SelectOnNavigate = { + render: () => { + const [current, setCurrent] = createSignal("Banana") + + return ( +