fix(acp): detach new and resumed sessions when setup fails (#52558)

This commit is contained in:
Shoubhit Dash
2026-10-02 16:07:33 +05:30
committed by GitHub
Unverified
parent 4cb56a829e
commit 4a2c024ea7
2 changed files with 41 additions and 2 deletions
+8 -2
View File
@@ -196,7 +196,10 @@ export function make(input: {
}),
)
const attached = yield* input.sessions.attach(created, params.cwd, params.mcpServers)
return { sessionId: attached.id, configOptions: yield* currentOptions(attached) }
return yield* currentOptions(attached).pipe(
Effect.map((configOptions) => ({ sessionId: attached.id, configOptions })),
Effect.onError(() => input.sessions.detach(attached.id)),
)
}),
loadSession: Effect.fnUntraced(function* (params) {
const directories = yield* ACPDirectories.parse(params.cwd, params.additionalDirectories)
@@ -248,7 +251,10 @@ export function make(input: {
const session = yield* getSession(params.sessionId, params.cwd)
yield* ACPDirectories.activate(input.client, session, directories)
const attached = yield* input.sessions.attach(session, session.location.directory, params.mcpServers ?? [])
return { configOptions: yield* currentOptions(attached) }
return yield* currentOptions(attached).pipe(
Effect.map((configOptions) => ({ configOptions })),
Effect.onError(() => input.sessions.detach(attached.id)),
)
}),
closeSession: Effect.fnUntraced(function* (params) {
yield* input.turn.close(params.sessionId)