From 57f5670971bbb07a420cc4bb16a1e6f6263a5314 Mon Sep 17 00:00:00 2001 From: usrnk1 <7547651+usrnk1@users.noreply.github.com> Date: Fri, 20 Nov 2026 08:18:44 +0100 Subject: [PATCH] fix(ui): don't show the composer focus ring when returning to the window (#65082) --- packages/ui/src/context/field-focus.tsx | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/packages/ui/src/context/field-focus.tsx b/packages/ui/src/context/field-focus.tsx index 069bd484409..bddde09ec25 100644 --- a/packages/ui/src/context/field-focus.tsx +++ b/packages/ui/src/context/field-focus.tsx @@ -40,6 +40,7 @@ export function createFieldFocus() { const [visible, setVisible] = createSignal(false) let pointer = false + let returning = false let timer: ReturnType | undefined const clearPointer = () => { @@ -60,10 +61,14 @@ export function createFieldFocus() { }, enter: (element: HTMLElement) => { fieldRings.set(element, setVisible) - setVisible(restoring.get(element) ?? !pointer) + setVisible(restoring.get(element) ?? (!pointer && !returning)) + returning = false clearPointer() }, - leave: () => { + leave: (event: FocusEvent) => { + // Switching to another window blurs the field but leaves it the active element, and focus returns to it on the way + // back. That return isn't the user moving focus to the field, so it shows no ring. + returning = event.currentTarget === document.activeElement setVisible(false) clearPointer() },