From 5db3553efa5d893d1d142686f679d92db3af3005 Mon Sep 17 00:00:00 2001 From: James Long Date: Tue, 17 Nov 2026 12:37:35 -0500 Subject: [PATCH] feat(app): always show the assistant copy button (#64478) --- packages/app/src/session/timeline/cache.ts | 3 - .../src/shell/routes/session-ui-provider.tsx | 3 - .../session-timeline-mobile.spec.ts | 101 ++++++++++-------- .../src/components/message-part.css | 23 +--- packages/session-ui/src/context/data.tsx | 5 - .../src/message/message-content.tsx | 6 +- 6 files changed, 65 insertions(+), 76 deletions(-) diff --git a/packages/app/src/session/timeline/cache.ts b/packages/app/src/session/timeline/cache.ts index d73922409da..71c3af99c4b 100644 --- a/packages/app/src/session/timeline/cache.ts +++ b/packages/app/src/session/timeline/cache.ts @@ -120,9 +120,6 @@ export function createTimelineCache( get agents() { return agents() }, - get copyAlwaysVisible() { - return data.copyAlwaysVisible - }, navigateToSession: data.navigateToSession, sessionHref: data.sessionHref, readMedia: data.readMedia, diff --git a/packages/app/src/shell/routes/session-ui-provider.tsx b/packages/app/src/shell/routes/session-ui-provider.tsx index 8df23d77b0b..40fd02ccc0d 100644 --- a/packages/app/src/shell/routes/session-ui-provider.tsx +++ b/packages/app/src/shell/routes/session-ui-provider.tsx @@ -45,8 +45,6 @@ export function SessionUIProvider( const language = useLanguage() const settings = useSettings() const directory = () => props.directory - const releaseChannel = import.meta.env.VITE_OPENCODE_CHANNEL ?? "local" - const copyAlwaysVisible = releaseChannel === "dev" || releaseChannel === "local" const readImage = createMemo(() => { const dir = directory() @@ -240,7 +238,6 @@ export function SessionUIProvider( directory={directory()} sessionID={params.id} agents={settings.visibility.customAgents()} - copyAlwaysVisible={copyAlwaysVisible} shellRunning={(id) => !!data.shell.get(id)} shellOutput={(input) => serverSDK.api.shell.output(input)} readMedia={(uri, mime, signal) => serverSDK.media.load(uri, mime, signal)} diff --git a/packages/session-ui/component-tests/session-timeline-mobile.spec.ts b/packages/session-ui/component-tests/session-timeline-mobile.spec.ts index 2953d367c8f..9b542e31613 100644 --- a/packages/session-ui/component-tests/session-timeline-mobile.spec.ts +++ b/packages/session-ui/component-tests/session-timeline-mobile.spec.ts @@ -98,49 +98,66 @@ story.describe("touch timeline", () => { }) }) -story("desktop message actions still appear on hover and keyboard focus", async ({ mount, page }) => { +story("desktop user message actions still appear on hover and keyboard focus", async ({ mount, page }) => { const timeline = await mount("current-session-timeline-rows--conversation", { args: { scenario: "interruption" } }) expect(await page.evaluate(() => matchMedia("(hover: hover)").matches)).toBe(true) - for (const action of [ - { slot: "user-message-menu", name: "More actions" }, - { slot: "text-part-copy-wrapper", name: "Copy response" }, - ]) { - const actions = timeline.locator(`[data-slot="${action.slot}"]`) - await expect(actions).toHaveCount(1) - await expect(actions).toHaveCSS("opacity", "0") - await expect(actions).toHaveCSS("pointer-events", "none") - await actions.locator("..").hover() - await expect(actions).toHaveCSS("opacity", "1") - await expect(actions).toHaveCSS("pointer-events", "auto") - - if (action.slot === "text-part-copy-wrapper") { - await expect(actions).toHaveCSS("height", "20px") - await expect(actions).toHaveCSS("margin-top", "8px") - await expect(actions).toHaveCSS("gap", "4px") - const meta = actions.locator('[data-slot="text-part-meta"]') - await expect(meta).toHaveCSS("font-size", "12px") - await expect(meta).toHaveCSS("line-height", "18px") - await expect(meta).toHaveCSS("gap", "4px") - await expect(meta.locator('[data-slot="text-part-meta-item"]')).toHaveText(["Build", "Claude Sonnet 4", "4s"]) - const separators = meta.locator('[data-slot="text-part-meta-separator"]') - await expect(separators).toHaveCount(2) - - for (const separator of await separators.all()) { - await expect(separator).toHaveText("\u00B7") - } - - const copy = actions.getByRole("button", { name: action.name, exact: true }) - await expect(copy).toHaveCSS("width", "20px") - await expect(copy).toHaveCSS("height", "20px") - await expect(copy.locator('[data-slot="icon-svg"]')).toHaveCSS("width", "14px") - } - - await page.mouse.move(0, 0) - await expect(actions).toHaveCSS("opacity", "0") - await actions.getByRole("button", { name: action.name, exact: true }).focus() - await expect(actions).toHaveCSS("opacity", "1") - await expect(actions).toHaveCSS("pointer-events", "auto") - await page.getByRole("button", { name: "Reset", exact: true }).focus() - } + const actions = timeline.locator('[data-slot="user-message-menu"]') + await expect(actions).toHaveCount(1) + await expect(actions).toHaveCSS("opacity", "0") + await expect(actions).toHaveCSS("pointer-events", "none") + await actions.locator("..").hover() + await expect(actions).toHaveCSS("opacity", "1") + await expect(actions).toHaveCSS("pointer-events", "auto") + await page.mouse.move(0, 0) + await expect(actions).toHaveCSS("opacity", "0") + await actions.getByRole("button", { name: "More actions", exact: true }).focus() + await expect(actions).toHaveCSS("opacity", "1") + await expect(actions).toHaveCSS("pointer-events", "auto") +}) + +story("desktop response copy stays visible while its metadata waits for hover or focus", async ({ mount, page }) => { + const timeline = await mount("current-session-timeline-rows--conversation", { args: { scenario: "interruption" } }) + expect(await page.evaluate(() => matchMedia("(hover: hover)").matches)).toBe(true) + + const actions = timeline.locator('[data-slot="text-part-copy-wrapper"]') + await expect(actions).toHaveCount(1) + await expect(actions).toHaveCSS("height", "20px") + await expect(actions).toHaveCSS("margin-top", "8px") + await expect(actions).toHaveCSS("gap", "4px") + await expect(actions).toHaveCSS("opacity", "1") + await expect(actions).toHaveCSS("pointer-events", "auto") + + const copy = actions.getByRole("button", { name: "Copy response", exact: true }) + await expect(copy).toBeVisible() + await expect(copy).toHaveCSS("width", "20px") + await expect(copy).toHaveCSS("height", "20px") + await expect(copy.locator('[data-slot="icon-svg"]')).toHaveCSS("width", "14px") + const rest = await copy.boundingBox() + + const meta = actions.locator('[data-slot="text-part-meta"]') + await expect(meta).toHaveCSS("opacity", "0") + await expect(meta).toHaveCSS("pointer-events", "none") + await expect(meta).toHaveCSS("font-size", "12px") + await expect(meta).toHaveCSS("line-height", "18px") + await expect(meta).toHaveCSS("gap", "4px") + await expect(meta.locator('[data-slot="text-part-meta-item"]')).toHaveText(["Build", "Claude Sonnet 4", "4s"]) + const separators = meta.locator('[data-slot="text-part-meta-separator"]') + await expect(separators).toHaveCount(2) + + for (const separator of await separators.all()) { + await expect(separator).toHaveText("\u00B7") + } + + await actions.locator("..").hover() + await expect(meta).toHaveCSS("opacity", "1") + await expect(meta).toHaveCSS("pointer-events", "auto") + expect(await copy.boundingBox()).toEqual(rest) + + await page.mouse.move(0, 0) + await expect(meta).toHaveCSS("opacity", "0") + await expect(actions).toHaveCSS("opacity", "1") + await copy.focus() + await expect(meta).toHaveCSS("opacity", "1") + await expect(meta).toHaveCSS("pointer-events", "auto") }) diff --git a/packages/session-ui/src/components/message-part.css b/packages/session-ui/src/components/message-part.css index 6ed1a521a83..de0b853bd41 100644 --- a/packages/session-ui/src/components/message-part.css +++ b/packages/session-ui/src/components/message-part.css @@ -582,16 +582,9 @@ justify-content: flex-start; gap: 4px; - /* Production keeps the whole footer hover-only. Dev channels keep the copy control visible and - hide only the metadata. Keeping the metadata in flow means the copy control does not move. */ - @media (hover: hover) { - &:not([data-copy-always-visible]) { - opacity: 0; - pointer-events: none; - } - } - - &[data-copy-always-visible] [data-slot="text-part-meta"] { + /* The copy control stays visible; only the metadata waits for hover or focus. Keeping the metadata + in flow means the copy control does not move. */ + [data-slot="text-part-meta"] { @media (hover: hover) { opacity: 0; pointer-events: none; @@ -668,14 +661,8 @@ transition: none; } - &:hover [data-slot="text-part-copy-wrapper"], - &:focus-within [data-slot="text-part-copy-wrapper"] { - opacity: 1; - pointer-events: auto; - } - - &:hover [data-slot="text-part-copy-wrapper"][data-copy-always-visible] [data-slot="text-part-meta"], - &:focus-within [data-slot="text-part-copy-wrapper"][data-copy-always-visible] [data-slot="text-part-meta"] { + &:hover [data-slot="text-part-copy-wrapper"] [data-slot="text-part-meta"], + &:focus-within [data-slot="text-part-copy-wrapper"] [data-slot="text-part-meta"] { opacity: 1; pointer-events: auto; } diff --git a/packages/session-ui/src/context/data.tsx b/packages/session-ui/src/context/data.tsx index a35f082710e..7790873fe11 100644 --- a/packages/session-ui/src/context/data.tsx +++ b/packages/session-ui/src/context/data.tsx @@ -72,8 +72,6 @@ export const { sessionID?: string /** Whether message meta names the agent; the app follows its Show agent setting. Defaults to true. */ agents?: boolean - /** Whether the assistant copy control stays visible at rest; the app enables this on dev/local builds. */ - copyAlwaysVisible?: boolean shellRunning?: (id: string) => boolean shellOutput?: (input: ShellOutputInput) => Promise turnDiff?: TurnDiffSource @@ -95,9 +93,6 @@ export const { get agents() { return props.agents ?? true }, - get copyAlwaysVisible() { - return props.copyAlwaysVisible === true - }, navigateToSession: props.onNavigateToSession, sessionHref: props.onSessionHref, shellRunning: props.shellRunning, diff --git a/packages/session-ui/src/message/message-content.tsx b/packages/session-ui/src/message/message-content.tsx index f651e6a6246..2abad82f91a 100644 --- a/packages/session-ui/src/message/message-content.tsx +++ b/packages/session-ui/src/message/message-content.tsx @@ -1232,11 +1232,7 @@ export function AssistantTextContent(props: { function copyFooter() { return ( -
+