From 65f646f8d768375c732c9e56715dbcbfb9151b29 Mon Sep 17 00:00:00 2001 From: Wish Date: Thu, 5 Nov 2026 03:21:07 +0530 Subject: [PATCH] fix(tui): stop session titles with newlines from crashing the TUI (#57523) Co-authored-by: Daniel Smolsky --- packages/tui/src/util/renderer.ts | 2 +- packages/tui/test/util/renderer.test.ts | 6 ++++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/packages/tui/src/util/renderer.ts b/packages/tui/src/util/renderer.ts index 88296e44ed9..910f4f30e15 100644 --- a/packages/tui/src/util/renderer.ts +++ b/packages/tui/src/util/renderer.ts @@ -5,7 +5,7 @@ type TitleRenderer = Pick) { diff --git a/packages/tui/test/util/renderer.test.ts b/packages/tui/test/util/renderer.test.ts index f5b260a46aa..b60573e811c 100644 --- a/packages/tui/test/util/renderer.test.ts +++ b/packages/tui/test/util/renderer.test.ts @@ -3,6 +3,12 @@ import { RendererControlState } from "@opentui/core" import { createTestRenderer } from "@opentui/core/testing" import { destroyRenderer, setTerminalTitle } from "../../src/util/renderer" +test("sets a title that contains control characters", async () => { + await using setup = await createTestRenderer({ width: 10, height: 2 }) + await setup.renderer.setupTerminal() + expect(() => setTerminalTitle(setup.renderer, "Fix parser bug\nin tokenizer")).not.toThrow() +}) + test("clears the terminal title before destroying the renderer", () => { const calls: string[] = [] destroyRenderer({