diff --git a/packages/core/src/tool/plugin/read.ts b/packages/core/src/tool/plugin/read.ts index 3d71d12fd65..3d2e729556a 100644 --- a/packages/core/src/tool/plugin/read.ts +++ b/packages/core/src/tool/plugin/read.ts @@ -53,6 +53,8 @@ export const Plugin = { output: Output, execute: (input, context) => { return Effect.gen(function* () { + if (input.limit === 0) + return yield* new ToolFailure({ message: "Limit must be a positive integer" }) if (Skill.isUri(input.path)) { const parsed = parseSkillUri(input.path) if (!parsed) return yield* new ToolFailure({ message: `File not found: ${input.path}` }) diff --git a/packages/core/test/tool-read.test.ts b/packages/core/test/tool-read.test.ts index e969ba5c51f..280f539997b 100644 --- a/packages/core/test/tool-read.test.ts +++ b/packages/core/test/tool-read.test.ts @@ -223,6 +223,23 @@ describe("ReadTool", () => { }), ) + it.effect("rejects a zero limit before reading", () => + Effect.gen(function* () { + const registry = yield* Tool.Service + const result = yield* executeTool(registry, { + sessionID, + ...toolIdentity, + call: { type: "tool-call", id: "call-zero-limit", name: "read", input: { path: "README.md", limit: 0 } }, + }) + expect(result).toMatchObject({ + status: "error", + error: { message: "Limit must be a positive integer" }, + }) + expect(assertions).toEqual([]) + expect(readCalls).toEqual([]) + }), + ) + it.effect("asks for external_directory approval before reading an external absolute path", () => Effect.gen(function* () { const registry = yield* Tool.Service