From 6d1be26251fc646b256b5215b29d9bdd501209b2 Mon Sep 17 00:00:00 2001 From: Kit Langton Date: Mon, 12 Oct 2026 00:32:12 -0700 Subject: [PATCH] fix(app): expand video previews into in-window theatre mode (#54696) --- packages/app/e2e/regression/review.spec.ts | 67 ++++++++ .../gui-extensions/src/file/artifact-view.css | 29 ++++ .../gui-extensions/src/file/artifact-view.tsx | 153 +++++++++++++++++- packages/gui-extensions/src/file/i18n/en.ts | 2 + 4 files changed, 247 insertions(+), 4 deletions(-) diff --git a/packages/app/e2e/regression/review.spec.ts b/packages/app/e2e/regression/review.spec.ts index eee77ff6ea5..b6ff69701bf 100644 --- a/packages/app/e2e/regression/review.spec.ts +++ b/packages/app/e2e/regression/review.spec.ts @@ -581,6 +581,73 @@ test("image files keep the review panel painted while loading", async ({ page }) ).toEqual([]) }) +test("video files expand into an in-window theatre overlay and collapse on Escape without remounting", async ({ + page, +}) => { + const directory = "C:/OpenCode/ReviewVideo" + const file = "demo.webm" + + const webm = Buffer.from( + "GkXfo59ChoEBQveBAULygQRC84EIQoKEd2VibUKHgQJChYECGFOAZwEAAAAAAAH5EU2bdLpNu4tTq4QVSalmU6yBoU27i1OrhBZUrmtTrIHWTbuMU6uEElTDZ1OsggEyTbuMU6uEHFO7a1OsggHj7AEAAAAAAABZAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAVSalmsCrXsYMPQkBNgIxMYXZmNjMuMS4xMDJXQYxMYXZmNjMuMS4xMDJEiYhAj0AAAAAAABZUrmvXrgEAAAAAAABO14EBc8WIiQeUklk95R2cgQAitZyDdW5kiIEAhoVWX1ZQOIOBASPjg4Q7msoA4JCwgUC6gSSagQJVsIRVuYEBVe6BAOwBAAAAAAAAAgAAElTDZ/pzc59jwIBnyJlFo4dFTkNPREVSRIeMTGF2ZjYzLjEuMTAyc3PVY8CLY8WIiQeUklk95R1nyKBFo4dFTkNPREVSRIeTTGF2YzYzLjEuMTAyIGxpYnZweGfIoUWjiERVUkFUSU9ORIeTMDA6MDA6MDEuMDAwMDAwMDAwAB9DtnWt54EAo6iBAACAsAIAnQEqQAAkAABHCIWFiJmEiAICAAaOT8zHm/FYAP7/q1CAHFO7a5G7j7OBALeK94EB8YIBsfCBAw==", + "base64", + ) + + await openSession(page, { + name: "ReviewVideo", + fileList: (path) => (path ? [] : [fileNode(directory, file)]), + seed: { + panes: { ses_reviewvideo: { review: true } }, + }, + }) + await page.route(`**/api/fs/read/${file}*`, (route) => + route.fulfill({ + status: 200, + headers: { "access-control-allow-origin": "*", "content-type": "application/octet-stream" }, + body: webm, + }), + ) + + const panel = page.locator("#review-panel") + await panel.getByRole("button", { name: "Open file" }).click() + await panel.getByRole("button", { name: file }).click() + await expect(panel.getByRole("tab", { name: file, exact: true })).toHaveAttribute("aria-selected", "true") + + const stage = panel.locator('[data-slot="artifact-stage"]') + const video = stage.locator('video[data-slot="artifact-media"]') + const fullscreen = stage.getByRole("button", { name: "Enter full screen", exact: true }) + const exitFullscreen = stage.getByRole("button", { name: "Exit full screen", exact: true }) + + await expect(video).toBeVisible() + await expect(fullscreen).toHaveAttribute("aria-pressed", "false") + const inlineBounds = (await stage.boundingBox())! + expect(inlineBounds.width).toBeLessThan(1000) + + await video.evaluate((element) => { + element.dataset.e2eProbe = "retained" + }) + + await fullscreen.click() + await expect(exitFullscreen).toHaveAttribute("aria-pressed", "true") + await expect(stage).toHaveAttribute("data-expanded", "") + expect(await stage.evaluate((element) => element.matches(":popover-open"))).toBe(true) + expect(await page.evaluate(() => document.fullscreenElement)).toBeNull() + expect(await video.evaluate((element) => element.dataset.e2eProbe)).toBe("retained") + await expect.poll(() => stage.boundingBox()).toEqual({ x: 0, y: 0, width: 1440, height: 900 }) + + await page.keyboard.press("Escape") + await expect(fullscreen).toHaveAttribute("aria-pressed", "false") + await expect(stage).not.toHaveAttribute("data-expanded") + expect(await stage.evaluate((element) => element.matches(":popover-open"))).toBe(false) + expect(await video.evaluate((element) => element.dataset.e2eProbe)).toBe("retained") + await expect.poll(() => stage.boundingBox()).toEqual(inlineBounds) + + await video.dblclick() + await expect(exitFullscreen).toHaveAttribute("aria-pressed", "true") + await page.mouse.click(8, 8) + await expect(fullscreen).toHaveAttribute("aria-pressed", "false") + expect(await video.evaluate((element) => element.dataset.e2eProbe)).toBe("retained") +}) + test("restores review state and the side-panel tab per session", async ({ page }) => { const sessions = [ { id: "ses_review_state_a", title: "Alpha review state" }, diff --git a/packages/gui-extensions/src/file/artifact-view.css b/packages/gui-extensions/src/file/artifact-view.css index 87af880c370..9a079ddf374 100644 --- a/packages/gui-extensions/src/file/artifact-view.css +++ b/packages/gui-extensions/src/file/artifact-view.css @@ -33,6 +33,21 @@ -8px 0; } +[data-slot="artifact-stage"][data-expanded] { + position: fixed; + inset: 0; + z-index: 50; + width: 100vw; + height: 100vh; + max-width: none; + max-height: none; + margin: 0; + padding: 0; + border: 0; + background-color: color-mix(in oklch, black 88%, transparent); + backdrop-filter: blur(8px); +} + [data-slot="artifact-media"] { display: block; border-radius: 4px; @@ -41,6 +56,20 @@ 0 12px 32px -12px color-mix(in oklch, var(--v2-text-text-base) 25%, transparent); } +[data-slot="artifact-media"]::-webkit-media-controls-fullscreen-button { + visibility: hidden; + pointer-events: none; +} + +[data-slot="artifact-video-fullscreen"] { + color: #ffffff; +} + +[data-slot="artifact-video-fullscreen"]:hover > span, +[data-slot="artifact-video-fullscreen"]:focus-visible > span { + background-color: rgb(0 0 0 / 0.55); +} + [data-slot="artifact-stage"][data-zoom="fit"] [data-slot="artifact-media"] { max-width: 100%; max-height: 100%; diff --git a/packages/gui-extensions/src/file/artifact-view.tsx b/packages/gui-extensions/src/file/artifact-view.tsx index ebd52aeef16..2ed851d2b2d 100644 --- a/packages/gui-extensions/src/file/artifact-view.tsx +++ b/packages/gui-extensions/src/file/artifact-view.tsx @@ -1,6 +1,7 @@ import { createMemo, createSignal, ErrorBoundary, For, Match, onCleanup, Show, Switch, untrack, type JSX } from "solid-js" import { createStore } from "solid-js/store" import { Dynamic } from "solid-js/web" +import { makeEventListener } from "@solid-primitives/event-listener" import { createResizeObserver } from "@solid-primitives/resize-observer" import { Button } from "@opencode/ui/button" import { FileIcon } from "@opencode/ui/file-icon" @@ -363,12 +364,110 @@ function ArtifactImage(props: MediaProps) { } function ArtifactVideo(props: MediaProps) { + const ctx = useExtension() const url = createBlobUrl(() => props.content) + // Fullscreen belongs to one video: a new file starts fitted in the pane. + const [expandedUrl, setExpandedUrl] = createSignal() + const [paused, setPaused] = createSignal(true) + const [active, setActive] = createSignal(false) + const [box, setBox] = createStore({ left: 0, top: 0, ready: false }) + const expanded = () => expandedUrl() === url() + + let stage: HTMLDivElement | undefined + let video: HTMLVideoElement | undefined + let idleTimer: ReturnType | undefined + + const clearIdle = () => { + if (idleTimer !== undefined) clearTimeout(idleTimer) + idleTimer = undefined + } + + const wake = () => { + setActive(true) + clearIdle() + idleTimer = setTimeout(() => setActive(false), 2500) + } + + onCleanup(clearIdle) + + const close = () => setExpandedUrl(undefined) + const toggle = () => setExpandedUrl(expanded() ? undefined : url()) + + const measure = () => { + if (!video || video.offsetWidth === 0 || video.offsetHeight === 0) return + + // Chromium's media controls place the 48x48 fullscreen slot 48px from the right edge (beside the + // 48px overflow button) and 24px above the bottom edge (above the 24px timeline scrubber). + setBox({ + left: video.offsetLeft + video.offsetWidth - 96, + top: video.offsetTop + video.offsetHeight - 72, + ready: true, + }) + } + + createResizeObserver( + () => [stage, video], + () => measure(), + ) + + // Top-layer promotion escapes the side panel's stacking context and
's content containment + // while keeping the same