From 8aebed170a14d3e3d841883dd2d3d171529d745c Mon Sep 17 00:00:00 2001 From: Luke Parker <10430890+Hona@users.noreply.github.com> Date: Mon, 21 Sep 2026 14:54:47 +1000 Subject: [PATCH] fix(app): show empty review state for projects without VCS (#50265) --- packages/app/src/session/review/model.ts | 3 +++ packages/app/src/session/review/view.tsx | 4 ++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/packages/app/src/session/review/model.ts b/packages/app/src/session/review/model.ts index d06135114c8..b771896868a 100644 --- a/packages/app/src/session/review/model.ts +++ b/packages/app/src/session/review/model.ts @@ -155,6 +155,9 @@ export function createSessionReview(input: { const count = () => diffs().length const hasChanges = () => count() > 0 const ready = () => { + // A project without VCS never enables vcsQuery, so its status stays "pending" forever. + const project = input.session.project() + if (project && !project.vcs) return true if (mode() === "git" || mode() === "branch") return !vcsQuery.isPending return true } diff --git a/packages/app/src/session/review/view.tsx b/packages/app/src/session/review/view.tsx index 06660e9c258..783c74d200e 100644 --- a/packages/app/src/session/review/view.tsx +++ b/packages/app/src/session/review/view.tsx @@ -249,7 +249,7 @@ function ReviewTitle(props: { review: SessionReviewModel }) { function ReviewEmpty(props: { review: SessionReviewModel; loadingClass: string }) { const language = useLanguage() const loading = () => (props.review.mode() === "git" || props.review.mode() === "branch") && !props.review.ready() - const noGit = () => props.review.mode() === "turn" && props.review.noGit() + const noGit = () => props.review.noGit() const text = () => { if (props.review.mode() === "git") return language.t("session.review.noUncommittedChanges") if (props.review.mode() === "branch") return language.t("session.review.noBranchChanges") @@ -282,7 +282,7 @@ function ReviewEmpty(props: { review: SessionReviewModel; loadingClass: string } function ReviewPanelEmpty(props: { review: SessionReviewModel }) { const language = useLanguage() const loading = () => (props.review.mode() === "git" || props.review.mode() === "branch") && !props.review.ready() - const noGit = () => props.review.mode() === "turn" && props.review.noGit() + const noGit = () => props.review.noGit() return (