From 8e750b59a489f3a5891ef5ce2677847cfde238dc Mon Sep 17 00:00:00 2001 From: Simon Klee Date: Thu, 5 Nov 2026 01:19:51 +0100 Subject: [PATCH] fix(cli-rs): choose a select row on the left button's release only Releasing a right-click over a DialogSelect row chose it (ms3-ms4 carbon review note). --- packages/cli-rs/crates/ui/src/select.rs | 2 +- packages/cli-rs/crates/ui/tests/all/dialogs.rs | 7 +++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/packages/cli-rs/crates/ui/src/select.rs b/packages/cli-rs/crates/ui/src/select.rs index a4b57f8da45..6be713abf85 100644 --- a/packages/cli-rs/crates/ui/src/select.rs +++ b/packages/cli-rs/crates/ui/src/select.rs @@ -1273,7 +1273,7 @@ impl Select { let app = select.0.cx.app.clone(); app.defer(move |_cx| select.move_index(index, false, true)); } - MouseEventKind::Up(_) => { + MouseEventKind::Up(MouseButton::Left) => { let Some(index) = index else { return }; let option = { let state = select.0.state.borrow(); diff --git a/packages/cli-rs/crates/ui/tests/all/dialogs.rs b/packages/cli-rs/crates/ui/tests/all/dialogs.rs index e3e9cbc8ee5..e78f3cc6897 100644 --- a/packages/cli-rs/crates/ui/tests/all/dialogs.rs +++ b/packages/cli-rs/crates/ui/tests/all/dialogs.rs @@ -652,6 +652,13 @@ fn clicks_select_rows_and_the_backdrop_closes_the_dialog() { let row = (0..30u16) .find(|&y| screen.row(y as u32).contains("Claude Opus")) .unwrap(); + // A right button's release over a row does not choose it. + kit.app + .mouse(MouseEventKind::Down(MouseButton::Right), 20, row); + kit.app + .mouse(MouseEventKind::Up(MouseButton::Right), 20, row); + kit.app.advance(Duration::from_millis(1)); + assert!(chosen.borrow().is_empty(), "{:?}", chosen.borrow()); kit.app.click(20, row); assert_eq!(*chosen.borrow(), ["opus"]); assert!(kit.dialogs.is_open());