From 95d8e4a69308c6cfb3b0e2ccac9908c7604588e0 Mon Sep 17 00:00:00 2001 From: usrnk1 <7547651+usrnk1@users.noreply.github.com> Date: Wed, 21 Oct 2026 14:20:48 +0200 Subject: [PATCH] fix(app): keep extension row heights consistent (#57773) --- packages/app/e2e/regression/settings.spec.ts | 26 ++++++++++++++++++++ packages/app/src/settings/settings.css | 2 +- 2 files changed, 27 insertions(+), 1 deletion(-) diff --git a/packages/app/e2e/regression/settings.spec.ts b/packages/app/e2e/regression/settings.spec.ts index 5f8f1c465ad..5eb5d2fc71f 100644 --- a/packages/app/e2e/regression/settings.spec.ts +++ b/packages/app/e2e/regression/settings.spec.ts @@ -634,6 +634,32 @@ test("the new session shortcut waits for a shortcut recording, then leaves setti await expect(page.locator('[data-titlebar-tab][data-active="true"]')).toHaveCount(1) }) +test("single extension rows stay aligned when switching tabs", async ({ page }) => { + const { settings } = await open(page, { + mcp: [{ name: "demo-mcp", status: { status: "connected" } }], + plugins: [{ id: "demo-plugin", source: { type: "package", target: "demo-plugin" } }], + skills: [{ name: "demo-skill", description: "Demo skill", path: "/skills/demo/SKILL.md" }], + }) + await settings.getByRole("tab", { name: "Extensions", exact: true }).click() + await expect(settings.getByRole("switch", { name: "demo-mcp", exact: true })).toBeChecked() + const mcp = settings.getByRole("tabpanel", { name: "MCPs", exact: true }).locator(".settings-extension-row") + await expect(mcp).toHaveCount(1) + const bounds = await mcp.boundingBox() + expect(bounds).not.toBeNull() + + for (const item of [ + { tab: "Plugins", name: "demo-plugin" }, + { tab: "Skills", name: "demo-skill" }, + ]) { + await settings.getByRole("tab", { name: item.tab, exact: true }).click() + const panel = settings.getByRole("tabpanel", { name: item.tab, exact: true }) + await expect(panel.getByText(item.name, { exact: true })).toBeVisible() + const row = panel.locator(".settings-extension-row") + await expect(row).toHaveCount(1) + await expect.poll(() => row.boundingBox()).toEqual(bounds) + } +}) + test.describe("pages open before slow data", () => { test("worktrees", async ({ page }) => { const { settings } = await open(page) diff --git a/packages/app/src/settings/settings.css b/packages/app/src/settings/settings.css index 79392c84720..747b2fb7325 100644 --- a/packages/app/src/settings/settings.css +++ b/packages/app/src/settings/settings.css @@ -2126,6 +2126,7 @@ .settings-extension-row { display: flex; + min-height: 56px; align-items: center; justify-content: space-between; gap: 12px; @@ -2155,7 +2156,6 @@ } .settings-mcp-row { - min-height: 56px; gap: 16px; }