From 96c5c3a11aae18fb2364be85802788086587e451 Mon Sep 17 00:00:00 2001 From: xjh <87483213+xiajiahang@users.noreply.github.com> Date: Fri, 30 Oct 2026 10:40:05 +0800 Subject: [PATCH] fix(codemode): preserve null in text encoding (#57639) --- packages/codemode/src/stdlib/bytes.ts | 6 +++++- packages/codemode/test/stdlib.test.ts | 9 +++++++++ 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/packages/codemode/src/stdlib/bytes.ts b/packages/codemode/src/stdlib/bytes.ts index eb8586436ec..b7989a1cba1 100644 --- a/packages/codemode/src/stdlib/bytes.ts +++ b/packages/codemode/src/stdlib/bytes.ts @@ -220,7 +220,11 @@ export const textEncoderGlobal = (ctx: Interpreter) => { const encoder = new TextEncoder() defineAccessor(proto, "encoding", () => "utf-8") methods(builtins, proto, [ - ["encode", 0, (_, args) => new Bytes(builtins.Uint8Array, encoder.encode(coerceToString(args[0] ?? "")))], + [ + "encode", + 0, + (_, args) => new Bytes(builtins.Uint8Array, encoder.encode(coerceToString(args[0] === undefined ? "" : args[0]))), + ], ]) return constructor(builtins, proto, { name: "TextEncoder", diff --git a/packages/codemode/test/stdlib.test.ts b/packages/codemode/test/stdlib.test.ts index c3a5e9ebd75..9c0d01672cc 100644 --- a/packages/codemode/test/stdlib.test.ts +++ b/packages/codemode/test/stdlib.test.ts @@ -1176,6 +1176,15 @@ describe("Uint8Array", () => { }) describe("TextEncoder and TextDecoder", () => { + test("encodes null as text while omitted and undefined inputs stay empty", async () => { + expect( + await value(` + const encoder = new TextEncoder() + return [[...encoder.encode(null)], [...encoder.encode()], [...encoder.encode(undefined)]] + `), + ).toEqual([[110, 117, 108, 108], [], []]) + }) + test("round-trips UTF-8 and exposes the standard fields", async () => { expect( await value(`