From 9d97a5beec54fab093644db9408c405459e065a4 Mon Sep 17 00:00:00 2001 From: Kit Langton Date: Sat, 17 Oct 2026 14:37:05 -0700 Subject: [PATCH] fix(console): send localized changelog URLs to the changelog worker (#56531) --- packages/console/app/src/lib/language.ts | 2 ++ packages/console/app/src/middleware.ts | 2 ++ packages/console/app/src/routes/changelog/index.tsx | 2 -- packages/console/app/test/language.test.ts | 13 +++++++++++++ 4 files changed, 17 insertions(+), 2 deletions(-) create mode 100644 packages/console/app/test/language.test.ts diff --git a/packages/console/app/src/lib/language.ts b/packages/console/app/src/lib/language.ts index a196f663db4..f1cf695acc4 100644 --- a/packages/console/app/src/lib/language.ts +++ b/packages/console/app/src/lib/language.ts @@ -209,6 +209,8 @@ export function route(locale: Locale, pathname: string) { if (next.startsWith("/docs")) return docs(locale, next) if (next.startsWith("/auth")) return next if (next.startsWith("/workspace")) return next + // The changelog worker owns /changelog and only publishes English release notes. + if (next === "/changelog" || next.startsWith("/changelog/")) return next if (locale === "en") return next if (next === "/") return `/${locale}` return `/${locale}${next}` diff --git a/packages/console/app/src/middleware.ts b/packages/console/app/src/middleware.ts index 323038955f8..e9fb86548e9 100644 --- a/packages/console/app/src/middleware.ts +++ b/packages/console/app/src/middleware.ts @@ -11,6 +11,8 @@ export default createMiddleware({ const locale = fromPathname(url.pathname) if (locale) { url.pathname = strip(url.pathname) + if (/^\/changelog\/?$/.test(url.pathname)) + return new Response(null, { status: 301, headers: { Location: "/changelog" } }) const request = new Request(url, event.request) request.headers.set(LOCALE_HEADER, locale) event.request = request diff --git a/packages/console/app/src/routes/changelog/index.tsx b/packages/console/app/src/routes/changelog/index.tsx index 54f037479aa..21c4c6ec7cb 100644 --- a/packages/console/app/src/routes/changelog/index.tsx +++ b/packages/console/app/src/routes/changelog/index.tsx @@ -9,7 +9,6 @@ import type { HighlightGroup } from "~/lib/changelog" import { For, Show, createSignal } from "solid-js" import { useI18n } from "~/context/i18n" import { useLanguage } from "~/context/language" -import { LocaleLinks } from "~/component/locale-links" function formatDate(dateString: string, locale: string) { const date = new Date(dateString) @@ -107,7 +106,6 @@ export default function Changelog() { return (
{i18n.t("changelog.title")} -
diff --git a/packages/console/app/test/language.test.ts b/packages/console/app/test/language.test.ts new file mode 100644 index 00000000000..100361ba601 --- /dev/null +++ b/packages/console/app/test/language.test.ts @@ -0,0 +1,13 @@ +import { describe, expect, test } from "bun:test" +import { route } from "../src/lib/language" + +describe("language.route", () => { + test("keeps the changelog unprefixed for every locale", () => { + expect(route("de", "/changelog")).toBe("/changelog") + expect(route("zh", "/zh/changelog")).toBe("/changelog") + }) + + test("prefixes other marketing pages", () => { + expect(route("de", "/download")).toBe("/de/download") + }) +})