From bfe9917ee795264545ec05c14c6ae17b7b9e6c93 Mon Sep 17 00:00:00 2001 From: "opencode-agent[bot]" <219766164+opencode-agent[bot]@users.noreply.github.com> Date: Wed, 19 Aug 2026 10:03:03 -0500 Subject: [PATCH] fix(core): lower AI SDK system updates (#43440) Co-authored-by: rekram1-node --- packages/core/src/aisdk.ts | 15 ++++++++++++- packages/core/test/aisdk.test.ts | 37 ++++++++++++++++++++++++++++++++ 2 files changed, 51 insertions(+), 1 deletion(-) diff --git a/packages/core/src/aisdk.ts b/packages/core/src/aisdk.ts index 24d2d57860a..7f1906c8e22 100644 --- a/packages/core/src/aisdk.ts +++ b/packages/core/src/aisdk.ts @@ -460,7 +460,20 @@ function prompt(request: LLMRequest): LanguageModelV3Prompt { function message(input: LLMRequest["messages"][number]): LanguageModelV3Message[] { switch (input.role) { case "system": - return [{ role: "system", content: input.content.flatMap(text).join("\n\n") }] + // The initial privileged prompt lives in `request.system` and is prepended above. A system message here is a + // chronological instruction update, but opaque AI SDK providers do not uniformly allow the system role after + // conversation history, so preserve its position using the safe wrapped-user fallback. + return [ + { + role: "user", + content: [ + { + type: "text", + text: ProviderShared.wrapSystemUpdate(input.content.filter((part) => part.type === "text")), + }, + ], + }, + ] case "user": return [{ role: "user", content: input.content.flatMap(userPart) }] case "assistant": diff --git a/packages/core/test/aisdk.test.ts b/packages/core/test/aisdk.test.ts index c68fe3eaec2..7f3a3f0d785 100644 --- a/packages/core/test/aisdk.test.ts +++ b/packages/core/test/aisdk.test.ts @@ -104,6 +104,43 @@ it.effect("projects request settings, headers, and body overlays", () => }), ) +it.effect("lowers chronological system updates to wrapped user messages", () => + Effect.gen(function* () { + const aisdk = yield* AISDK.Service + yield* aisdk.hook.sdk((event) => { + event.sdk = { languageModel: () => ({ provider: event.model.providerID }) } + }) + + const resolved = yield* aisdk.model(model("opaque-provider")) + const prepared = yield* compileRequest( + LLM.request({ + model: resolved, + system: "Initial instructions.", + messages: [ + Message.user("Before."), + Message.system("Updated & constraints."), + Message.assistant("After."), + ], + }), + ) + + expect(prepared.body.prompt).toEqual([ + { role: "system", content: "Initial instructions." }, + { role: "user", content: [{ type: "text", text: "Before." }] }, + { + role: "user", + content: [ + { + type: "text", + text: "\nUpdated <rules> & constraints.\n", + }, + ], + }, + { role: "assistant", content: [{ type: "text", text: "After." }] }, + ]) + }), +) + it.effect("leaves max output tokens unset when the request omits them", () => Effect.gen(function* () { const aisdk = yield* AISDK.Service