From c3a73eca343b1868b0b5706771bbd7b26f6d4fab Mon Sep 17 00:00:00 2001 From: "opencode-agent[bot]" <219766164+opencode-agent[bot]@users.noreply.github.com> Date: Fri, 16 Oct 2026 13:42:50 +0000 Subject: [PATCH] fix(cli): don't crash auth login when no browser opener is available (#56082) Co-authored-by: thdxr --- packages/cli/src/ui/prompt.ts | 3 ++- packages/cli/test/prompt-open-url.test.ts | 8 ++++++++ 2 files changed, 10 insertions(+), 1 deletion(-) create mode 100644 packages/cli/test/prompt-open-url.test.ts diff --git a/packages/cli/src/ui/prompt.ts b/packages/cli/src/ui/prompt.ts index 3c54c2202eb..648037956bd 100644 --- a/packages/cli/src/ui/prompt.ts +++ b/packages/cli/src/ui/prompt.ts @@ -17,7 +17,8 @@ export function requireInteractive(message: string) { export const openUrl = Effect.fn("cli.prompt.open-url")(function* (url: string) { const browser = yield* Effect.promise(() => import("@opencode/util/open")) - yield* Effect.promise(() => browser.openUrl(url)).pipe(Effect.ignore) + // Best effort: headless environments may lack a browser opener, and the caller already printed the URL. + yield* Effect.tryPromise(() => browser.openUrl(url)).pipe(Effect.ignore) }) export function handlePromptErrors(effect: Effect.Effect) { diff --git a/packages/cli/test/prompt-open-url.test.ts b/packages/cli/test/prompt-open-url.test.ts new file mode 100644 index 00000000000..5565e66a485 --- /dev/null +++ b/packages/cli/test/prompt-open-url.test.ts @@ -0,0 +1,8 @@ +import { expect, test } from "bun:test" +import { Effect, Exit } from "effect" +import { openUrl } from "../src/ui/prompt" + +test("suppresses browser open failures so the printed URL stays usable", async () => { + const exit = await Effect.runPromiseExit(openUrl("not-a-browser-url")) + expect(Exit.isSuccess(exit)).toBe(true) +})