fix(plugin): forward Promise tool cancellation (#50190)

This commit is contained in:
Aiden Cline
2026-09-20 11:22:49 -05:00
committed by GitHub
Unverified
parent 6238af397e
commit e3a3fa7108
4 changed files with 74 additions and 6 deletions
+8 -6
View File
@@ -250,12 +250,13 @@ export function fromPromise(plugin: Plugin) {
const promiseExecutor =
(execute: Tool.Info["execute"]): Info["execute"] =>
(input, context) =>
run(
(input, tool) =>
Effect.runPromiseWith(context)(
execute(input, {
...context,
progress: (update) => Effect.promise(() => context.progress(update)),
...tool,
progress: (update) => Effect.promise(() => tool.progress(update)),
}),
{ signal: tool.signal },
)
const adaptApiMethod = <PromiseMethod>(
@@ -612,9 +613,10 @@ function attempt<A>(evaluate: (signal: AbortSignal) => PromiseLike<A>) {
type RuntimeSchema = Schema.Codec<unknown, unknown>
const executePromiseTool = (tool: Info, input: any, context: Tool.Context) =>
Effect.promise(() =>
Effect.promise((signal) =>
tool.execute(input, {
...context,
progress: (update) => Effect.runPromise(context.progress(update)),
signal,
progress: (update) => Effect.runPromise(context.progress(update), { signal }),
}),
)
+1
View File
@@ -9,6 +9,7 @@ import type { Types } from "effect"
import type { Hooks, Transform } from "./registration.js"
export interface ToolContext extends Omit<Tool.Context, "progress"> {
readonly signal: AbortSignal
readonly progress: (update: Tool.Metadata) => Promise<void>
}