From f7d5b6ffc48223e654b20043a500d315e4bc8053 Mon Sep 17 00:00:00 2001 From: "opencode-agent[bot]" <219766164+opencode-agent[bot]@users.noreply.github.com> Date: Thu, 22 Oct 2026 18:17:40 +0800 Subject: [PATCH] fix(app): paste plain text when renaming session tabs (#58036) Co-authored-by: Brendonovich <14191578+Brendonovich@users.noreply.github.com> --- packages/app/e2e/regression/session-header.spec.ts | 4 ++-- packages/app/e2e/regression/tabs.spec.ts | 2 +- packages/app/src/shell/commands/search-keydown.ts | 2 +- packages/app/src/shell/titlebar/tab-nav.tsx | 2 +- packages/app/src/shell/titlebar/tab-strip.tsx | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/packages/app/e2e/regression/session-header.spec.ts b/packages/app/e2e/regression/session-header.spec.ts index 63c63d82ad8..f9fc8e0db41 100644 --- a/packages/app/e2e/regression/session-header.spec.ts +++ b/packages/app/e2e/regression/session-header.spec.ts @@ -217,7 +217,7 @@ test.describe("rename", () => { await expect(tab).toBeFocused() await tab.press("Shift+F10") await page.getByRole("menuitem", { name: "Rename", exact: true }).click() - const input = page.locator('[data-slot="tab-title"][contenteditable="true"]') + const input = page.locator('[data-slot="tab-title"][contenteditable="plaintext-only"]') await expect(input).toBeFocused() await input.fill("Renamed from tab") await input.press("Enter") @@ -241,7 +241,7 @@ test.describe("rename", () => { await expect(heading(page, fixture.expected.sourceTitle)).toBeVisible() await tabs(page).filter({ hasText: fixture.expected.targetTitle }).click({ button: "right" }) await page.getByRole("menuitem", { name: "Rename", exact: true }).click() - const input = page.locator('[data-slot="tab-title"][contenteditable="true"]') + const input = page.locator('[data-slot="tab-title"][contenteditable="plaintext-only"]') await expect(input).toBeFocused() await input.fill("Inactive tab renamed") await input.press("Tab") diff --git a/packages/app/e2e/regression/tabs.spec.ts b/packages/app/e2e/regression/tabs.spec.ts index 9d1c75a4066..7bedf7648c3 100644 --- a/packages/app/e2e/regression/tabs.spec.ts +++ b/packages/app/e2e/regression/tabs.spec.ts @@ -125,7 +125,7 @@ test("a tab does not reopen its title editor while a rename is saving", async ({ await mockWorkspace(page, { name: "Tabs", sessions: [a, b] }) await page.goto(sessionHref(a.id)) const title = page.locator(`[data-titlebar-tab-slot]:has(a[href="${sessionHref(a.id)}"]) [data-slot="tab-title"]`) - const editor = page.locator('[data-slot="tab-title"][contenteditable="true"]') + const editor = page.locator('[data-slot="tab-title"][contenteditable="plaintext-only"]') await expect(title).toHaveText(a.title) const save = await holdRoute(page, (url) => url.pathname === `/api/session/${a.id}`, { method: "PATCH" }) diff --git a/packages/app/src/shell/commands/search-keydown.ts b/packages/app/src/shell/commands/search-keydown.ts index cd2f2f7110a..21375919be5 100644 --- a/packages/app/src/shell/commands/search-keydown.ts +++ b/packages/app/src/shell/commands/search-keydown.ts @@ -1,4 +1,4 @@ -const editableSelector = "input, textarea, select, [contenteditable=''], [contenteditable='true']" +const editableSelector = "input, textarea, select, [contenteditable=''], [contenteditable='true'], [contenteditable='plaintext-only']" export function handleDocumentSearchKeydown( input: HTMLInputElement | undefined, diff --git a/packages/app/src/shell/titlebar/tab-nav.tsx b/packages/app/src/shell/titlebar/tab-nav.tsx index 77088bf90de..7d903252292 100644 --- a/packages/app/src/shell/titlebar/tab-nav.tsx +++ b/packages/app/src/shell/titlebar/tab-nav.tsx @@ -328,7 +328,7 @@ export function TabNavItem(props: { "overflow-hidden text-clip whitespace-nowrap": !editing(), "select-text": editing(), }} - contenteditable={editing() ? true : undefined} + contenteditable={editing() ? "plaintext-only" : undefined} onDblClick={openRename} onKeyDown={(event) => { event.stopPropagation() diff --git a/packages/app/src/shell/titlebar/tab-strip.tsx b/packages/app/src/shell/titlebar/tab-strip.tsx index 884918efb44..11a08b6e229 100644 --- a/packages/app/src/shell/titlebar/tab-strip.tsx +++ b/packages/app/src/shell/titlebar/tab-strip.tsx @@ -364,7 +364,7 @@ export function TitlebarTabStrip(props: { : [new PointerActivationConstraints.Distance({ value: 4 })], preventActivation: (event) => event.target instanceof Element && - !!event.target.closest('[data-slot="tab-close"], [contenteditable="true"]'), + !!event.target.closest('[data-slot="tab-close"], [contenteditable="true"], [contenteditable="plaintext-only"]'), }), ]} modifiers={[