27 Commits

  • anisette: fix crash in date formatter (#422)
    ## What does this PR do?
    
    Password login can terminate with an illegal-instruction crash on Linux,
    leaving the user logged out. Anisette client time was formatted with
    DateFormatter and an explicitly assigned Gregorian calendar. That
    formatting path reaches Foundation’s NSCalendar bridging code, where the
    reported crash occurs.
    
    AnisetteData now formats client time with Date.ISO8601FormatStyle,
    avoiding the DateFormatter calendar bridge. The header retains its UTC
    timestamp format with whole seconds and a trailing Z. New parameterized
    tests check the complete header dictionary for the Unix epoch, a year
    boundary, leap day, and a timestamp with fractional seconds.
    
    Fixes #184
    
    ## How was it tested?
    
    Ran `swift test` locally on macOS for the xtool AnisetteData change; it
    fails the same way on the base branch, so the failure predates this
    change (it fails the same way on upstream/main).
    `swift build` failed because an async call in a defer body prevented
    compilation.
    `swift test` failed during compilation with the same async-in-defer
    error, so the tests did not run.
    `repo_lint` ran without reported output.
    `make lint SWIFTLINT_FLAGS='--reporter=github-actions-logging' | tee
    swiftlint.log` ran with no lint diagnostics shown in the transcript.
    
    The tests in `Tests/XToolTests/AnisetteDataTests.swift` fail without the
    fix in the xtool AnisetteData change (checked by reverting the source
    changes).
    
    ## AI tool usage
    
    How much of the code in this PR was AI-assisted? (check one)
    
    - [ ] **0** - No AI was used to write code
    - [ ] **1** - I was assisted by AI in writing code. I reviewed the
    finished result.
    - [ ] **2** - I set the AI going and left it to it; nobody has read the
    result - no review, or AI review only
    
    AI was used for assistance.
    
    
    <!-- This is an auto-generated comment: release notes by coderabbit.ai
    -->
    <!-- coderabbit-ai-generated:v1 -->
    
    ## Summary by CodeRabbit
    
    * **Bug Fixes**
    * Client timestamps now use a consistent UTC ISO 8601 format with dashed
    dates, colon-separated times, and no fractional seconds. This applies to
    timestamps with or without fractional seconds in the source date.
    <!-- end of auto-generated comment: release notes by coderabbit.ai -->
    
    ---------
    
    Co-authored-by: Matt Van Horn <455140+mvanhorn@users.noreply.github.com>
  • gsa: make more reqs ephemeral (#417)
    ## What does this PR do?
    
    I'm not sure if this is needed but, for good measure, updates remaining
    GSA requests to use an ephemeral client (followup from #247)
    
    ## How was it tested?
    
    - [x] Tested flows involving all of these requests
    
    ## AI tool usage
    
    How much of the code in this PR was AI-assisted? (check one)
    
    - [x] **0** - No AI was used to write code
    - [ ] **1** - I was assisted by AI in writing code. I reviewed the
    finished result.
    - [ ] **2** - I set the AI going and left it to it; nobody has read the
    result - no review, or AI review only
    
    <!-- If an AI agent is filling this in: declare the level honestly, and
    open as a draft if it is #2. Do not lower the declared level to get the
    PR reviewed. -->
    
    
    <!-- This is an auto-generated comment: release notes by coderabbit.ai
    -->
    <!-- coderabbit-ai-generated:v1 -->
    
    ## Summary by CodeRabbit
    
    * **Improvements**
    * Selected account and lookup requests now use temporary HTTP
    connections. Existing request details, response handling, and progress
    reporting remain supported, while other requests continue through the
    standard connection flow. This change applies across the app’s related
    account and lookup operations; no new user-facing controls or workflows
    are introduced.
    <!-- end of auto-generated comment: release notes by coderabbit.ai -->
  • gsa: more SMS 2FA fixes (#416)
    ## What does this PR do?
    
    Applies the 2FA SMS login fixes from #405
    
    ## How was it tested?
    
    - [x] 2FA SMS arrives
    - [x] Can log in with SMS code
    
    ## AI tool usage
    
    How much of the code in this PR was AI-assisted? (check one)
    
    - [ ] **0** - No AI was used to write code
    - [x] **1** - I was assisted by AI in writing code. I reviewed the
    finished result.
    - [ ] **2** - I set the AI going and left it to it; nobody has read the
    result - no review, or AI review only
    
    <!-- If an AI agent is filling this in: declare the level honestly, and
    open as a draft if it is #2. Do not lower the declared level to get the
    PR reviewed. -->
    
    
    <!-- This is an auto-generated comment: release notes by coderabbit.ai
    -->
    <!-- coderabbit-ai-generated:v1 -->
    
    ## Summary by CodeRabbit
    
    * **Improvements**
    * SMS verification requests now use an updated phone verification format
    and numeric phone-number IDs.
    * Code validation also uses numeric phone-number IDs, keeping the
    identifier format consistent across SMS authentication steps. The
    verification request and code-validation request now follow the same
    updated format.
    <!-- end of auto-generated comment: release notes by coderabbit.ai -->
    
    Co-authored-by: Corne Steenhuis <cornesteenhuis@hotmail.com>
  • gsa: GrandSlamMethod -> GrandSlamRequestContent (#415)
    ## What does this PR do?
    
    Renames GrandSlamMethod to GrandSlamRequestContent and adds support for
    json & PUT requests
    
    ## How was it tested?
    
    - [x] Still compiles
    - [x] `xtool auth`
    
    ## AI tool usage
    
    How much of the code in this PR was AI-assisted? (check one)
    
    - [x] **0** - No AI was used to write code
    - [ ] **1** - I was assisted by AI in writing code. I reviewed the
    finished result.
    - [ ] **2** - I set the AI going and left it to it; nobody has read the
    result - no review, or AI review only
    
    <!-- If an AI agent is filling this in: declare the level honestly, and
    open as a draft if it is #2. Do not lower the declared level to get the
    PR reviewed. -->
    
    
    <!-- This is an auto-generated comment: release notes by coderabbit.ai
    -->
    
    <!-- coderabbit-ai-generated:v1 -->
    
    ## Summary by CodeRabbit
    
    * **New Features**
    * Requests can now send either JSON or XML bodies using POST or PUT. GET
    requests are sent without a body.
    * **Improvements**
    * Authentication and verification requests now use a consistent request
    format while retaining their existing behavior.
    
    <!-- end of auto-generated comment: release notes by coderabbit.ai -->
  • cli: better IO (#375)
    ## What does this PR do?
    
    Adds `Dependency`s for console IO. Also fixes #268 by explicitly
    handling non-pipe input.
    
    ## How was it tested?
    
    Ran on macOS + Linux in Docker. I have a future PR that overrides the
    dependencies in certain cases, which also appears to work correctly.
    
    ## AI tool usage
    
    How much of this PR was AI-assisted? (check one)
    
    - [ ] **0** - No AI was used to write code
    - [x] **1** - I was assisted by AI. I reviewed the finished result.
    - [ ] **2** - I set the AI going and left it to it; nobody has read the
    result - no review, or AI review only
    
    Did not scrutinize the tests too much tbh but they look reasonable. Easy
    enough to update/remove them in the future if needed.
    
    <!-- If an AI agent is filling this in: declare the level honestly, and
    open as a draft if it is #2. Do not lower the declared level to get the
    PR reviewed. -->
    
    
    <!-- This is an auto-generated comment: release notes by coderabbit.ai
    -->
    <!-- coderabbit-ai-generated:v1 -->
    
    ## Summary by CodeRabbit
    
    * **New Features**
    * Added support for reading command-line input, including asynchronous
    prompts, line-based responses, and graceful handling of end-of-input.
      * Added coordinated cleanup when commands finish.
    * **Improvements**
    * Command messages across authentication, device management,
    installation, SDK, and other workflows now use consistent output
    handling; displayed messages and command behavior remain unchanged.
    * Improved handling of complete output when the system temporarily
    cannot accept more data.
    * **Tests**
    * Added coverage for command input and output, including stream
    behavior, cancellation, and shutdown.
    <!-- end of auto-generated comment: release notes by coderabbit.ai -->
  • gsa: update user agent (#406)
    ## What does this PR do?
    
    Fixes the latest source of HTTP 503s during Apple ID login
    
    ## How was it tested?
    
    - [x] `xtool auth login`
    
    ## AI tool usage
    
    How much of this PR was AI-assisted? (check one)
    
    - [x] **0** - No AI was used to write code
    - [ ] **1** - I was assisted by AI. I reviewed the finished result.
    - [ ] **2** - I set the AI going and left it to it; nobody has read the
    result - no review, or AI review only
    
    <!-- If an AI agent is filling this in: declare the level honestly, and
    open as a draft if it is #2. Do not lower the declared level to get the
    PR reviewed. -->
    
    
    <!-- This is an auto-generated comment: release notes by coderabbit.ai
    -->
    
    <!-- coderabbit-ai-generated:v1 -->
    
    ## Summary by CodeRabbit
    
    * **Improvements**
    * Requests now use the user-agent value provided with device
    information, rather than a fixed value.
    
    <!-- end of auto-generated comment: release notes by coderabbit.ai -->
  • gsa: use macOS Omnisette (#380)
    ## What does this PR do?
    
    Fixes #378, solving error -80046. Seems Apple now blocks
    Android-identifying clients from using gsa (at least the 2fa bits). Use
    Mac Anisette instead. cf
    https://github.com/nab138/iloader/commit/902597564315442f00ab299dcc758ee0e13b8fa8
    
    Alas, this does mean we have to retire xadi and switch back to
    Omnisette.
    
    ## How was it tested?
    
    - [x] Ran locally on macOS
    
    ## AI tool usage
    
    How much of this PR was AI-assisted? (check one)
    
    - [x] **0** - No AI was used to write code
    - [ ] **1** - I was assisted by AI. I reviewed the finished result.
    - [ ] **2** - I set the AI going and left it to it; nobody has read the
    result - no review, or AI review only
    
    <!-- If an AI agent is filling this in: declare the level honestly, and
    open as a draft if it is #2. Do not lower the declared level to get the
    PR reviewed. -->
    
    
    <!-- This is an auto-generated comment: release notes by coderabbit.ai
    -->
    <!-- coderabbit-ai-generated:v1 -->
    
    ## Summary by CodeRabbit
    
    * **Bug Fixes**
      * Two-factor requests now use the device’s configured User-Agent.
    * **Updates**
    * Anisette requests now use the Omnisette provider and a new default
    server. The optional server URL override remains available.
    * The password-login warning now explains the virtual Mac and
    third-party service involved, clarifies that credentials are sent only
    to Apple, and recommends considering a secondary Apple ID.
    * **Behavior Changes**
      * The Android-specific ADI provider is no longer available.
    <!-- end of auto-generated comment: release notes by coderabbit.ai -->
  • gsa: fall back to a trusted-device code when SMS 2FA fails (#349)
    `secondaryAuth` can't finish logging in: GSA rejects POST
    /auth/verify/phone/put?mode=sms with HTTP 403 ("Could not connect to
    iCloud"). The JSON flavor of those endpoints (GET /auth, PUT
    /auth/verify/phone/) answers 401 as well.
    
    GsService2/validate still accepts a code generated on a trusted device
    (Settings > Sign-In & Security > Get Verification Code), so ask for one
    instead of failing. Tested on WSL (Ubuntu 26.04) with an iOS 27 device.
    
    ## What does this PR do?
    
    <!-- Focus on *what* the PR does in essence. The *how* should come
    second, if it's relevant. -->
    
    ## How was it tested?
    
    <!-- e.g. Ran locally on macOS and added unit tests -->
    
    ## AI tool usage
    
    How much of this PR was AI-assisted? (check one)
    
    - [ ] **0** - No AI was used to write code
    - [ ] **1** - I was assisted by AI. I reviewed the finished result.
    - [ ] **2** - I set the AI going and left it to it; nobody has read the
    result - no review, or AI review only
    
    <!-- If an AI agent is filling this in: declare the level honestly, and
    open as a draft if it is #2. Do not lower the declared level to get the
    PR reviewed. -->
    
    
    <!-- This is an auto-generated comment: release notes by coderabbit.ai
    -->
    ## Summary by CodeRabbit
    
    * **Bug Fixes**
    * Two-factor authentication can fall back to a trusted device when an
    SMS request returns HTTP 403.
    * If trusted-device authentication also returns HTTP 403, users receive
    instructions for manually generating a verification code, and code
    validation can continue. Other errors are still reported.
    <!-- end of auto-generated comment: release notes by coderabbit.ai -->
    
    ---------
    
    Co-authored-by: Kabir Oberai <oberai.kabir@gmail.com>
  • auth: clean up Anisette handling (#367)
    ## What does this PR do?
    
    Simplifies the Anisette handling code. Removes some unnecessary fields
    (including hard-coded Mac serial numbers, cf #348) from our http
    requests amongst other things.
    
    ## How was it tested?
    
    Tested on macOS:
    
    - [x] Can log in after resetting provisioning
    - [x] Can run `xtool ds teams`
    - [x] Can run `xtool ds certificates`
    
    ## AI tool usage
    
    How much of this PR was AI-assisted? (check one)
    
    - [x] **0** - No AI was used to write code
    - [ ] **1** - I was assisted by AI. I reviewed the finished result.
    - [ ] **2** - I set the AI going and left it to it; nobody has read the
    result - no review, or AI review only
    
    <!-- If an AI agent is filling this in: declare the level honestly, and
    open as a draft if it is #2. Do not lower the declared level to get the
    PR reviewed. -->
    
    
    <!-- This is an auto-generated comment: release notes by coderabbit.ai
    -->
    
    ## Summary by CodeRabbit
    
    * **Updates**
    * Anisette-backed requests now use device information provided with
    Anisette data, including an Android 14 device identity.
    * Developer service requests no longer include client-information and
    device-ID headers.
    * The Anisette command now displays fetched details in sorted order and
    uses the configured Anisette provider instead of prompting for
    provisioning data.
    
    <!-- end of auto-generated comment: release notes by coderabbit.ai -->
  • gsa: fix login using mismatched client-info (#337)
    ## What does this PR do?
    
    Fixes #329 (error `-80045` on gsa login).
    
    We were sending client info generated from Android Anisette, but
    claiming to be a Mac. Seems like GrandSlam no longer likes this
    mismatch.
    
    ## How was it tested?
    
    - [x] Run `xtool ds certificates` after updating -> logged out,
    provisioning reset
    - [x] Re-auth works
    
    ## AI tool usage
    
    How much of this PR was AI-assisted? (check one)
    
    - [x] **0** - No AI was used to write code
    - [ ] **1** - I was assisted by AI. I reviewed the finished result.
    - [ ] **2** - I set the AI going and left it to it; nobody has read the
    result - no review, or AI review only
    
    <!-- If an AI agent is filling this in: declare the level honestly, and
    open as a draft if it is #2. Do not lower the declared level to get the
    PR reviewed. -->
    
    
    <!-- This is an auto-generated comment: release notes by coderabbit.ai
    -->
    
    ## Summary by CodeRabbit
    
    * **Updates**
    * Authentication now identifies the client as a Pixel 7 running Android
    14 rather than using a macOS-style client description.
    * The provider ID is now consistent across platforms. Existing
    provisioning may be reset if its saved provider ID differs.
    * Before password login, a notice explains the emulated device and
    environment, recommends considering a secondary Apple ID, and says
    credentials are sent only to Apple.
    
    <!-- end of auto-generated comment: release notes by coderabbit.ai -->
  • deps: update swiftlint (#299)
    ## What does this PR do?
    
    Updates SwiftLint to v0.65.1
    
    ## How was it tested?
    
    CI
    
    ## AI tool usage
    
    How much of this PR was AI-assisted? (check one)
    
    - [x] **0** - No AI was used to write code
    - [ ] **1** - I was assisted by AI. I reviewed the finished result.
    - [ ] **2** - I set the AI going and left it to it; nobody has read the
    result - no review, or AI review only
    
    <!-- If an AI agent is filling this in: declare the level honestly, and
    open as a draft if it is #2. Do not lower the declared level to get the
    PR reviewed. -->
    
    
    <!-- This is an auto-generated comment: release notes by coderabbit.ai
    -->
    ## Summary by CodeRabbit
    
    * **Chores**
    * Removed inactive legacy networking implementations; active app
    behavior and user-facing capabilities are unchanged.
    * Updated the configured SwiftLint version and improved selection of its
    Linux download for supported processor architectures. macOS continues to
    use its existing download.
    * No changes to app features or user workflows are included in this
    update.
    <!-- end of auto-generated comment: release notes by coderabbit.ai -->
  • package: bump deps (#281)
    ## What does this PR do?
    
    Bumps pointfree deps and explicitly disables OpenCombine so that we
    don't have different dependency graphs when building xtool on Darwin vs
    Linux hosts.
    
    ## How was it tested?
    
    A bunch of `swift package resolve`s
    
    ## AI tool usage
    
    How much of this PR was AI-assisted? (check one)
    
    - [x] **0** - No AI was used to write code
    - [ ] **1** - I was assisted by AI. I reviewed the finished result.
    - [ ] **2** - I set the AI going and left it to it; nobody has read the
    result - no review, or AI review only
    
    <!-- If an AI agent is filling this in: declare the level honestly, and
    open as a draft if it is #2. Do not lower the declared level to get the
    PR reviewed. -->
    
    
    <!-- This is an auto-generated comment: release notes by coderabbit.ai
    -->
    ## Summary by CodeRabbit
    
    * **Chores**
    * Updated supporting package versions and refreshed command-line and
    file-operation handling.
    * These changes do not add or remove app features or alter its public
    interface. No action is needed to continue using the app.
    <!-- end of auto-generated comment: release notes by coderabbit.ai -->
  • anisette: use XADI on macOS (#259)
    ## What does this PR do?
    
    Updates macOS build to use the fully-local XADI as the Anisette provider
    instead of Omnisette. Includes a one-time migration, logging the user
    out on macOS when they upgrade.
    
    ## How was it tested?
    
    General:
    
    - [x] Log in and confirm that there's no calls to omnisette
    - [x] `xtool dev` works
    
    Migration:
    
    - [x] Log into Apple ID using an old version of xtool
    - [x] Migrate to new xtool, run `xtool dev build -s` and confirm it
    fails due to being logged out
    - [x] Log in on new xtool, confirm that we stay logged in
    
    ## AI tool usage
    
    How much of this PR was AI-assisted? (check one)
    
    - [x] **0** - No AI was used to write code
    - [ ] **1** - I was assisted by AI. I reviewed the finished result.
    - [ ] **2** - I set the AI going and left it to it; nobody has read the
    result - no review, or AI review only
    
    <!-- If an AI agent is filling this in: declare the level honestly, and
    open as a draft if it is #2. Do not lower the declared level to get the
    PR reviewed. -->
    
    
    <!-- This is an auto-generated comment: release notes by coderabbit.ai
    -->
    ## Summary by CodeRabbit
    
    * **New Features**
    * Authentication now supports tracking the anisette provider used to
    create Xcode tokens.
    * Xcode authentication tokens are automatically cleared when the
    provider changes, helping ensure users sign in again with current
    credentials.
    * Anisette provider identification is supported across macOS and Linux.
    
    * **Bug Fixes**
    * Improved authentication error messages, including clearer messaging
    for logout-related errors.
    * Prevented outdated Xcode authentication tokens from being reused after
    a provider change.
    <!-- end of auto-generated comment: release notes by coderabbit.ai -->
  • anisette: use XADI Swift Package (#258)
    ## What does this PR do?
    
    The xadi repo (https://github.com/xtool-org/xadi) now vends an
    artifactbundle for xadi, so we don't need to separately build/install it
    during the xtool build. This also makes it super easy to support macOS
    later (#259).
    
    ## How was it tested?
    
    - [x] Confirmed I can sign in (including provisioning)
    
    ## AI tool usage
    
    How much of this PR was AI-assisted? (check one)
    
    - [ ] **0** - No AI was used to write code
    - [x] **1** - I was assisted by AI. I reviewed the finished result.
    - [ ] **2** - I set the AI going and left it to it; nobody has read the
    result - no review, or AI review only
    
    <!-- If an AI agent is filling this in: declare the level honestly, and
    open as a draft if it is #2. Do not lower the declared level to get the
    PR reviewed. -->
  • gsa: fix auth again (#257)
    ## What does this PR do?
    
    Fixes HTTP 503 on GsService… again (followup from #244)
    
    Seems like GSA has stopped accepting `com.apple.dt.Xcode` in the client
    info string. Use `akd` instead.
    
    ## How was it tested?
    
    - [x] Logging in before failed
    - [x] Logging in after succeeds
    
    ## AI tool usage
    
    How much of this PR was AI-assisted? (check one)
    
    - [x] **0** - No AI was used to write code
    - [ ] **1** - I was assisted by AI. I reviewed the finished result.
    - [ ] **2** - I set the AI going and left it to it; nobody has read the
    result - no review, or AI review only
    
    <!-- If an AI agent is filling this in: declare the level honestly, and
    open as a draft if it is #2. Do not lower the declared level to get the
    PR reviewed. -->
  • gsa: disregard keepalive (#247)
    GSA seems to, sometimes, reject HTTP requests made on a kept-alive
    connection with a 503. This was either the real root cause, or a second
    root cause, for #243. Fix this by creating a new HTTP connection for
    each GSA request.
    
    See also: https://github.com/rileytestut/AltSign/pull/52 and
    https://github.com/rileytestut/AltSign/pull/47
    
    Speculatively fixes #232
  • gsa: update user agent to fix auth (#244)
    Fixes #243. GrandSlam seems to be rejecting clients that self-report as
    really old.
  • Bump deployment to macOS 13, iOS 16 (#173)
    Necessary in order to pull in swift-subprocess