## What does this PR do?
Applies the 2FA SMS login fixes from #405
## How was it tested?
- [x] 2FA SMS arrives
- [x] Can log in with SMS code
## AI tool usage
How much of the code in this PR was AI-assisted? (check one)
- [ ] **0** - No AI was used to write code
- [x] **1** - I was assisted by AI in writing code. I reviewed the
finished result.
- [ ] **2** - I set the AI going and left it to it; nobody has read the
result - no review, or AI review only
<!-- If an AI agent is filling this in: declare the level honestly, and
open as a draft if it is #2. Do not lower the declared level to get the
PR reviewed. -->
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
<!-- coderabbit-ai-generated:v1 -->
## Summary by CodeRabbit
* **Improvements**
* SMS verification requests now use an updated phone verification format
and numeric phone-number IDs.
* Code validation also uses numeric phone-number IDs, keeping the
identifier format consistent across SMS authentication steps. The
verification request and code-validation request now follow the same
updated format.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Co-authored-by: Corne Steenhuis <cornesteenhuis@hotmail.com>
## What does this PR do?
Renames GrandSlamMethod to GrandSlamRequestContent and adds support for
json & PUT requests
## How was it tested?
- [x] Still compiles
- [x] `xtool auth`
## AI tool usage
How much of the code in this PR was AI-assisted? (check one)
- [x] **0** - No AI was used to write code
- [ ] **1** - I was assisted by AI in writing code. I reviewed the
finished result.
- [ ] **2** - I set the AI going and left it to it; nobody has read the
result - no review, or AI review only
<!-- If an AI agent is filling this in: declare the level honestly, and
open as a draft if it is #2. Do not lower the declared level to get the
PR reviewed. -->
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
<!-- coderabbit-ai-generated:v1 -->
## Summary by CodeRabbit
* **New Features**
* Requests can now send either JSON or XML bodies using POST or PUT. GET
requests are sent without a body.
* **Improvements**
* Authentication and verification requests now use a consistent request
format while retaining their existing behavior.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
## What does this PR do?
Fixes the latest source of HTTP 503s during Apple ID login
## How was it tested?
- [x] `xtool auth login`
## AI tool usage
How much of this PR was AI-assisted? (check one)
- [x] **0** - No AI was used to write code
- [ ] **1** - I was assisted by AI. I reviewed the finished result.
- [ ] **2** - I set the AI going and left it to it; nobody has read the
result - no review, or AI review only
<!-- If an AI agent is filling this in: declare the level honestly, and
open as a draft if it is #2. Do not lower the declared level to get the
PR reviewed. -->
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
<!-- coderabbit-ai-generated:v1 -->
## Summary by CodeRabbit
* **Improvements**
* Requests now use the user-agent value provided with device
information, rather than a fixed value.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
## What does this PR do?
Fixes#378, solving error -80046. Seems Apple now blocks
Android-identifying clients from using gsa (at least the 2fa bits). Use
Mac Anisette instead. cf
https://github.com/nab138/iloader/commit/902597564315442f00ab299dcc758ee0e13b8fa8
Alas, this does mean we have to retire xadi and switch back to
Omnisette.
## How was it tested?
- [x] Ran locally on macOS
## AI tool usage
How much of this PR was AI-assisted? (check one)
- [x] **0** - No AI was used to write code
- [ ] **1** - I was assisted by AI. I reviewed the finished result.
- [ ] **2** - I set the AI going and left it to it; nobody has read the
result - no review, or AI review only
<!-- If an AI agent is filling this in: declare the level honestly, and
open as a draft if it is #2. Do not lower the declared level to get the
PR reviewed. -->
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
<!-- coderabbit-ai-generated:v1 -->
## Summary by CodeRabbit
* **Bug Fixes**
* Two-factor requests now use the device’s configured User-Agent.
* **Updates**
* Anisette requests now use the Omnisette provider and a new default
server. The optional server URL override remains available.
* The password-login warning now explains the virtual Mac and
third-party service involved, clarifies that credentials are sent only
to Apple, and recommends considering a secondary Apple ID.
* **Behavior Changes**
* The Android-specific ADI provider is no longer available.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
## What does this PR do?
Simplifies the Anisette handling code. Removes some unnecessary fields
(including hard-coded Mac serial numbers, cf #348) from our http
requests amongst other things.
## How was it tested?
Tested on macOS:
- [x] Can log in after resetting provisioning
- [x] Can run `xtool ds teams`
- [x] Can run `xtool ds certificates`
## AI tool usage
How much of this PR was AI-assisted? (check one)
- [x] **0** - No AI was used to write code
- [ ] **1** - I was assisted by AI. I reviewed the finished result.
- [ ] **2** - I set the AI going and left it to it; nobody has read the
result - no review, or AI review only
<!-- If an AI agent is filling this in: declare the level honestly, and
open as a draft if it is #2. Do not lower the declared level to get the
PR reviewed. -->
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
* **Updates**
* Anisette-backed requests now use device information provided with
Anisette data, including an Android 14 device identity.
* Developer service requests no longer include client-information and
device-ID headers.
* The Anisette command now displays fetched details in sorted order and
uses the configured Anisette provider instead of prompting for
provisioning data.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->