chore(metal): merge validated missing-function handling into texture policy

This commit is contained in:
rponeawa
2026-11-16 06:16:28 +08:00
Unverified
2 changed files with 22 additions and 2 deletions
+20 -2
View File
@@ -1662,6 +1662,20 @@ static std::string quartzCoreCallers();
// no runtime handle: it is stitched from its bitcode (functionBitcode) and refused as a pipeline's own function.
static NBFunction *ciKernelFunction(NBLibrary *library,NSString *name);
static bool forEachLibraryEntry(NBLibrary *library,const std::function<bool(const std::string &,int)> &visit);
static NSError *functionLookupError(NBLibrary *library, NSString *name, NSString *detail) {
const char *wanted = name.UTF8String;
bool found = false;
// Core Image can search several libraries for the same kernel. Keep a missing
// function distinguishable from a failure to specialize a function that exists.
if(wanted && forEachLibraryEntry(library,[&](const std::string &entry,int) {
found = entry == wanted;
return !found;
}) && !found) {
return [NSError errorWithDomain:MTLLibraryErrorDomain code:MTLLibraryErrorFunctionNotFound
userInfo:@{NSLocalizedDescriptionKey:detail}];
}
return nbError(detail);
}
@implementation NBLibrary
- (void)dealloc {DetailSpan timing(9,(uintptr_t)_handle);nmb_library_release(_handle);}
- (id<MTLFunction>)newFunctionWithName:(NSString *)name constantValues:(MTLFunctionConstantValues *)values error:(NSError **)error {
@@ -1707,7 +1721,8 @@ static bool forEachLibraryEntry(NBLibrary *library,const std::function<bool(cons
}
if(!handle){
noteProblem([NSString stringWithFormat:@"specialized function %@: %@",name,lastError()]);
if(error)*error=nbError([NSString stringWithFormat:@"specialized function: %@",lastError()]);return nil;
if(error)*error=functionLookupError(self,name,[NSString stringWithFormat:@"specialized function: %@",lastError()]);
return nil;
}
NBFunction *function=[NBFunction new];function.handle=handle;function.name=name;function.sourceName=name;function.functionType=(MTLFunctionType)nmb_function_type(handle);
function.constantsText=text;function.library=self;function.constantValues=snapshot;if(error)*error=nil;return (id<MTLFunction>)function;
@@ -1721,7 +1736,10 @@ static bool forEachLibraryEntry(NBLibrary *library,const std::function<bool(cons
- (id<MTLFunction>)newFunctionWithDescriptor:(MTLFunctionDescriptor *)d error:(NSError **)error {
if(!d.name){if(error)*error=nbError(@"a function name is required");return nil;}
NBFunction *function=(NBFunction *)(d.constantValues?[self newFunctionWithName:d.name constantValues:d.constantValues error:error]:[self newFunctionWithName:d.name]);
if(!function){if(error && !d.constantValues)*error=nbError([NSString stringWithFormat:@"function %@: %@",d.name,lastError()]);return nil;}
if(!function){
if(error && !d.constantValues)*error=functionLookupError(self,d.name,[NSString stringWithFormat:@"function %@: %@",d.name,lastError()]);
return nil;
}
if(d.specializedName) {
if(function.handle && !nmb_function_set_specialized_name(function.handle,d.specializedName.UTF8String)) {
if(error)*error=nbError(lastError());return nil;
+2
View File
@@ -14,6 +14,8 @@ Texture creation, heap size queries and texture views preserve
`allowGPUOptimizedContents`. A caller that requests an unoptimized layout keeps
that layout through the frontend and runtime.
Function lookup returns `MTLLibraryErrorFunctionNotFound` when the requested name is absent from the library.
Build and interface details: [documentation](https://unixnu.com/drivers/adreno-metal). Component sources and dependencies: [catalog](https://unixnu.com/reference/components).
## Native half arithmetic