mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-11-18 11:56:11 +03:00
69677b5829
Review findings from unsupportedpastels and kshitijk4poor: - A steered child lost its brief at its second compaction. The compactor stops protecting early turns after the first pass and restates the newest real user turn, which after a steer is the steer. A delegated child's first user turn is its whole brief (goal, context, output contract), so it is now always protected (ContextCompressor.pin_task_turn, set on every child). The head window methods move to context_compressor_window.py with it. - Siblings given one context stopped reading it from cache: the goal came first, so the shared bytes started after the first difference. The first user turn is now "CONTEXT: ... TASK: <goal>", and the context is registered as the message's stable prefix, which gives it its own cache breakpoint on marker routes. Every brief is registered: a parent often sends one brief in separate calls, which a per-call "shared" test cannot see. - Stale docs and comments that still placed the context in the system prompt. Co-authored-by: unsupportedpastels <unsupportedpastels@users.noreply.github.com> Co-authored-by: kshitijk4poor <kshitijk4poor@users.noreply.github.com>
110 lines
6.2 KiB
Python
110 lines
6.2 KiB
Python
"""Compaction window planning for ContextCompressor: the head/middle/tail boundaries that compress() and
|
|
the opt-in prepared-compaction pass (agent/prepared_compaction.py) both plan, and the splice of a prepared
|
|
summary into that window."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from typing import Any, Optional
|
|
|
|
from agent.context_compressor_tail import tail_cut_progress_floor
|
|
from agent.prepared_compaction import PreparedCompaction, PreparedSummary
|
|
|
|
|
|
def _restart_probe_extra() -> int:
|
|
from agent.context_compressor import _RESTART_HANDOFF_PROBE_EXTRA_MESSAGES
|
|
return _RESTART_HANDOFF_PROBE_EXTRA_MESSAGES
|
|
|
|
|
|
class CompactionWindowMixin:
|
|
"""Window planning shared by compress() and the background pass."""
|
|
|
|
# Set by agent_init when compression.prepare_ahead is on; None leaves compress() inline as before.
|
|
prepared_compaction: Optional[PreparedCompaction] = None
|
|
# Set on delegated children (tools/delegate_tool.py): their first user turn is the whole brief.
|
|
pin_task_turn: bool = False
|
|
|
|
def _restart_handoff_probe_bounds(self, messages: list[dict[str, Any]]) -> tuple[int, int]:
|
|
"""Return the bounded transcript region that can indicate restart decay."""
|
|
if not messages or self.protect_first_n <= 0:
|
|
return 0, 0
|
|
first_non_system = 1 if messages[0].get("role") == "system" else 0
|
|
return first_non_system, min(len(messages), first_non_system + self.protect_first_n + _restart_probe_extra())
|
|
|
|
def _effective_protect_first_n(self, messages: Optional[list[dict[str, Any]]] = None) -> int:
|
|
"""``protect_first_n``, decayed to 0 once the session has been compressed so early turns don't fossilize.
|
|
After a restart the decayed state is inferred from handoff summaries in the resumed head.
|
|
A delegated child's first user turn is its whole brief (goal, context, output contract), so it
|
|
never decays: a steer would otherwise become the turn compaction restates, and the brief goes
|
|
into the summary."""
|
|
if self.pin_task_turn:
|
|
return 1
|
|
if self.compression_count >= 1 or self._previous_summary:
|
|
return 0
|
|
if messages and self.protect_first_n > 0:
|
|
# Probe only the early resumed-handoff shape; summary-like tail content must not decay protection.
|
|
probe_start, probe_end = self._restart_handoff_probe_bounds(messages)
|
|
if any(map(self._is_context_summary_message, messages[probe_start:probe_end])):
|
|
return 0
|
|
return self.protect_first_n
|
|
|
|
def _protect_head_size(self, messages: list[dict[str, Any]]) -> int:
|
|
"""Head messages to protect: the system prompt (if present) plus the decaying ``protect_first_n`` extra rows.
|
|
|
|
The ``protect_first_n`` portion DECAYS after the first compression (see _effective_protect_first_n)
|
|
so early user turns don't fossilize across repeated compactions (#11996).
|
|
"""
|
|
head = 1 if messages and messages[0].get("role") == "system" else 0
|
|
return head + self._effective_protect_first_n(messages)
|
|
|
|
def _compress_window(self, messages: list[dict[str, Any]]) -> tuple[int, int]:
|
|
"""Return ``(compress_start, compress_end)`` for the summarizable middle."""
|
|
compress_start = self._align_boundary_forward(messages, self._protect_head_size(messages))
|
|
compress_end = self._find_tail_cut_by_tokens(messages, compress_start)
|
|
# A role collision can merge the summary into the first tail row; keep an actionable user
|
|
# event out of that slot by retaining an older assistant/tool bridge. The bridge never moves
|
|
# the cut below the progress floor: a bridge that leaves only handoff rows in the window
|
|
# would no-op with ``empty_post_handoff_window`` at every trigger.
|
|
latest_actionable_idx = self._find_last_user_message_idx(messages, 0)
|
|
if compress_end == latest_actionable_idx:
|
|
bridge_idx = latest_actionable_idx - 1
|
|
bridge_role = messages[bridge_idx].get("role") if bridge_idx >= 0 else None
|
|
if bridge_role == "tool":
|
|
bridge_idx = self._align_boundary_backward(messages, latest_actionable_idx)
|
|
elif bridge_role != "assistant":
|
|
bridge_idx = -1
|
|
if bridge_idx >= tail_cut_progress_floor(self, messages, compress_start, bridge_idx):
|
|
compress_end = bridge_idx
|
|
return compress_start, compress_end
|
|
|
|
def _plan_compaction_window(self, messages: list[dict[str, Any]]) -> tuple[list[dict[str, Any]], int, int, int]:
|
|
"""Phases 1-2 of compress(): ``(working, pruned_count, compress_start, compress_end)``.
|
|
``working`` is a pruned copy without blank echoes; the boundaries index into it."""
|
|
working, pruned_count = self._prune_old_tool_results(
|
|
messages, protect_tail_count=self.protect_last_n, protect_tail_tokens=self.tail_token_budget,
|
|
)
|
|
working = self._drop_blank_echoes(working)
|
|
compress_start, compress_end = self._compress_window(working)
|
|
return working, pruned_count, compress_start, compress_end
|
|
|
|
def _take_prepared_summary(
|
|
self, messages: list[dict[str, Any]], compress_start: int, *, fresh: bool, provider_context: bool,
|
|
) -> Optional[PreparedSummary]:
|
|
"""The summary prepared in the background for this window, which an automatic compaction splices at
|
|
ITS boundary; every newer message stays outside the summary, in the tail. ``fresh`` compactions
|
|
(manual, focus, overflow recovery, memory-provider context) summarize anew, and once a memory
|
|
provider supplies context no further summaries are prepared (each would be thrown away)."""
|
|
if self.prepared_compaction is None:
|
|
return None
|
|
if provider_context:
|
|
self.prepared_compaction.stop_for_provider_context()
|
|
return self.prepared_compaction.take(
|
|
messages, self._session_id, compress_start, eligible=not (fresh or provider_context),
|
|
)
|
|
|
|
def _adopt_prepared_summary(self, prepared: PreparedSummary) -> str:
|
|
"""Adopt a prepared summary as an inline summary call would have left it; returns the handoff text."""
|
|
from agent.prepared_compaction import adopt
|
|
|
|
adopt(self, prepared)
|
|
return prepared.summary
|