mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-11-18 11:56:11 +03:00
a1bbd329ea
utils.py held three subjects in one 871-line file. It is now a package with one module per subject: utils/files.py (atomic writes, temp files, file mode and owner, signatures and digests, JSON and YAML file helpers), utils/urls.py (the base_url helpers) and utils/env.py (truthy values, env numbers, proxy env helpers). utils/__init__.py re-exports every public name, so no importer changes. Function bodies are unchanged, no function-level import moved, and the logger keeps the name "utils". Tests patch a name in the module that now defines it. Patches stay on the package where production reads the name through a function-level "from utils import". The tests of utils itself move to tests/utils/. A root module that becomes a folder drops out of anything that copies root *.py files plus a fixed list of packages, so the fixtures that build a partial source tree now list utils, as do pyproject's packages.find, three check scripts and the CI change classifier.
69 lines
2.5 KiB
Python
69 lines
2.5 KiB
Python
"""Tests for utils.atomic_yaml_write — crash-safe YAML file writes."""
|
||
|
||
from unittest.mock import patch
|
||
|
||
import pytest
|
||
import hermes_yaml as yaml
|
||
|
||
from utils import atomic_yaml_write
|
||
|
||
|
||
class TestAtomicYamlWrite:
|
||
def test_writes_valid_yaml(self, tmp_path):
|
||
target = tmp_path / "data.yaml"
|
||
data = {"key": "value", "nested": {"a": 1}}
|
||
|
||
atomic_yaml_write(target, data)
|
||
|
||
assert yaml.safe_load(target.read_text(encoding="utf-8")) == data
|
||
|
||
def test_cleans_up_temp_file_on_baseexception(self, tmp_path):
|
||
class SimulatedAbort(BaseException):
|
||
pass
|
||
|
||
target = tmp_path / "data.yaml"
|
||
original = {"preserved": True}
|
||
target.write_text(yaml.safe_dump(original), encoding="utf-8")
|
||
|
||
with patch("utils.files.yaml.safe_dump", side_effect=SimulatedAbort):
|
||
with pytest.raises(SimulatedAbort):
|
||
atomic_yaml_write(target, {"new": True})
|
||
|
||
tmp_files = [f for f in tmp_path.iterdir() if ".tmp" in f.name]
|
||
assert len(tmp_files) == 0
|
||
assert yaml.safe_load(target.read_text(encoding="utf-8")) == original
|
||
|
||
|
||
def test_writes_unicode_unescaped_and_round_trips(self, tmp_path):
|
||
"""Emoji/kaomoji are written as real UTF-8, not fragile escape sequences.
|
||
|
||
Regression for GitHub #51356: without allow_unicode=True, PyYAML emitted
|
||
astral-plane chars (emoji) as 8-digit `\\UXXXXXXXX` escapes inside
|
||
multi-line double-quoted strings wrapped with `\\` continuations, which
|
||
stricter/non-PyYAML parsers and hand-edits broke into unclosed quotes,
|
||
corrupting the entire config.
|
||
"""
|
||
target = tmp_path / "config.yaml"
|
||
# Mirrors the default personalities + skin cursor shipped in cli.py.
|
||
data = {
|
||
"personalities": {
|
||
"kawaii": "kawaii desu~! (◕‿◕) ★ ♪ ヽ(>∀<☆)ノ",
|
||
"catgirl": "nya~! (=^・ω・^=) ฅ^•ﻌ•^ฅ",
|
||
"surfer": "Cowabunga! 🤙 totally rad bro",
|
||
"hype": "LET'S GOOOO!!! 🔥 LEGENDARY!",
|
||
},
|
||
"display": {"cursor": " ▉"},
|
||
}
|
||
|
||
atomic_yaml_write(target, data)
|
||
|
||
text = target.read_text(encoding="utf-8")
|
||
# No escape artifacts of any kind — real characters on disk.
|
||
assert "\\U" not in text
|
||
assert "\\u" not in text
|
||
# Real glyphs are present verbatim.
|
||
assert "🔥" in text
|
||
assert "(=^・ω・^=)" in text
|
||
# And it reloads to exactly what was written.
|
||
assert yaml.safe_load(text) == data
|