mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-11-17 11:22:02 +03:00
cd4433dd0e
A pinned delegation.command used to force provider "copilot-acp" whenever the selected provider was not external_process. It now resolves the external_process profile whose process_command names the same binary, else the profile flagged with the new ProviderProfile.process_command_fallback (copilot-acp sets it, so every Copilot setup resolves as before), else the spawn fails loudly. A kimchi binary now lands on kimchi-acp. The env-writer denylist's hardcoded HERMES_COPILOT_ACP_* pair becomes hermes_cli.auth_external_process.external_process_launch_env_names(): every registered external_process profile's process_command_env_vars + process_args_env_var. This also closes the gap for out-of-tree providers (KIMCHI_ACP_COMMAND/ARGS) and COPILOT_CLI_PATH, which select the executable too.
34 lines
1.4 KiB
Python
34 lines
1.4 KiB
Python
"""Launch-env policy for external-process (ACP) providers comes from their profiles' ``process_*`` fields."""
|
|
|
|
import pytest
|
|
|
|
import providers
|
|
from providers.base import ProviderProfile
|
|
|
|
|
|
@pytest.fixture
|
|
def vendor_profiles(monkeypatch):
|
|
profiles = [
|
|
ProviderProfile(name="vendor-acp", auth_type="external_process", process_command="vendor",
|
|
process_command_env_vars=("VENDOR_ACP_COMMAND", "VENDOR_CLI_PATH"),
|
|
process_args_env_var="VENDOR_ACP_ARGS"),
|
|
ProviderProfile(name="vendor-api", auth_type="api_key", env_vars=("VENDOR_API_KEY",)),
|
|
]
|
|
monkeypatch.setattr(providers, "list_providers", lambda: list(profiles))
|
|
return profiles
|
|
|
|
|
|
def test_launch_env_names_cover_every_external_process_override(vendor_profiles):
|
|
from hermes_cli.auth_external_process import external_process_launch_env_names
|
|
|
|
assert external_process_launch_env_names() == {"VENDOR_ACP_COMMAND", "VENDOR_CLI_PATH", "VENDOR_ACP_ARGS"}
|
|
|
|
|
|
@pytest.mark.parametrize("name", ["VENDOR_ACP_COMMAND", "VENDOR_CLI_PATH", "VENDOR_ACP_ARGS"])
|
|
def test_env_writer_refuses_a_provider_executable_override(vendor_profiles, name):
|
|
from hermes_cli.config import validate_env_var_name_for_write
|
|
|
|
with pytest.raises(ValueError, match="writer denylist"):
|
|
validate_env_var_name_for_write(name)
|
|
validate_env_var_name_for_write("VENDOR_API_KEY") # an ordinary provider secret stays writable
|