Files
hermes-agent/tests/hermes_cli/test_profile_delete_wrapper.py
kshitijk4poor 9c8cefe366 fix(profiles): alias_path never names a foreign same-named command; tests run on the real host
Review follow-up (greptile on #137336):

- _profile_info picked the first existing wrapper candidate, so on Windows a
  bare legacy wrapper `old` plus an unrelated `old.bat` gave alias_path ==
  old.bat. Doctor then reported an alias and `hermes uninstall` would unlink
  the unrelated command. alias_path now requires _is_our_wrapper, as
  delete_profile's lookup does. Probe: old.bat before, old after.
- Tests no longer fake the host OS (tests/AGENTS.md): the doctor test and the
  .bat delete test are platforms("any") and check each host's real wrapper
  name; the pre-.bat delete case is platforms("windows"). The doctor test adds
  foreign same-named .bat files and pins alias_path to the real wrapper.
2026-10-13 03:19:50 +05:30

47 lines
1.7 KiB
Python

"""`hermes profile delete` removes the profile's wrapper (#131753).
Windows wrappers are ``<alias>.bat``; delete used to look only for the bare name, so the
``.bat`` survived as an orphan alias. A Windows wrapper written before ``.bat`` (#34796) is
bare-named and must still go.
"""
from pathlib import Path
import pytest
from hermes_cli import profiles
from hermes_cli.profiles import create_profile, create_wrapper_script, delete_profile
@pytest.fixture
def home(tmp_path, monkeypatch):
monkeypatch.setattr(Path, "home", lambda: tmp_path)
(tmp_path / ".hermes").mkdir()
monkeypatch.setenv("HERMES_HOME", str(tmp_path / ".hermes"))
for stub in ("_cleanup_gateway_service", "_maybe_unregister_gateway_service", "_stop_profile_backends"):
monkeypatch.setattr(profiles, stub, lambda *a, **k: None)
return tmp_path
def _delete_and_check(profile_dir, wrapper):
delete_profile("imported", yes=True)
assert not profile_dir.exists()
assert not wrapper.exists()
@pytest.mark.platforms("any") # the wrapper name differs per host (.bat on Windows)
def test_delete_removes_the_profile_wrapper(home):
profile_dir = create_profile("imported", no_alias=True)
wrapper = create_wrapper_script("imported")
assert wrapper is not None
_delete_and_check(profile_dir, wrapper)
@pytest.mark.platforms("windows")
def test_delete_removes_a_pre_bat_windows_wrapper(home):
profile_dir = create_profile("imported", no_alias=True)
wrapper = home / ".local" / "bin" / "imported"
wrapper.parent.mkdir(parents=True, exist_ok=True)
wrapper.write_text("@echo off\r\nhermes -p imported %*\r\n", encoding="utf-8")
_delete_and_check(profile_dir, wrapper)