mirror of
https://github.com/NousResearch/hermes-agent.git
synced 2026-11-19 21:37:12 +03:00
b3b176a64e
Routed-profile harness credential (B's BROWSER_USE_API_KEY, never A's; flag-off miss is no key), headless default read from a real config.yaml, the expiry test's order of teardown vs replacement, doctor --fix / Termux gates on Chromium acquisition, and the Windows argv singleton scan.
82 lines
3.4 KiB
Python
82 lines
3.4 KiB
Python
"""Regression for #64867: local Chromium stays headless on Windows Desktop.
|
|
|
|
Windows Desktop opened a blank top-level window during local browser automation: anything that
|
|
resolves the launch to headed turns local mode's documented "zero-cost headless Chromium" into a
|
|
visible browser over the Desktop chat. ``browser_launcher._resolve_headed`` keeps every launch headless
|
|
unless the profile's ``browser.headed`` is on, and the launch argv then carries ``--headless=new``. The
|
|
setting is read from a real ``config.yaml``. The Windows-only rule (an opted-in headed launch needs no
|
|
DISPLAY) runs on the Windows lane; the Linux display rule is covered in test_browser_launcher.py.
|
|
"""
|
|
|
|
from pathlib import Path
|
|
|
|
import pytest
|
|
|
|
from tools import browser_launcher as launcher
|
|
from tools import browser_session_cloud as bs_cloud
|
|
|
|
_WITH_DISPLAY = {"DISPLAY": ":0", "WAYLAND_DISPLAY": "wayland-0"}
|
|
|
|
|
|
@pytest.fixture(autouse=True)
|
|
def home(monkeypatch, tmp_path):
|
|
home = tmp_path / ".hermes"
|
|
home.mkdir()
|
|
monkeypatch.setattr(Path, "home", lambda: tmp_path)
|
|
monkeypatch.setenv("HERMES_HOME", str(home))
|
|
monkeypatch.setenv("HERMES_RUNTIME_DIR", str(tmp_path / "tools"))
|
|
monkeypatch.setattr("tools.browser_session_cloud.chromium_args", list)
|
|
bs_cloud.reset_caches()
|
|
yield home
|
|
bs_cloud.reset_caches()
|
|
|
|
|
|
def _configure(home: Path, body: str) -> None:
|
|
(home / "config.yaml").write_text(body, encoding="utf-8")
|
|
bs_cloud.reset_caches()
|
|
|
|
|
|
def test_launch_is_headless_unless_browser_headed_is_configured(home):
|
|
"""No ``browser.headed`` (or ``false``) is headless even where a display exists; ``true`` opts in."""
|
|
assert launcher._resolve_headed(None, _WITH_DISPLAY) is False
|
|
_configure(home, "browser:\n headed: false\n")
|
|
assert launcher._resolve_headed(None, _WITH_DISPLAY) is False
|
|
_configure(home, "browser:\n headed: true\n")
|
|
assert launcher._resolve_headed(None, _WITH_DISPLAY) is True
|
|
assert launcher._resolve_headed(False, _WITH_DISPLAY) is False # an explicit headless launch wins
|
|
|
|
|
|
@pytest.mark.platforms("windows")
|
|
def test_windows_headed_opt_in_needs_no_display(home):
|
|
"""Windows always has a desktop session: no DISPLAY, still headless by default, headed once opted in."""
|
|
assert launcher._resolve_headed(None, {"PATH": "C:/Windows"}) is False
|
|
_configure(home, "browser:\n headed: true\n")
|
|
assert launcher._resolve_headed(None, {}) is True
|
|
|
|
|
|
def test_default_local_launch_argv_is_headless(monkeypatch, tmp_path):
|
|
"""A default local launch's real argv carries --headless=new, even with a display (#64867)."""
|
|
monkeypatch.setattr(launcher, "needs_chromium_sandbox_bypass", lambda: False)
|
|
captured = []
|
|
|
|
class _Proc:
|
|
pid = 4321
|
|
|
|
def poll(self):
|
|
return 1
|
|
|
|
def capture_spawn(argv, env, user_data_dir):
|
|
captured.append(argv)
|
|
return _Proc()
|
|
|
|
monkeypatch.setattr(launcher, "_spawn", capture_spawn)
|
|
monkeypatch.setattr(launcher, "_start_time", lambda pid: None)
|
|
monkeypatch.setattr(launcher, "_terminate", lambda pid, start_time, proc: None)
|
|
browser, err = launcher.launch_chromium("win-headless", executable="chrome.exe",
|
|
user_data_dir=str(tmp_path / "udd"), env=dict(_WITH_DISPLAY),
|
|
timeout=1)
|
|
|
|
assert browser is None and "exited" in err # the fake exits at once; only the argv matters
|
|
assert len(captured) == 1
|
|
assert "--headless=new" in captured[0]
|