Files
hermes-agent/tests/tools/test_local_persistent_shell.py
Teknium 745380d495 test(terminal): the local default reaches the environment too; config comment matches the docs
Review on #136802: the 'defaults on' test built only a persistent=False env, so it
proved the override, not the default. It now builds both. The config_defaults
comment no longer says profile functions never carry (they do with the setting off).
2026-10-11 16:53:57 -07:00

76 lines
3.3 KiB
Python

"""TERMINAL_LOCAL_PERSISTENT end to end on a real local bash: on (the default) carries exported
env vars between commands, off starts every command from the login-time env. cwd carries in
both modes (file tools rely on it); plain shell vars never carry."""
import json
import pytest
from tools.terminal_tool import _get_env_config, _resolve_container_task_id, terminal_tool
from tools.terminal_tool_lifecycle import cleanup_vm
@pytest.mark.platforms("linux", "macos")
@pytest.mark.parametrize("setting, exported", [(None, "yes"), ("true", "yes"), ("false", "none")])
def test_local_persistent_controls_exports_but_cwd_always_carries(monkeypatch, tmp_path, setting, exported):
monkeypatch.setenv("TERMINAL_ENV", "local")
monkeypatch.setenv("TERMINAL_CWD", str(tmp_path))
if setting is None:
monkeypatch.delenv("TERMINAL_LOCAL_PERSISTENT", raising=False)
else:
monkeypatch.setenv("TERMINAL_LOCAL_PERSISTENT", setting)
task_id = f"local-persist-{setting}"
(tmp_path / "sub").mkdir()
def run(cmd):
return json.loads(terminal_tool(cmd, task_id=task_id))["output"].strip()
try:
run("cd sub && export HERMES_LP_EXPORT=yes; HERMES_LP_PLAIN=yes")
assert run("echo ${HERMES_LP_EXPORT:-none} ${HERMES_LP_PLAIN:-none}") == f"{exported} none"
assert run("pwd -P") == str((tmp_path / "sub").resolve())
finally:
cleanup_vm(_resolve_container_task_id(task_id))
def test_local_persistent_defaults_on_and_reaches_the_environment(monkeypatch, tmp_path):
from tools.terminal_tool_lifecycle import _create_configured_env
monkeypatch.delenv("TERMINAL_LOCAL_PERSISTENT", raising=False)
config = _get_env_config()
assert config["local_persistent"] is True
for value, task in ((config["local_persistent"], "default"), (False, "off")):
env = _create_configured_env({**config, "local_persistent": value}, "local", image="", cwd=str(tmp_path),
timeout=30, task_id=f"local-persist-config-{task}", host_cwd=None)
try:
assert env._persist_env is value
finally:
env.cleanup()
@pytest.mark.platforms("linux", "macos")
@pytest.mark.parametrize("setting, later", [("true", "fn:no"), ("false", "fn:yes")])
def test_profile_functions_survive_only_with_persistence_off(monkeypatch, tmp_path, setting, later):
"""The login snapshot holds profile functions; with persistence on the first command's
``export -p`` re-dump replaces it, so they are gone from the second command on. The docs'
"Profile functions / aliases" row states exactly this."""
home = tmp_path / "home"
home.mkdir()
for rc in (".bashrc", ".bash_profile"):
(home / rc).write_text("hermes_lp_fn(){ echo FN; }\n", encoding="utf-8")
monkeypatch.setenv("HOME", str(home))
monkeypatch.setenv("TERMINAL_ENV", "local")
monkeypatch.setenv("TERMINAL_CWD", str(tmp_path))
monkeypatch.setenv("TERMINAL_LOCAL_PERSISTENT", setting)
task_id = f"local-persist-fn-{setting}"
probe = "type hermes_lp_fn >/dev/null 2>&1 && echo fn:yes || echo fn:no"
def run(cmd):
return json.loads(terminal_tool(cmd, task_id=task_id))["output"].strip()
try:
assert run(probe) == "fn:yes"
assert run(probe) == later
finally:
cleanup_vm(_resolve_container_task_id(task_id))