Files
hermes-agent/tests/tools/test_process_wait_auto_notify.py
Maciej Lisiewski 4f5dd0f35c refactor(tools): move process_manage ownership check into a sibling, cover kill/stdin
Follow-up to the salvaged ownership guard: the predicate lives in
tools/process_registry_access.py (the facade may not grow), list and the
session actions share one caller_session_key(), and the tests move to a
new file adding kill/write/submit/close, log, compression-continuation and
"same shape as a missing id" cases. Two existing tests drove a foreign
task's process and now act as its owner.

Fixes #108413
Fixes #110051
2026-11-14 21:01:47 +01:00

84 lines
3.5 KiB
Python

"""Repeated process_manage wait/poll on a silent running process promotes it to notify_on_complete."""
import json
import pytest
import tools.process_registry as pr
@pytest.fixture
def sleeper(tmp_path, monkeypatch):
home = tmp_path / ".hermes"
home.mkdir()
monkeypatch.setenv("HERMES_HOME", str(home))
session = pr.process_registry.spawn_local("sleep 30", cwd=str(tmp_path), task_id="t-autonotify")
session.notify_on_complete = False
yield home, session
pr.process_registry.kill_process(session.id)
def _wait(sid):
return json.loads(pr._handle_process({"action": "wait", "session_id": sid, "timeout": 1}))
def test_second_unchanged_wait_enables_notify_and_tells_model_to_stop(sleeper):
_home, session = sleeper
first = _wait(session.id)
assert first["status"] == "timeout" and not session.notify_on_complete
second = _wait(session.id)
assert second["status"] == "timeout" and second["process_running"] is True
assert session.notify_on_complete is True
assert "Do NOT call process_manage wait or poll" in second["timeout_note"]
def test_opt_out_keeps_plain_polling(sleeper, tmp_path, monkeypatch):
"""The opt-out is read from the EFFECTIVE config, so an admin-managed value counts too."""
_home, session = sleeper
managed = tmp_path / "managed"
managed.mkdir()
(managed / "config.yaml").write_text("terminal:\n process_wait_auto_notify: false\n", encoding="utf-8")
monkeypatch.setenv("HERMES_MANAGED_DIR", str(managed))
for _ in range(3):
result = _wait(session.id)
assert result["status"] == "timeout"
assert "Poll again later" in result["timeout_note"] and "notify_on_complete" not in result
assert session.notify_on_complete is False
def test_caller_that_does_not_own_the_completion_keeps_plain_polling(tmp_path, monkeypatch):
"""A caller acting through the owning task but bound to session B must not be told to stop:
the completion is routed to session A. (Session B alone cannot reach A's process at all, #108413.)"""
monkeypatch.setenv("HERMES_HOME", str(tmp_path))
session = pr.process_registry.spawn_local("sleep 30", cwd=str(tmp_path), task_id="owner-a", session_key="owner-a")
session.notify_on_complete = False
monkeypatch.setenv("HERMES_SESSION_KEY", "caller-b")
try:
for _ in range(3):
result = json.loads(pr._handle_process(
{"action": "wait", "session_id": session.id, "timeout": 1}, task_id="owner-a"))
assert "Poll again later" in result["timeout_note"] and "notify_on_complete" not in result
assert session.notify_on_complete is False
finally:
pr.process_registry.kill_process(session.id)
def test_exit_racing_promotion_is_never_lost(sleeper, monkeypatch):
"""The process exits after the policy saw it running but before it promotes: the exit was
published while notify_on_complete was still off, so the result must report the exit rather
than promise a completion message nobody will queue."""
import tools.process_registry_wait_policy as policy
_home, session = sleeper
_wait(session.id)
real_can_deliver = policy._can_deliver_completion
def exit_lands_now():
pr.process_registry._finish_exited(session, 0)
return real_can_deliver()
monkeypatch.setattr(policy, "_can_deliver_completion", exit_lands_now)
result = _wait(session.id)
queued = [e for e in list(pr.process_registry.completion_queue.queue) if e.get("session_id") == session.id]
assert queued or result["status"] == "exited", result