mirror of
https://github.com/anomalyco/opencode.git
synced 2026-11-16 05:01:03 +03:00
feat(ai): support between_tools thinking in Anthropic Messages (#53601)
This commit is contained in:
committed by
GitHub
Unverified
parent
fd99516e51
commit
34cf183c4c
@@ -285,7 +285,7 @@ const AnthropicThinkingEnabled = Schema.Struct({
|
||||
...AnthropicThinkingFields,
|
||||
})
|
||||
const AnthropicThinkingAdaptive = Schema.Struct({ type: Schema.tag("adaptive"), ...AnthropicThinkingFields })
|
||||
const AnthropicThinkingDisabled = Schema.Struct({ type: Schema.tag("disabled") })
|
||||
const AnthropicThinkingDisabled = Schema.Struct({ type: Schema.Literals(["disabled", "between_tools"]) })
|
||||
const AnthropicThinking = Schema.Union([AnthropicThinkingEnabled, AnthropicThinkingAdaptive, AnthropicThinkingDisabled])
|
||||
type AnthropicThinking = typeof AnthropicThinking.Type
|
||||
|
||||
@@ -1001,18 +1001,21 @@ const lowerMessages = Effect.fnUntraced(function* (request: LLMRequest, breakpoi
|
||||
// TODO: Move per-model capability heuristics (`supportsEffortUpdates`, `supportsNativeSystemUpdates`,
|
||||
// `supportsThinkingBlockBinding`) into explicit model/provider `compatibility` metadata so the protocol
|
||||
// only reads `request.model.compatibility`.
|
||||
const isThinkingOff = Schema.is(AnthropicThinkingDisabled)
|
||||
|
||||
// Per-turn effort started with Claude Opus 5 and every Claude 5.1 model; later versions of any family inherit it.
|
||||
const supportsEffortUpdates = (model: LLMRequest["model"]) => {
|
||||
const override = model.compatibility?.supportsEffortUpdates
|
||||
const supportsEffortUpdates = (request: LLMRequest) => {
|
||||
if (isThinkingOff(request.providerOptions?.thinking)) return false
|
||||
const override = request.model.compatibility?.supportsEffortUpdates
|
||||
if (override !== undefined) return override
|
||||
const version = claudeVersion(model.id)
|
||||
const version = claudeVersion(request.model.id)
|
||||
if (version === undefined) return false
|
||||
if (version.family === "opus" && version.major >= 5) return true
|
||||
return version.major > 5 || (version.major === 5 && version.minor >= 1)
|
||||
}
|
||||
|
||||
const applyThinkingBindingDefault = (model: LLMRequest["model"], thinking: AnthropicThinking | undefined) => {
|
||||
if (thinking?.type === "disabled") return thinking
|
||||
if (isThinkingOff(thinking)) return thinking
|
||||
if (!supportsThinkingBlockBinding(model)) return thinking
|
||||
return {
|
||||
...(thinking ?? { type: "adaptive" as const }),
|
||||
@@ -1607,7 +1610,7 @@ export const protocol = Protocol.make({
|
||||
}),
|
||||
step,
|
||||
},
|
||||
supportsEffortUpdates: (request) => supportsEffortUpdates(request.model),
|
||||
supportsEffortUpdates,
|
||||
})
|
||||
|
||||
export const transport = <
|
||||
@@ -1653,7 +1656,7 @@ function requiredBetaHeaders(body: Pick<AnthropicMessagesBody, "messages" | "con
|
||||
betas.push("mid-conversation-output-config-2026-07-01")
|
||||
|
||||
const thinking = body.thinking
|
||||
if (thinking && thinking.type !== "disabled" && thinking.block_binding) betas.push(THINKING_BINDING_BETA)
|
||||
if (thinking && !isThinkingOff(thinking) && thinking.block_binding) betas.push(THINKING_BINDING_BETA)
|
||||
return betas
|
||||
}
|
||||
|
||||
|
||||
@@ -476,7 +476,9 @@ const MIN_THINKING_BUDGET = 1_024
|
||||
|
||||
const isThinkingDisabled = Schema.is(
|
||||
Schema.Struct({
|
||||
additionalModelRequestFields: Schema.Struct({ thinking: Schema.Struct({ type: Schema.Literal("disabled") }) }),
|
||||
additionalModelRequestFields: Schema.Struct({
|
||||
thinking: Schema.Struct({ type: Schema.Literals(["disabled", "between_tools"]) }),
|
||||
}),
|
||||
}),
|
||||
)
|
||||
|
||||
|
||||
@@ -65,8 +65,8 @@ const messagesRoute = Route.make({
|
||||
...AnthropicMessages.protocol,
|
||||
// Mantle rejects mid-conversation `output_config` on Opus 5.0; support starts at 5.1+.
|
||||
supportsEffortUpdates: (request) => {
|
||||
const override = request.model.compatibility?.supportsEffortUpdates
|
||||
if (override !== undefined) return override
|
||||
if (!(AnthropicMessages.protocol.supportsEffortUpdates?.(request) ?? false)) return false
|
||||
if (request.model.compatibility?.supportsEffortUpdates !== undefined) return true
|
||||
const version = claudeVersion(request.model.id)
|
||||
return version !== undefined && (version.major > 5 || (version.major === 5 && version.minor >= 1))
|
||||
},
|
||||
|
||||
@@ -268,6 +268,22 @@ describe("Anthropic Messages effort updates", () => {
|
||||
}),
|
||||
)
|
||||
|
||||
it.effect("strips markers when thinking is disabled or between_tools", () =>
|
||||
Effect.gen(function* () {
|
||||
const sonnet = anthropic("claude-sonnet-5-5")
|
||||
const betweenTools = yield* compileRequest(
|
||||
LLM.request({
|
||||
model: sonnet,
|
||||
messages: conversation,
|
||||
providerOptions: { thinking: { type: "between_tools" }, effort: "low" },
|
||||
}),
|
||||
)
|
||||
|
||||
expect(systemMessages(betweenTools.body)).toHaveLength(0)
|
||||
expect(betweenTools.body.output_config).toEqual({ effort: "low" })
|
||||
}),
|
||||
)
|
||||
|
||||
it.effect("strips markers for Opus 5.0 on Bedrock Mantle Messages while lowering Opus 5.5", () =>
|
||||
Effect.gen(function* () {
|
||||
const mantle = AmazonBedrockMantle.configure({ apiKey: "test", region: "us-east-1" })
|
||||
|
||||
@@ -44,6 +44,7 @@ it.effect("preserves explicit thinking settings and combines required beta heade
|
||||
Effect.gen(function* () {
|
||||
for (const thinking of [
|
||||
{ type: "disabled" },
|
||||
{ type: "between_tools" },
|
||||
{ type: "adaptive", block_binding: { prefix_mismatch_behavior: "error" } },
|
||||
] as const) {
|
||||
const request = LLM.request({
|
||||
@@ -55,7 +56,7 @@ it.effect("preserves explicit thinking settings and combines required beta heade
|
||||
const prepared = yield* AnthropicMessages.route.prepareTransport(compiled.body, request)
|
||||
expect(compiled.body.thinking).toEqual(thinking)
|
||||
expect(prepared.request.headers["anthropic-beta"]).toBe(
|
||||
thinking.type === "disabled"
|
||||
thinking.type === "disabled" || thinking.type === "between_tools"
|
||||
? "interleaved-thinking-2025-05-14,compact-2026-01-12"
|
||||
: "interleaved-thinking-2025-05-14,compact-2026-01-12,thinking-binding-controls-2026-08-01",
|
||||
)
|
||||
|
||||
Reference in New Issue
Block a user