perf(desktop): load the browser pane on first use (#49774)

This commit is contained in:
Luke Parker
2026-09-19 09:39:36 +10:00
committed by GitHub
Unverified
parent 988a66ca4f
commit 485a027c1a
@@ -1,7 +1,6 @@
import { BrowserWindow } from "electron"
import { Effect } from "effect"
import { EventRpcs } from "../../shared/ipc-rpc"
import { createBrowserPane } from "../browser-pane"
import { ipcEventStream } from "../ipc-events"
import { IpcPortHandoff } from "../ipc-transport"
import { Shutdown } from "../lifecycle/shutdown"
@@ -14,8 +13,16 @@ export const eventHandlers = EventRpcs.toLayer(
const handoff = yield* IpcPortHandoff
const shutdown = yield* Shutdown.Service
const storage = yield* DesktopStorage.Service
const browser = createBrowserPane(storage.state)
const stop = Effect.promise(() => browser.dispose())
// The browser pane brings the CDP driver and the full RPC client with every protocol schema;
// load it when a renderer first opens a pane instead of at startup.
const load = async () => {
const { createBrowserPane } = await import("../browser-pane")
return createBrowserPane(storage.state)
}
let browser: ReturnType<typeof load> | undefined
const stop = Effect.promise(async () => {
if (browser) await (await browser).dispose()
})
const remove = yield* shutdown.add(stop)
yield* Effect.addFinalizer(() => Effect.sync(remove).pipe(Effect.andThen(stop)))
return EventRpcs.of({
@@ -27,10 +34,12 @@ export const eventHandlers = EventRpcs.toLayer(
if (!win || win.isDestroyed() || win.webContents !== contents || !isRendererUrl(contents.getURL())) {
throw new Error("browser.pane.owner.invalid")
}
if (request.type === "register") return browser.register(win, request.bindingID, request.target)
if (request.type === "layout") return browser.layout(win, request.bindingID, request.layout)
if (request.type === "command") return browser.command(win, request.bindingID, request.command)
return browser.close(win, request.bindingID)
browser ??= load()
const pane = await browser
if (request.type === "register") return pane.register(win, request.bindingID, request.target)
if (request.type === "layout") return pane.layout(win, request.bindingID, request.layout)
if (request.type === "command") return pane.command(win, request.bindingID, request.command)
return pane.close(win, request.bindingID)
}).pipe(Effect.orDie),
})
}),