chore(desktop): remove stale native packaging (#45786)

This commit is contained in:
Luke Parker
2026-08-28 10:18:53 +10:00
committed by GitHub
Unverified
parent 89ca9fc641
commit 4cecfe8e79
5 changed files with 29 additions and 37 deletions
-8
View File
@@ -458,14 +458,6 @@
"@lydell/node-pty-linux-x64": "1.2.0-beta.12",
"@lydell/node-pty-win32-arm64": "1.2.0-beta.12",
"@lydell/node-pty-win32-x64": "1.2.0-beta.12",
"@parcel/watcher-darwin-arm64": "2.5.1",
"@parcel/watcher-darwin-x64": "2.5.1",
"@parcel/watcher-linux-arm64-glibc": "2.5.1",
"@parcel/watcher-linux-arm64-musl": "2.5.1",
"@parcel/watcher-linux-x64-glibc": "2.5.1",
"@parcel/watcher-linux-x64-musl": "2.5.1",
"@parcel/watcher-win32-arm64": "2.5.1",
"@parcel/watcher-win32-x64": "2.5.1",
"msgpackr-extract": "3.0.4",
},
},
@@ -67,11 +67,13 @@ for (const channel of ["dev", "beta"] as const) {
else process.env.OPENCODE_CHANNEL = previous
expect(config.files).toContain("!resources/opencode-cli*")
expect(config.extraResources).toContainEqual({
from: "resources/",
to: "",
filter: ["opencode-cli*"],
})
expect(config.extraResources).toEqual([
{
from: "resources/",
to: "",
filter: ["opencode-cli*"],
},
])
})
}
@@ -83,9 +85,5 @@ test("does not bundle the CLI in prod builds", async () => {
if (previous === undefined) delete process.env.OPENCODE_CHANNEL
else process.env.OPENCODE_CHANNEL = previous
expect(config.extraResources).not.toContainEqual({
from: "resources/",
to: "",
filter: ["opencode-cli*"],
})
expect(config.extraResources).toEqual([])
})
+3 -9
View File
@@ -56,8 +56,8 @@ const getBase = (appId: string): Configuration => ({
desktopName: `${appId}.desktop`,
},
files: ["out/**/*", "resources/**/*", "!resources/opencode-cli*"],
extraResources: [
...(channel !== "prod"
extraResources:
channel !== "prod"
? [
{
from: "resources/",
@@ -65,13 +65,7 @@ const getBase = (appId: string): Configuration => ({
filter: ["opencode-cli*"],
},
]
: []),
{
from: "native/",
to: "native/",
filter: ["index.js", "index.d.ts", "build/Release/mac_window.node", "swift-build/**"],
},
],
: [],
mac: {
category: "public.app-category.developer-tools",
icon: `resources/icons/icon.icns`,
@@ -26,6 +26,23 @@ test("does not package external copies of bundled dependencies", () => {
expect(pkg.optionalDependencies["msgpackr-extract"]).toBe("3.0.4")
})
test("keeps PTY binaries without stale native packaging", () => {
expect(Object.keys(pkg.scripts)).not.toContain("native:build")
expect(
Object.keys({ ...pkg.dependencies, ...pkg.devDependencies, ...pkg.optionalDependencies }).filter((name) =>
name.startsWith("@parcel/watcher"),
),
).toEqual([])
expect(Object.keys(pkg.optionalDependencies).filter((name) => name.startsWith("@lydell/node-pty-"))).toEqual([
"@lydell/node-pty-darwin-arm64",
"@lydell/node-pty-darwin-x64",
"@lydell/node-pty-linux-arm64",
"@lydell/node-pty-linux-x64",
"@lydell/node-pty-win32-arm64",
"@lydell/node-pty-win32-x64",
])
})
test("bundles one Effect runtime and Drizzle while keeping native dependencies external", async () => {
const result = await loadConfigFromFile(
{ command: "build", mode: "production" },
+1 -10
View File
@@ -18,8 +18,7 @@
"package": "electron-builder --config electron-builder.config.ts",
"package:mac": "electron-builder --mac --config electron-builder.config.ts",
"package:win": "electron-builder --win --config electron-builder.config.ts",
"package:linux": "electron-builder --linux --config electron-builder.config.ts",
"native:build": "bun install --cwd native"
"package:linux": "electron-builder --linux --config electron-builder.config.ts"
},
"main": "./out/main/index.js",
"dependencies": {
@@ -65,14 +64,6 @@
"@lydell/node-pty-linux-x64": "1.2.0-beta.12",
"@lydell/node-pty-win32-arm64": "1.2.0-beta.12",
"@lydell/node-pty-win32-x64": "1.2.0-beta.12",
"@parcel/watcher-darwin-arm64": "2.5.1",
"@parcel/watcher-darwin-x64": "2.5.1",
"@parcel/watcher-linux-arm64-glibc": "2.5.1",
"@parcel/watcher-linux-arm64-musl": "2.5.1",
"@parcel/watcher-linux-x64-glibc": "2.5.1",
"@parcel/watcher-linux-x64-musl": "2.5.1",
"@parcel/watcher-win32-arm64": "2.5.1",
"@parcel/watcher-win32-x64": "2.5.1",
"msgpackr-extract": "3.0.4"
}
}