fix(core): broadcast models.dev catalog refreshes server-wide (#57148)

This commit is contained in:
Kit Langton
2026-10-20 00:08:22 -07:00
committed by GitHub
Unverified
parent d63c8d25f7
commit 5a36ee78e7
2 changed files with 47 additions and 1 deletions
+1 -1
View File
@@ -420,7 +420,7 @@ export const layer = (options?: Options) =>
yield* decodeCatalog(text)
yield* writeCache(text, digest)
yield* invalidate
yield* bus.publish(ModelsDev.Event.Refreshed, {})
yield* bus.publish(ModelsDev.Event.Refreshed, {}, { global: true })
}),
)
.pipe(
+46
View File
@@ -7,9 +7,12 @@ import { LayerNodePlatform } from "@opencode/util/effect/app-node-platform"
import { LayerNode } from "@opencode/util/effect/layer-node"
import { Bus } from "@opencode/core/bus"
import { KV } from "@opencode/core/kv"
import { Location } from "@opencode/core/location"
import { Model } from "@opencode/core/model"
import { bodyDigest, ModelsDev } from "@opencode/core/models-dev"
import { Provider } from "@opencode/core/provider"
import { AbsolutePath } from "@opencode/core/schema"
import { location } from "./fixture/location"
import { it } from "./lib/effect"
const cacheKey = "models-dev:catalog"
@@ -485,6 +488,49 @@ describe("ModelsDev Service", () => {
}),
)
it.live("refresh publishes Refreshed globally across locations", () =>
Effect.gen(function* () {
const cache = makeCache()
writeCache(cache, fixture, Date.now() - 10 * 60 * 1000)
const state = yield* Ref.make({ ...initialState, body: JSON.stringify(fixture2) })
yield* provided(
state,
cache,
Effect.gen(function* () {
const svc = yield* ModelsDev.Service
const bus = yield* Bus.Service
const refreshed = yield* bus
.subscribe(ModelsDev.Event.Refreshed)
.pipe(
Stream.take(1),
Stream.runCollect,
Effect.provideService(
Location.Service,
Location.Service.of(location({ directory: AbsolutePath.make("/other-location") })),
),
Effect.forkScoped,
)
.pipe(
Effect.flatMap((fiber) =>
Effect.gen(function* () {
yield* Effect.yieldNow
yield* svc.refresh(true).pipe(
Effect.provideService(
Location.Service,
Location.Service.of(location({ directory: AbsolutePath.make("/initial-location") })),
),
)
return yield* Fiber.join(fiber)
}),
),
)
expect(refreshed.length).toBe(1)
expect(refreshed[0]?.location).toBeUndefined()
}),
)
}),
)
it.live("refresh(false) stays quiet when the fetched body matches the cached digest", () =>
Effect.gen(function* () {
const cache = makeCache()