fix(app): fade home project list edges on scroll (#52358)

This commit is contained in:
David Hill
2026-10-29 22:51:05 -06:00
committed by GitHub
Unverified
parent fef232392d
commit ac5aae4c1c
2 changed files with 48 additions and 43 deletions
+24 -2
View File
@@ -1,5 +1,6 @@
import { createMemo, For, type JSX, onCleanup, Show, splitProps } from "solid-js"
import { createStore } from "solid-js/store"
import { createResizeObserver } from "@solid-primitives/resize-observer"
import { Popover } from "@kobalte/core/popover"
import {
displayName,
@@ -149,7 +150,17 @@ export function HomeProjectsView(props: HomeProjectsViewProps) {
}
function HomeProjectsPanel(props: HomeProjectsViewProps) {
let observer: MutationObserver | undefined
let frame = 0
const [contextMenu, setContextMenu] = createStore<{ open: string | undefined }>({ open: undefined })
const updateFades = (element: HTMLDivElement) => {
element.toggleAttribute("data-fade-top", element.scrollTop > 0)
element.toggleAttribute("data-fade-bottom", element.scrollTop + element.clientHeight < element.scrollHeight - 1)
}
onCleanup(() => {
observer?.disconnect()
cancelAnimationFrame(frame)
})
const contextMenuProps = {
contextMenuOpen: (id: string) => contextMenu.open === id,
@@ -197,8 +208,19 @@ function HomeProjectsPanel(props: HomeProjectsViewProps) {
</Show>
</div>
</Show>
<div data-slot="home-projects-scroll" class="relative flex min-h-0 min-w-0 shrink flex-col">
<div data-slot="home-projects-viewport" data-scrollable class="min-h-0 flex-1 overflow-y-auto">
<div data-slot="home-projects-scroll" class="flex min-h-0 min-w-0 shrink flex-col">
<div
data-slot="home-projects-viewport"
data-scrollable
class="min-h-0 flex-1 overflow-y-auto"
ref={(element) => {
createResizeObserver(element, () => updateFades(element))
observer = new MutationObserver(() => updateFades(element))
observer.observe(element, { childList: true, subtree: true })
frame = requestAnimationFrame(() => updateFades(element))
}}
onScroll={(event) => updateFades(event.currentTarget)}
>
<Show when={props.dropdown && props.servers.length === 1}>
<HomeProjectNavButton
type="button"
+24 -41
View File
@@ -264,15 +264,6 @@
}
}
@keyframes home-projects-fade-bottom {
from {
visibility: visible;
}
to {
visibility: hidden;
}
}
@keyframes session-dropzone-enter {
from {
opacity: 0;
@@ -344,16 +335,36 @@
}
}
[data-slot="home-projects-scroll"] {
timeline-scope: --home-projects-scroll;
/* A mask fades the rows themselves, so the edges work over any background, including the dropdown's. */
[data-slot="home-projects-viewport"][data-fade-top] {
--mask-start: 16px;
}
[data-slot="home-projects-viewport"][data-fade-bottom] {
--mask-end: 16px;
}
[data-slot="home-projects-viewport"]:is([data-fade-top], [data-fade-bottom]) {
-webkit-mask-image: linear-gradient(
to bottom,
transparent,
black var(--mask-start, 0px),
black calc(100% - var(--mask-end, 0px)),
transparent
);
mask-image: linear-gradient(
to bottom,
transparent,
black var(--mask-start, 0px),
black calc(100% - var(--mask-end, 0px)),
transparent
);
}
[data-slot="manage-models-scroll"] {
timeline-scope: --manage-models-scroll;
}
[data-slot="home-projects-scroll"]::before,
[data-slot="home-projects-scroll"]::after,
[data-slot="manage-models-scroll"]::before {
content: "";
position: absolute;
@@ -365,39 +376,11 @@
visibility: hidden;
}
[data-slot="home-projects-scroll"]::before {
top: 0;
background: linear-gradient(to bottom, var(--v2-background-bg-base), transparent);
}
[data-slot="manage-models-scroll"]::before {
top: 0;
background: linear-gradient(to bottom, var(--v2-background-bg-base), transparent);
}
[data-slot="home-projects-scroll"]::after {
bottom: 0;
background: linear-gradient(to top, var(--v2-background-bg-base), transparent);
}
@supports (animation-timeline: --home-projects-scroll) and (timeline-scope: --home-projects-scroll) {
[data-slot="home-projects-viewport"] {
scroll-timeline: --home-projects-scroll y;
}
[data-slot="home-projects-scroll"]::before {
animation: home-projects-fade-top linear both;
animation-timeline: --home-projects-scroll;
animation-range: 0 0.1px;
}
[data-slot="home-projects-scroll"]::after {
animation: home-projects-fade-bottom linear both;
animation-timeline: --home-projects-scroll;
animation-range: calc(100% - 1.1px) calc(100% - 1px);
}
}
@supports (animation-timeline: --manage-models-scroll) and (timeline-scope: --manage-models-scroll) {
[data-slot="manage-models-scroll"] .settings-panel {
scroll-timeline: --manage-models-scroll y;