mirror of
https://github.com/anomalyco/opencode.git
synced 2026-11-18 07:12:47 +03:00
fix(cli-rs): keep --print-logs records off the TUI screen
Capture stderr while the full-screen TUI runs. Records go to the console and reach the real stderr once the terminal is restored. TS draws them over the screen; see parity/deviations/G02-print-logs-tui.md.
This commit is contained in:
@@ -463,6 +463,9 @@ pub fn run(launch: Launch) -> opentui::Result<()> {
|
||||
suspend_on_ctrl_z: false,
|
||||
// `ThemeState` follows the palette when the `system` theme is active.
|
||||
palette_size: 16,
|
||||
// `--print-logs` records and stray stderr writes would draw over the screen; they go to the console and
|
||||
// reach the real stderr once the terminal is restored.
|
||||
capture_stderr: true,
|
||||
..AppOptions::default()
|
||||
};
|
||||
options.host.terminal.mouse =
|
||||
|
||||
@@ -0,0 +1,21 @@
|
||||
# G02: `--print-logs` while the full-screen TUI runs
|
||||
|
||||
TypeScript: the stderr logger (`packages/util/src/observability/logging.ts`) writes every record with
|
||||
`process.stderr.write`. OpenTUI's renderer runs with `externalOutputMode: "passthrough"` and does not capture
|
||||
stderr, so while the TUI is on the alternate screen the records draw over it. A 110x32 PTY run of
|
||||
`opencode --print-logs` with `OPENCODE_LOG_LEVEL=DEBUG` showed 137 records written inside the alternate screen,
|
||||
and none after it. They stay on the screen until the next redraw of those cells and are not in the scrollback.
|
||||
|
||||
Rust: `opencode_tui::run` sets `AppOptions::capture_stderr`. While the TUI runs, whatever the process writes to
|
||||
stderr (log records, stray `eprintln!`) goes to the opentui console, and is written to the real stderr after
|
||||
the terminal is restored. The same PTY run, with a record written to the process's stderr during the TUI, shows
|
||||
no record on the screen and the record after the alternate screen is left:
|
||||
|
||||
```
|
||||
log records inside the TUI: 0
|
||||
log records after the TUI: 1
|
||||
after: …[?1049l…timestamp=probe level=INFO message="written during the TUI"
|
||||
```
|
||||
|
||||
Reason: records drawn over the screen corrupt the UI and are lost when the alternate screen closes. Capturing
|
||||
them keeps the screen intact and keeps every record. The log file gets every record in both clients.
|
||||
Reference in New Issue
Block a user