fix(app): show every provider as a card in Manage models (#64235)

This commit is contained in:
Aarav Sareen
2026-11-16 20:01:05 +05:30
committed by GitHub
Unverified
parent cdd0585e04
commit e4606463e7
5 changed files with 86 additions and 53 deletions
+8 -24
View File
@@ -5,27 +5,28 @@
.settings-manage-models-dialog .settings-panel.settings-models {
height: 100%;
gap: 0;
gap: 8px;
padding: 0 8px 8px;
}
.settings-manage-models-dialog .settings-models .settings-section {
gap: 4px;
padding-block: 8px;
gap: 8px;
padding-block: 0 8px;
}
.settings-manage-models-dialog .settings-models .settings-section[data-expanded] {
padding-bottom: 8px;
}
.settings-manage-models-dialog .settings-models .settings-section + .settings-section {
border-top: 0.5px solid var(--v2-border-border-base);
}
.settings-manage-models-dialog .provider-model-groups {
gap: 8px;
}
.settings-manage-models-dialog .provider-model-group {
flex-shrink: 0;
margin: 0;
}
.settings-manage-models-dialog .provider-model-group-header {
padding: 4px;
border-radius: 0;
@@ -76,33 +77,16 @@
.manage-models-rows {
display: flex;
flex-direction: column;
gap: 1px;
}
.manage-models-rows .search-list-row {
position: relative;
height: 36px;
padding-inline: 8px;
border-radius: 6px;
}
.manage-models-rows .search-list-row:not(:last-child)::after {
content: "";
position: absolute;
inset-inline: 8px;
bottom: -0.75px;
height: 0.5px;
background: var(--v2-border-border-base);
pointer-events: none;
}
@media (hover: hover) {
.manage-models-rows .search-list-row:hover {
background: var(--v2-overlay-simple-overlay-hover);
}
.manage-models-rows .search-list-row:hover::after,
.manage-models-rows .search-list-row:has(+ .search-list-row:hover)::after {
opacity: 0;
}
}
+1 -13
View File
@@ -32,9 +32,6 @@ export const DialogManageModels: Component = () => {
const providerList = (providerID: string) => local.model.list().filter((x) => x.provider.id === providerID)
const providerVisible = (providerID: string) =>
providerList(providerID).every((x) => local.model.visible({ modelID: x.id, providerID: x.provider.id }))
const setProviderVisibility = (providerID: string, checked: boolean) => {
providerList(providerID).forEach((x) => {
local.model.setVisibility({ modelID: x.id, providerID: x.provider.id }, checked)
@@ -160,16 +157,7 @@ export const DialogManageModels: Component = () => {
disabled={searching()}
onExpandedChange={(key, value) => setStore("collapsed", key, !value)}
onSetVisibility={setProviderVisibility}
action={(group) => (
<Switch
class="me-6"
checked={providerVisible(group.category)}
onChange={(checked) => setProviderVisibility(group.category, checked)}
hideLabel
>
{group.items[0].provider.name}
</Switch>
)}
cards
rows={(items) => <ModelRows items={items} />}
/>
</Show>
@@ -25,6 +25,7 @@ function CustomManagedProviderIcon(props: { class?: string }) {
}
export function ProviderModelIcon(props: { provider: ModelProvider; class?: string }) {
// SAFETY: the cast only lets `includes` look up any string; the type guard narrows on the result.
const icon = () =>
[
props.provider.canonical,
@@ -62,6 +63,8 @@ export function ProviderModelSections<T extends ModelItem>(props: {
rows: (items: T[]) => JSX.Element
/** Trailing control in a direct provider's header. */
action?: (group: ModelGroup<T>) => JSX.Element
/** Shows direct providers as cards like the Console's providers, instead of section headers. */
cards?: boolean
onSetVisibility?: (providerID: string, visible: boolean) => void
ref?: (providerID: string, element: HTMLElement) => void
}) {
@@ -127,20 +130,41 @@ export function ProviderModelSections<T extends ModelItem>(props: {
fallback={
<Show when={section.group}>
{(group) => (
<section
ref={(element) => props.ref?.(group().category, element)}
class="settings-section"
data-component="settings-models-provider"
data-expanded={props.expanded(group().category) ? "" : undefined}
<Show
when={props.cards}
fallback={
<section
ref={(element) => props.ref?.(group().category, element)}
class="settings-section"
data-component="settings-models-provider"
data-expanded={props.expanded(group().category) ? "" : undefined}
>
<Header
id={group().category}
icon={<ProviderModelIcon provider={group().items[0].provider} class="shrink-0" />}
title={name(group())}
action={props.action?.(group())}
/>
<Show when={props.expanded(group().category)}>{props.rows(group().items)}</Show>
</section>
}
>
<Header
id={group().category}
icon={<ProviderModelIcon provider={group().items[0].provider} class="shrink-0" />}
title={name(group())}
action={props.action?.(group())}
/>
<Show when={props.expanded(group().category)}>{props.rows(group().items)}</Show>
</section>
<ProviderModelGroup
ref={(element) => props.ref?.(group().category, element)}
provider={group().items[0].provider}
name={name(group())}
expanded={props.expanded(group().category)}
disabled={props.disabled}
onSetVisibility={
props.onSetVisibility
? (visible) => props.onSetVisibility?.(group().category, visible)
: undefined
}
onExpandedChange={(value) => props.onExpandedChange(group().category, value)}
>
{props.rows(group().items)}
</ProviderModelGroup>
</Show>
)}
</Show>
}
@@ -159,6 +183,16 @@ export function ProviderModelSections<T extends ModelItem>(props: {
/>
<Show when={props.expanded(CONSOLE_GROUP_KEY)}>
<div class="provider-model-groups settings-models-console-groups">
{/* The header button already collapses the Console for the keyboard and screen readers. */}
<button
type="button"
class="settings-models-console-rail"
tabIndex={-1}
aria-hidden="true"
disabled={props.disabled}
onMouseDown={(event) => event.preventDefault()}
onClick={() => props.onExpandedChange(CONSOLE_GROUP_KEY, false)}
/>
<For each={managed().providers}>
{(group) => (
<ProviderModelGroup
@@ -23,8 +23,8 @@
}
.settings-models-console-groups {
--console-rail-strip: 8px;
margin-inline-start: 4px;
padding-inline-start: 8px;
}
.provider-model-group-trigger,
+29 -2
View File
@@ -1551,9 +1551,36 @@
}
.settings-models-console-groups {
--console-rail-strip: 16px;
position: relative;
margin-inline-start: 14px;
padding-inline-start: 16px;
border-inline-start: 0.5px solid var(--v2-border-border-base);
padding-inline-start: var(--console-rail-strip);
}
.settings-models-console-rail {
position: absolute;
inset-block: 0;
inset-inline-start: -4px;
width: calc(var(--console-rail-strip) + 4px);
padding: 0;
border: 0;
background: transparent;
cursor: default;
&::before {
content: "";
position: absolute;
inset-block: 0;
inset-inline-start: 4px;
width: 1px;
background-color: color-mix(in srgb, var(--v2-border-border-base) 50%, transparent);
}
}
@media (hover: hover) {
.settings-models-console-rail:not(:disabled):hover::before {
background-color: var(--v2-border-border-base);
}
}
.provider-model-group {