mirrors/opencode
1
0
Fork 0
mirror of https://github.com/anomalyco/opencode.git synced 2026-11-13 19:46:16 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix(app): list only files under Recently closed (#57963)

Browse Source
This commit is contained in:
James Long
2026-10-21 19:24:29 -04:00
committed by GitHub
Unverified
parent 8f957a36ec
commit f1bedd97b7
2 changed files with 11 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/app/e2e/regression/review.spec.ts
+6 -10
View File
@@ -363,13 +363,10 @@ test("context closes the side region only when its button opened it", async ({ p
.click()
await expect(context).toHaveAttribute("aria-selected", "true")
await expect(newTab).toHaveCount(0)
// The New tab view now lists the closed Review under "Recently closed" too; reopening it brings back the same tab.
// "Recently closed" lists only files, so the closed Review is offered again by its launcher alone.
await panel.getByRole("button", { name: "Add tab", exact: true }).click()
await expect(panel.getByRole("region", { name: "Recently closed", exact: true })).toContainText("Review")
await panel
.getByRole("region", { name: "Recently closed", exact: true })
.getByRole("button", { name: /^Review/ })
.click()
await expect(panel.getByRole("region", { name: "Recently closed", exact: true })).toHaveCount(0)
await panel.getByRole("button", { name: /^Review/ }).click()
await expect(panel.locator("#session-side-panel-review-tab")).toHaveAttribute("aria-selected", "true")
await context.click()
await contextButton.click()
@@ -1264,10 +1261,9 @@ test("names a single change source and keeps the review header rows at 48px", as
await expect(region).toHaveAttribute("aria-expanded", "false")
await region.click()
await expect(panel.getByRole("tab")).toHaveCount(0)
// Its launchers, then the closed Review under "Recently closed".
const closed = panel.getByRole("region", { name: "Recently closed", exact: true })
await expect(panel.getByRole("button", { name: /^Review/ }).first()).toBeVisible()
await expect(closed.getByRole("button", { name: /^Review/ })).toBeVisible()
// Only its launchers: "Recently closed" lists files, not the closed Review.
await expect(panel.getByRole("button", { name: /^Review/ })).toBeVisible()
await expect(panel.getByRole("region", { name: "Recently closed", exact: true })).toHaveCount(0)
})
for (const direction of ["ltr", "rtl"] as const) {
packages/app/src/runtime/extension/panels.tsx
+5 -2
View File
@@ -385,11 +385,14 @@ export function createRegion(input: {
}),
)
},
/** The session's closed tabs that are not open again, newest first. */
/**
* The session's closed files that are not open again, newest first, as "Recently closed" lists them. ⌘⇧T still
* reopens the newest closed tab of any kind.
*/
recent: createMemo(() => {
const open = new Set(stored())
return input.closed.list(input.view()).filter((entry) => !open.has(entry.key))
return input.closed.list(input.view()).filter((entry) => !!entry.file && !open.has(entry.key))
}),
/** Brings back the closed tab under `key`, or the newest one. */
reopen(key?: string) {