mirror of
https://github.com/anomalyco/opencode.git
synced 2026-11-18 07:12:47 +03:00
fix(tui): stop session titles with newlines from crashing the TUI (#57523)
Co-authored-by: Daniel Smolsky <dannysmo@gmail.com>
This commit is contained in:
@@ -5,7 +5,7 @@ type TitleRenderer = Pick<CliRenderer, "isDestroyed" | "controlState" | "setTerm
|
||||
// OpenTUI rejects terminal control from suspend() until resume() completes, e.g. while $EDITOR runs.
|
||||
export function setTerminalTitle(renderer: TitleRenderer, title: string) {
|
||||
if (renderer.isDestroyed || renderer.controlState === RendererControlState.EXPLICIT_SUSPENDED) return
|
||||
renderer.setTerminalTitle(title)
|
||||
renderer.setTerminalTitle(title.replace(/[\u0000-\u001f\u007f-\u009f]+/g, " "))
|
||||
}
|
||||
|
||||
export function destroyRenderer(renderer: TitleRenderer & Pick<CliRenderer, "destroy">) {
|
||||
|
||||
@@ -3,6 +3,12 @@ import { RendererControlState } from "@opentui/core"
|
||||
import { createTestRenderer } from "@opentui/core/testing"
|
||||
import { destroyRenderer, setTerminalTitle } from "../../src/util/renderer"
|
||||
|
||||
test("sets a title that contains control characters", async () => {
|
||||
await using setup = await createTestRenderer({ width: 10, height: 2 })
|
||||
await setup.renderer.setupTerminal()
|
||||
expect(() => setTerminalTitle(setup.renderer, "Fix parser bug\nin tokenizer")).not.toThrow()
|
||||
})
|
||||
|
||||
test("clears the terminal title before destroying the renderer", () => {
|
||||
const calls: string[] = []
|
||||
destroyRenderer({
|
||||
|
||||
Reference in New Issue
Block a user