fix(tui): stop session titles with newlines from crashing the TUI (#57523)

Co-authored-by: Daniel Smolsky <dannysmo@gmail.com>
This commit is contained in:
Wish
2026-11-05 03:21:07 +05:30
committed by GitHub
Unverified
parent e0300a9bfc
commit 65f646f8d7
2 changed files with 7 additions and 1 deletions
+1 -1
View File
@@ -5,7 +5,7 @@ type TitleRenderer = Pick<CliRenderer, "isDestroyed" | "controlState" | "setTerm
// OpenTUI rejects terminal control from suspend() until resume() completes, e.g. while $EDITOR runs.
export function setTerminalTitle(renderer: TitleRenderer, title: string) {
if (renderer.isDestroyed || renderer.controlState === RendererControlState.EXPLICIT_SUSPENDED) return
renderer.setTerminalTitle(title)
renderer.setTerminalTitle(title.replace(/[\u0000-\u001f\u007f-\u009f]+/g, " "))
}
export function destroyRenderer(renderer: TitleRenderer & Pick<CliRenderer, "destroy">) {
+6
View File
@@ -3,6 +3,12 @@ import { RendererControlState } from "@opentui/core"
import { createTestRenderer } from "@opentui/core/testing"
import { destroyRenderer, setTerminalTitle } from "../../src/util/renderer"
test("sets a title that contains control characters", async () => {
await using setup = await createTestRenderer({ width: 10, height: 2 })
await setup.renderer.setupTerminal()
expect(() => setTerminalTitle(setup.renderer, "Fix parser bug\nin tokenizer")).not.toThrow()
})
test("clears the terminal title before destroying the renderer", () => {
const calls: string[] = []
destroyRenderer({